Moodle

Table edition dialog in HTML Editor displays without buttons

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.6.3, 1.7
  • Fix Version/s: None
  • Component/s: HTML Editor
  • Labels:
    None
  • Environment:
    Browser: MS IE
  • Affected Branches:
    MOODLE_16_STABLE, MOODLE_17_STABLE

Description

Dialog popup window for inserting a table hides Ok and Cancel buttons in Slovak (Sk) translation. This occurs only in MS IE Browser 6. It is caused by language strings that are of greater length that the original english ones. This causes the window texts to grow and to hide the buttons. I attach figurese with window in English and Slovak.

In my opinion, there are two possible remedies, both in moodle/lib/editor/htmlarea/dialog.js

  • change the dimensions for insert_table, here are the original ones: case "insert_table": x = 420; y = 250; break;
    However, it is not clear how to set the dimensions and it does not look ok in other browsers.
  • a much cleaner solution is to enable scrollable windows, line 47: scrollbars=yes

I opt for the second solution that works nicely at our site.

Activity

Hide
Nicolas Martignoni added a comment -

I'm confirming this issue. It appears also in french language. Though the problem doesn't occur in english (and neither in german), it's very annoying. Thank you to fix this. A solution could be patching the moodle/lib/editor/htmlarea/insert_table.php file.

For other solution suggestions, see this discussion: http://moodle.org/mod/forum/discuss.php?d=24818 (in french).

Or could we inspire us of the moodle/lib/editor/htmlarea/insert_image.php file?

Show
Nicolas Martignoni added a comment - I'm confirming this issue. It appears also in french language. Though the problem doesn't occur in english (and neither in german), it's very annoying. Thank you to fix this. A solution could be patching the moodle/lib/editor/htmlarea/insert_table.php file. For other solution suggestions, see this discussion: http://moodle.org/mod/forum/discuss.php?d=24818 (in french). Or could we inspire us of the moodle/lib/editor/htmlarea/insert_image.php file?
Hide
Nicolas Martignoni added a comment -

Any progress here? Could we hope fix for 1.8?

Show
Nicolas Martignoni added a comment - Any progress here? Could we hope fix for 1.8?
Hide
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Nicolas Martignoni added a comment -

Not relevant any more, as we don't use HTMLArea any more. Suggest closing as fixed.

Show
Nicolas Martignoni added a comment - Not relevant any more, as we don't use HTMLArea any more. Suggest closing as fixed.

People

Vote (6)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: