[#MDL-7878] Link identification and skipping

Issue Details (XML | Word | Printable)

Key:	MDL-7878
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Nick Freear
Reporter:	Martin Dougiamas
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-7860

Link identification and skipping

Created: 11/Dec/06 03:21 PM Updated: 09/Jan/08 04:48 PM

Return to search

Component/s:

Accessibility

Affects Version/s:

1.7, 1.9

Fix Version/s:

1.8.4, 1.9, 2.0

File Attachments:

patch-MDL-7878-skip-course-2.diff (9 kB)
2.

patch-MDL-7878-skip-course-32.diff (4 kB)

Issue Links:

Blockers

This issue blocks:

~~MDL-12298~~ META BUG: Accessibility improvements in Moodle 1.9

Dependency

This issue will help resolve:

MDL-4994 Need skip navigation link in header.html

This issue will be resolved by:

MDL-10340 Need to add a "jump to content" anchor link to "#section-0"

Relates

This issue has a non-specific relationship to:

MDL-9306 Main course formats need to have tables removed but keep AJAX working

Participants:	Martin Dougiamas and Nick Freear
Security Level:	None
Resolved date:	07/Nov/07
Affected Branches:	MOODLE_17_STABLE, MOODLE_19_STABLE
Fixed Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

« Hide

Clearly identify the distinction of each hypertext link with meaningful text if read out of context, or associate with alterative links that have the same explanatory characteristics, and provide mechanisms that allow repeated reading of sequences of links common to several pages to be avoided.

WCAG 1.0 References: 13.1, 13.6
Sec. 508 References: 1194.22 (o)

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 11/Dec/06 11:06 PM

Skip links have been added to the blocks, but one link to "skip to content" would be most useful.

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 02/Jan/07 04:33 PM

this can go in pagelib

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 04/Jan/07 12:50 PM

Skip links have been added to course pages and admin settings pages (using accesshide to hide them from normal browsers)

[ Permalink | « Hide ]

Nick Freear added a comment - 15/Oct/07 08:09 PM - edited

We need more discussion of these accessibility fixes - this helps fix MDL-4994, however:
1) Better if the 'pagelib' link was the first text on page, just after <body> opening tag.
2) Its broken in Internet Explorer, see recent fix for skip block links, ~~MDL-11676~~.
3) Its inaccessible to most keyboard-only users (except screen reader users), ~~MDL-11695~~.

I'll try to quickly do a fix, for 1.9!

[ Permalink | « Hide ]

Nick Freear added a comment - 15/Oct/07 09:55 PM

This patch fixes the 3 issues identified above. It affects these 4 files,

all, course/format/(NAME)/format.php - 1 line.
lib/pagelib.php -2 lines, print_header
lib/weblib.php +5 lines, print_header, including regular expression (could be 'split')
theme/standard/styles_layout.css

Also cleans up, lang/en_utf8/moodle.php, theme/standard/styles_color.css, theme/formal_white/fw_layout.css (unused styles).

[ Permalink | « Hide ]

Nick Freear added a comment - 15/Oct/07 09:59 PM

Martin, I'm happy to commit this, if you give the nod.

Note, I'd like to revisit this post-1.9 as this only adds the skip link to course pages, not the home page, modules etc. (Which is why MDL-4994 hasn't been fixed!)

Many thanks, Nick.

[ Permalink | « Hide ]

Nick Freear added a comment - 21/Oct/07 06:52 AM

I'm currently working on this (assigned to me, elevated priority). Having problems with CVS, but hope to commit tomorrow BST - HEAD and 1.9 branches.

[ Permalink | « Hide ]

Nick Freear added a comment - 22/Oct/07 05:42 PM

I've committed fixes in 2 stages to 1.9 branch and HEAD, tagged _MERGED.

Part 1 is based on the patch (..course-2.diff) above, but introduces the 'skip_main_destination' function to weblib.php - the skip link is still printed in pagelib.php and this fixes all course formats.
Part 2 is attached (..course-32.diff) - it replaces the pagelib skip link with one in print_header in weblib, and adds skip links to /index.php and course/index.php.

Tested on,

'weekscss' and 'topics' course formats;
'standardwhite' and 'cornflower' themes;
Win/IE 6, Mac/Firefox 2, Safari (tab key not for links, not functional) (Opera, tab key not for links, use 'a' key).

[ Permalink | « Hide ]

Nick Freear added a comment - 22/Oct/07 05:44 PM

(Note, 'skip_main_destination' function should perhaps be 'print_skip_main_destination' - post 1.9?)

Fixed.

[ Permalink | « Hide ]

Nick Freear added a comment - 07/Nov/07 01:34 AM

Reopening - need to use "skip_main_destination" function in Ann Adamcik's "topicscss" course format, see MDL-9306.

[ Permalink | « Hide ]

Nick Freear added a comment - 07/Nov/07 01:57 AM

(Link - Ann Adamcik's new "topicscss" course format.)

[ Permalink | « Hide ]

Nick Freear added a comment - 07/Nov/07 01:58 AM

Fix to "topicscss" in HEAD.

[ Permalink | « Hide ]

Nick Freear added a comment - 07/Nov/07 02:01 AM

(Non-specific link to MDL-9306, try again!)

[ Permalink | « Hide ]

Nick Freear added a comment - 21/Nov/07 07:46 PM

(Adding link to meta-bug.)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.