Issue Details (XML | Word | Printable)

Key: MDL-7878
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Nick Freear
Reporter: Martin Dougiamas
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-7860

Link identification and skipping

Created: 11/Dec/06 03:21 PM   Updated: 09/Jan/08 04:48 PM
Return to search
Component/s: Accessibility
Affects Version/s: 1.7, 1.9
Fix Version/s: 1.8.4, 1.9, 2.0

File Attachments: 1. File patch-MDL-7878-skip-course-2.diff (9 kB)
2. File patch-MDL-7878-skip-course-32.diff (4 kB)
Issue Links:
Blockers
 
Dependency
Relates
 

Participants: Martin Dougiamas and Nick Freear
Security Level: None
Resolved date: 07/Nov/07
Affected Branches: MOODLE_17_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Clearly identify the distinction of each hypertext link with meaningful text if read out of context, or associate with alterative links that have the same explanatory characteristics, and provide mechanisms that allow repeated reading of sequences of links common to several pages to be avoided.

WCAG 1.0 References: 13.1, 13.6
Sec. 508 References: 1194.22 (o)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 11/Dec/06 11:06 PM
Skip links have been added to the blocks, but one link to "skip to content" would be most useful.

[ Permalink | « Hide ]
Martin Dougiamas added a comment - 02/Jan/07 04:33 PM
this can go in pagelib

moodler committed 8 files to 'Moodle CVS' - 04/Jan/07 12:37 AM
Added skip links to all course formats to main content MDL-7878
MODIFY course/format/weekscss/Attic/format.php   Rev. 1.19    (+3 -3 lines)
MODIFY lang/en_utf8/moodle.php   Rev. 1.93    (+2 -1 lines)
MODIFY course/format/topics/format.php   Rev. 1.70    (+3 -3 lines)
MODIFY course/format/scorm/format.php   Rev. 1.7    (+2 -2 lines)
MODIFY course/format/weeks/format.php   Rev. 1.60    (+3 -3 lines)
MODIFY course/format/lams/Attic/format.php   Rev. 1.14    (+2 -2 lines)
MODIFY course/format/social/format.php   Rev. 1.32    (+2 -2 lines)
MODIFY lib/pagelib.php   Rev. 1.51    (+4 -2 lines)
Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 04/Jan/07 03:56 AM
Translated a new string 'Skip forward to main content' MDL-7878.
MODIFY ja_utf8/moodle.php   Rev. 1.179    (+1 -0 lines)
MODIFY ja_utf8/README   Rev. 1.287    (+1 -1 lines)
[ Permalink | « Hide ]
Martin Dougiamas added a comment - 04/Jan/07 12:50 PM
Skip links have been added to course pages and admin settings pages (using accesshide to hide them from normal browsers)

Martin Dougiamas made changes - 04/Jan/07 12:52 PM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
martignoni committed 1 file to 'Lang CVS' - 04/Jan/07 07:38 PM
Added skip links to all course formats to main content MDL-7878
MODIFY fr_utf8/moodle.php   Rev. 1.116    (+1 -0 lines)
[ Permalink | « Hide ]
Nick Freear added a comment - 15/Oct/07 08:09 PM - edited
We need more discussion of these accessibility fixes - this helps fix MDL-4994, however:
1) Better if the 'pagelib' link was the first text on page, just after <body> opening tag.
2) Its broken in Internet Explorer, see recent fix for skip block links, MDL-11676.
3) Its inaccessible to most keyboard-only users (except screen reader users), MDL-11695.

I'll try to quickly do a fix, for 1.9!


Nick Freear made changes - 15/Oct/07 08:09 PM
Link This issue will help resolve MDL-4994 [ MDL-4994 ]
[ Permalink | « Hide ]
Nick Freear added a comment - 15/Oct/07 09:55 PM
This patch fixes the 3 issues identified above. It affects these 4 files,
  • all, course/format/(NAME)/format.php - 1 line.
  • lib/pagelib.php -2 lines, print_header
  • lib/weblib.php +5 lines, print_header, including regular expression (could be 'split')
  • theme/standard/styles_layout.css

Also cleans up, lang/en_utf8/moodle.php, theme/standard/styles_color.css, theme/formal_white/fw_layout.css (unused styles).


Nick Freear made changes - 15/Oct/07 09:55 PM
Attachment patch-MDL-7878-skip-course-2.diff [ 12087 ]
[ Permalink | « Hide ]
Nick Freear added a comment - 15/Oct/07 09:59 PM
Martin, I'm happy to commit this, if you give the nod.

Note, I'd like to revisit this post-1.9 as this only adds the skip link to course pages, not the home page, modules etc. (Which is why MDL-4994 hasn't been fixed!)

Many thanks, Nick.


Nick Freear made changes - 15/Oct/07 09:59 PM
Resolution Fixed [ 1 ]
Fix Version/s 2.0 [ 10122 ]
Fix Version/s 1.8.4 [ 10242 ]
Fix Version/s 1.9 [ 10190 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Nick Freear made changes - 21/Oct/07 06:50 AM
Assignee Martin Dougiamas [ dougiamas ] Nick Freear [ nfreear ]
[ Permalink | « Hide ]
Nick Freear added a comment - 21/Oct/07 06:52 AM
I'm currently working on this (assigned to me, elevated priority). Having problems with CVS, but hope to commit tomorrow BST - HEAD and 1.9 branches.

Nick Freear made changes - 21/Oct/07 06:52 AM
Affects Version/s 1.9 [ 10190 ]
Priority Minor [ 4 ] Major [ 3 ]
Nick Freear committed 13 files to 'Moodle CVS' - 22/Oct/07 02:43 PM
Partial fix for reopened bug MDL-7878, "Link identification and skipping" - affects all course formats + other files.
MODIFY lang/en_utf8/moodle.php   Rev. 1.143    (+1 -2 lines)
MODIFY theme/standard/styles_color.css   Rev. 1.151    (+0 -6 lines)
MODIFY course/format/weekscss/Attic/format.php   Rev. 1.25    (+2 -2 lines)
MODIFY course/format/scorm/format.php   Rev. 1.13    (+2 -2 lines)
MODIFY lang/en_utf8/access.php   Rev. 1.9    (+2 -2 lines)
MODIFY course/format/lams/Attic/format.php   Rev. 1.26    (+2 -2 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.520    (+4 -9 lines)
MODIFY course/format/topics/format.php   Rev. 1.84    (+2 -2 lines)
MODIFY lib/weblib.php   Rev. 1.979    (+18 -2 lines)
MODIFY course/format/social/format.php   Rev. 1.42    (+2 -2 lines)
MODIFY course/format/weeks/format.php   Rev. 1.75    (+2 -2 lines)
MODIFY theme/formal_white/fw_layout.css   Rev. 1.14    (+0 -6 lines)
MODIFY lib/pagelib.php   Rev. 1.65    (+3 -3 lines)
Nick Freear committed 13 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 22/Oct/07 02:51 PM
Partial fix for reopened bug MDL-7878, "Link identification and skipping" - affects all course formats + other files. Merged.
MODIFY theme/standard/styles_color.css   Rev. 1.149.2.2    (+0 -6 lines)
MODIFY theme/formal_white/fw_layout.css   Rev. 1.13.2.1    (+0 -6 lines)
MODIFY course/format/social/format.php   Rev. 1.41.2.1    (+2 -2 lines)
MODIFY course/format/weekscss/Attic/format.php   Rev. 1.24.2.1    (+2 -2 lines)
MODIFY lang/en_utf8/access.php   Rev. 1.8.2.1    (+2 -2 lines)
MODIFY course/format/weeks/format.php   Rev. 1.74.2.1    (+2 -2 lines)
MODIFY lib/weblib.php   Rev. 1.970.2.9    (+18 -2 lines)
MODIFY lang/en_utf8/moodle.php   Rev. 1.141.2.2    (+1 -2 lines)
MODIFY lib/pagelib.php   Rev. 1.62.2.3    (+3 -3 lines)
MODIFY course/format/lams/Attic/format.php   Rev. 1.25.2.1    (+2 -2 lines)
MODIFY course/format/topics/format.php   Rev. 1.83.2.1    (+2 -2 lines)
MODIFY course/format/scorm/format.php   Rev. 1.12.2.1    (+2 -2 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.516.2.4    (+4 -9 lines)
Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 22/Oct/07 03:31 PM
Updated a translated string for "Link identification and skipping" based on lang/en_utf8 change MDL-7878.
MODIFY ja_utf8/moodle.php   Rev. 1.248    (+2 -2 lines)
MODIFY ja_utf8/access.php   Rev. 1.10    (+5 -5 lines)
Nick Freear committed 4 files to 'Moodle CVS' - 22/Oct/07 05:21 PM
Fix for reopened bug MDL-7878, "Link identification and skipping" - includes site and course index.php.
MODIFY lib/weblib.php   Rev. 1.980    (+8 -5 lines)
MODIFY lib/pagelib.php   Rev. 1.66    (+2 -4 lines)
MODIFY course/index.php   Rev. 1.90    (+3 -1 lines)
MODIFY index.php   Rev. 1.202    (+2 -2 lines)
Nick Freear committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 22/Oct/07 05:25 PM
Fix for reopened bug MDL-7878, "Link identification and skipping" - includes site and course index.php. Merged.
MODIFY index.php   Rev. 1.201.2.1    (+2 -2 lines)
MODIFY lib/weblib.php   Rev. 1.970.2.10    (+8 -5 lines)
MODIFY course/index.php   Rev. 1.89.2.1    (+3 -1 lines)
MODIFY lib/pagelib.php   Rev. 1.62.2.4    (+2 -4 lines)
[ Permalink | « Hide ]
Nick Freear added a comment - 22/Oct/07 05:42 PM
I've committed fixes in 2 stages to 1.9 branch and HEAD, tagged _MERGED.
  • Part 1 is based on the patch (..course-2.diff) above, but introduces the 'skip_main_destination' function to weblib.php - the skip link is still printed in pagelib.php and this fixes all course formats.
  • Part 2 is attached (..course-32.diff) - it replaces the pagelib skip link with one in print_header in weblib, and adds skip links to /index.php and course/index.php.

Tested on,

  • 'weekscss' and 'topics' course formats;
  • 'standardwhite' and 'cornflower' themes;
  • Win/IE 6, Mac/Firefox 2, Safari (tab key not for links, not functional) (Opera, tab key not for links, use 'a' key).

Nick Freear made changes - 22/Oct/07 05:42 PM
Attachment patch-MDL-7878-skip-course-32.diff [ 12125 ]
[ Permalink | « Hide ]
Nick Freear added a comment - 22/Oct/07 05:44 PM
(Note, 'skip_main_destination' function should perhaps be 'print_skip_main_destination' - post 1.9?)

Fixed.


Nick Freear made changes - 22/Oct/07 05:44 PM
Status Reopened [ 4 ] Resolved [ 5 ]
Fix Version/s 1.8 [ 10130 ]
Resolution Fixed [ 1 ]
martignoni committed 2 files to 'Lang CVS' - 23/Oct/07 03:29 AM
Partial fix for reopened bug MDL-7878, "Link identification and skipping" - affects all course formats + other files.
MODIFY fr_utf8/access.php   Rev. 1.8    (+2 -2 lines)
MODIFY fr_utf8/moodle.php   Rev. 1.175    (+1 -2 lines)
[ Permalink | « Hide ]
Nick Freear added a comment - 07/Nov/07 01:34 AM
Reopening - need to use "skip_main_destination" function in Ann Adamcik's "topicscss" course format, see MDL-9306.

Nick Freear made changes - 07/Nov/07 01:34 AM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
[ Permalink | « Hide ]
Nick Freear added a comment - 07/Nov/07 01:57 AM
(Link - Ann Adamcik's new "topicscss" course format.)

Nick Freear made changes - 07/Nov/07 01:57 AM
Link This issue will help resolve MDL-9306 [ MDL-9306 ]
[ Permalink | « Hide ]
Nick Freear added a comment - 07/Nov/07 01:58 AM
Fix to "topicscss" in HEAD.

Nick Freear made changes - 07/Nov/07 01:58 AM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]
Nick Freear made changes - 07/Nov/07 01:59 AM
Link This issue will help resolve MDL-9306 [ MDL-9306 ]
[ Permalink | « Hide ]
Nick Freear added a comment - 07/Nov/07 02:01 AM
(Non-specific link to MDL-9306, try again!)

Nick Freear made changes - 07/Nov/07 02:01 AM
Link This issue has a non-specific relationship to MDL-9306 [ MDL-9306 ]
Nick Freear committed 1 file to 'Moodle CVS' - 07/Nov/07 02:46 AM
Fixes MDL-7878 in new course format, "Link identification and skipping" - skip_main_destination function + use the $currenttext string (MDL-11439) - both accessibility related.
MODIFY course/format/topicscss/Attic/format.php   Rev. 1.2    (+2 -2 lines)
Nick Freear committed 1 file to 'Moodle CVS' - 14/Nov/07 02:16 AM
Follow up fix for MDL-7878 "Link identification and skipping" (and MDL-9306 "Replaced weeks..") - duplicate skip_main_destination().
MODIFY course/format/weeks/format.php   Rev. 1.77    (+3 -3 lines)
[ Permalink | « Hide ]
Nick Freear added a comment - 21/Nov/07 07:46 PM
(Adding link to meta-bug.)

Nick Freear made changes - 21/Nov/07 07:46 PM
Link This issue blocks MDL-12298 [ MDL-12298 ]
Mathieu Petit-Clair made changes - 09/Jan/08 04:48 PM
Link This issue will be resolved by MDL-10340 [ MDL-10340 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators