Issue Details (XML | Word | Printable)

Key: MDL-7883
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Martin Dougiamas
Reporter: Nick Freear
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

'application/xhtml' and XHTML Strict preferred, initially in debug mode

Created: 11/Dec/06 06:35 PM   Updated: 23/Apr/09 06:07 PM
Return to search
Component/s: General
Affects Version/s: 1.7
Fix Version/s: None

File Attachments: 1. File patch-06dec2006-strictxml-weblib_2.diff (4 kB)

Environment:
Components: Markup, Standards

Tests server variables: HTTP_ACCEPT, HTTP_USER_AGENT
Issue Links:
Dependency
 
Relates
 

Database: Any
Participants: Jeffrey Silverman, Jon Papaioannou, Martin Dougiamas and Nick Freear
Security Level: None
Resolved date: 12/Dec/06
Affected Branches: MOODLE_17_STABLE


 Description  « Hide
http://www.w3.org/TR/2002/NOTE-xhtml-media-types-20020801/

Just seen Bug MDL-7861 - I've been looking at something similar, initially for debugging. In DEBUG_DEVELOPER mode this patch delivers pages as the preferred 'application/xhtml+xml' mime-type to supporting browsers (Firefox, Opera, iCab... Safari issue with character entities, http://www.w3.org/2000/07/8378/xhtml/entities) and 'application/xml' for Win-IE 5+ (http://www.w3.org/MarkUp/2004/xhtml-faq#ie). Other browsers get 'text/html'.

An XML well-formed bug (stray &, unquoted attributes...) leads to an XHTML browser displaying an error message in place of the page, which should be useful for developers. (Note, an on/off switch may be useful to aid diagnosis.)

The patch also substitutes the XHTML Strict document-type declaration in DEBUG_NORMAL mode - note, error messages aren't displayed in the browser, a 3rd party validator is required.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
moodler committed 2 files to 'Moodle CVS' - 12/Dec/06 04:24 PM
Added changes suggested by Nick in MDL-7883 to help debug XHTML strict

It only affects DEBUG_DEVELOPER mode, and causes the browser to break when it encounters non-strict XHTML.

I took out the changes for DEBUG_NORMAL for now, might be premature.
MODIFY lib/weblib.php   Rev. 1.704    (+62 -5 lines)
ADD lib/xhtml.xsl   Rev. 1.1    (+0 -0 lines)