[#MDL-7884] XML well-formed bug, need space before 'checked' attribute.

Issue Details (XML | Word | Printable)

Key:	MDL-7884
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Nick Freear
Reporter:	Nick Freear
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

XML well-formed bug, need space before 'checked' attribute.

Created: 11/Dec/06 07:16 PM Updated: 11/Dec/06 07:33 PM

Return to search

Component/s:

General

Affects Version/s:

1.8

Fix Version/s:

1.8

File Attachments:

patch-MDL-7884-upgradesettings.php.diff (1 kB)

Environment:

Components: Markup

Issue Links:

Dependency

This issue will be resolved by:

~~MDL-7883~~ 'application/xhtml' and XHTML Strict preferred, initially in debug mode

URL:	Internal, http://---dev.open.ac.uk/head/admin/upgradesettings.php
Participants:	Nick Freear
Security Level:	None
Resolved date:	11/Dec/06
Affected Branches:	MOODLE_18_STABLE
Fixed Branches:	MOODLE_18_STABLE

Description

« Hide

cvs:/lib/adminlib.php class admin_setting_special_gradebookroles::output_html (around line 2359)
- spotted with patch from Bug ~~MDL-7883~~ ;-)

" XML Parsing Error: not well-formed
Location: http://---dev.open.ac.uk/head/admin/upgradesettings.php
Line Number 257, Column 518:

<div class="form-group"> ... <input type="checkbox" name="s_gradebookroles[5]" value="1"checked="checked"
..."

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Nick Freear added a comment - 11/Dec/06 07:25 PM

Also missing closing '</fieldset>' tag, cvs:/admin/upgradesettings.php

[ Permalink | « Hide ]

Nick Freear added a comment - 11/Dec/06 07:31 PM

Actually, not sure this affects Moodle 1.7*, but it does affect 1.8 dev.

[ Permalink | « Hide ]

Nick Freear added a comment - 11/Dec/06 07:31 PM

Fixed on HEAD (and MOODLE_18_GROUPS).

All content on this web site is made available under the GNU General Public License, unless otherwise stated.