Moodle

Use simplepie instead of magpie for rss parsing

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.6, 1.7, 1.8
  • Fix Version/s: 2.0
  • Component/s: RSS
  • Labels:
    None
  • Affected Branches:
    MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

We use Magpie for rss parsing and download now - is is buggy and not maintained

There is a better LGPL alternative - see http://simplepie.org/

Issue Links

This issue has been marked as being related by:
MDL-13932 Rewrite RSS block Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Juan Segarra Montesinos added a comment -

> is is buggy and not maintained

In fact, google reader's shared item feed isn't parsed ok with magpie. I've tested it with simplepie and works great.

any plans to change this?

Show
Juan Segarra Montesinos added a comment - > is is buggy and not maintained In fact, google reader's shared item feed isn't parsed ok with magpie. I've tested it with simplepie and works great. any plans to change this?
Hide
Permalink
Charles Fulton added a comment -

Includes a patch file for the rss_client block and a wrapper for SimplePie. Patched against 1.9.2

Show
Charles Fulton added a comment - Includes a patch file for the rss_client block and a wrapper for SimplePie. Patched against 1.9.2
Hide
Permalink
Charles Fulton added a comment -

We've cooked up a patch for 1.9.2 that uses the SimplePie library. There's still an issue with iTunesU streams, but that might be better handled in its own block.

Show
Charles Fulton added a comment - We've cooked up a patch for 1.9.2 that uses the SimplePie library. There's still an issue with iTunesU streams, but that might be better handled in its own block.
Hide
Permalink
Kenneth Newquist added a comment -

+1 on swapping out Magpie for SimplePie RSS. We've run into a number of RSS parsing issues with Magpie. Those issues aren't likely to go away anytime soon, as Magpie was last updated in 2005.

SimplePie RSS on the other hand was last updated in December 2008. We've been using SimplePie instead of Magpie since this patch was rolled in July without problems.

Show
Kenneth Newquist added a comment - +1 on swapping out Magpie for SimplePie RSS. We've run into a number of RSS parsing issues with Magpie. Those issues aren't likely to go away anytime soon, as Magpie was last updated in 2005. SimplePie RSS on the other hand was last updated in December 2008. We've been using SimplePie instead of Magpie since this patch was rolled in July without problems.
Hide
Permalink
Kenneth Newquist added a comment -

FYI – this remains an issue with Moodle 1.9.4, so the ticket should be updated accordingly. The patch still works just fine with that version.

Show
Kenneth Newquist added a comment - FYI – this remains an issue with Moodle 1.9.4, so the ticket should be updated accordingly. The patch still works just fine with that version.
Hide
Permalink
Mark Pearson added a comment -

Could not this Simplepie patch be rolled into 1.9.6? Certainly it should be used in 2.0 I would have thought.

Show
Mark Pearson added a comment - Could not this Simplepie patch be rolled into 1.9.6? Certainly it should be used in 2.0 I would have thought.
Hide
Permalink
Dan Poltawski added a comment -

I have now made the switch to simplepie in the rss_feed block and removed magpie.

There are also unit tests for simplepie - see: lib/simpletest/testrss.php

Show
Dan Poltawski added a comment - I have now made the switch to simplepie in the rss_feed block and removed magpie. There are also unit tests for simplepie - see: lib/simpletest/testrss.php

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.