Issue Details (XML | Word | Printable)

Key: MDL-7946
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Dan Poltawski
Reporter: Petr Skoda
Votes: 18
Watchers: 8
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Use simplepie instead of magpie for rss parsing

Created: 17/Dec/06 11:00 PM   Updated: 30/Jul/09 10:52 PM
Return to search
Component/s: RSS
Affects Version/s: 1.6, 1.7, 1.8
Fix Version/s: 2.0

File Attachments: 1. Zip Archive simplerss.zip (2 kB)

Issue Links:
Relates
 

Participants: Charles Fulton, Dan Poltawski, Juan Segarra Montesinos, Kenneth Newquist, Mark Pearson and Petr Skoda
Security Level: None
Resolved date: 30/Jul/09
Affected Branches: MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE
Fixed Branches: MOODLE_20_STABLE

Sub-Tasks  All   Open   
 Sub-Task Progress: 

 Description  « Hide
We use Magpie for rss parsing and download now - is is buggy and not maintained :-(

There is a better LGPL alternative - see http://simplepie.org/


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Juan Segarra Montesinos added a comment - 11/Mar/08 01:41 AM
> is is buggy and not maintained

In fact, google reader's shared item feed isn't parsed ok with magpie. I've tested it with simplepie and works great.

any plans to change this?


Charles Fulton added a comment - 18/Jul/08 12:07 AM
Includes a patch file for the rss_client block and a wrapper for SimplePie. Patched against 1.9.2

Charles Fulton added a comment - 18/Jul/08 12:09 AM
We've cooked up a patch for 1.9.2 that uses the SimplePie library. There's still an issue with iTunesU streams, but that might be better handled in its own block.

Kenneth Newquist added a comment - 25/Feb/09 06:49 PM
+1 on swapping out Magpie for SimplePie RSS. We've run into a number of RSS parsing issues with Magpie. Those issues aren't likely to go away anytime soon, as Magpie was last updated in 2005.

SimplePie RSS on the other hand was last updated in December 2008. We've been using SimplePie instead of Magpie since this patch was rolled in July without problems.


Kenneth Newquist added a comment - 25/Feb/09 06:50 PM
FYI – this remains an issue with Moodle 1.9.4, so the ticket should be updated accordingly. The patch still works just fine with that version.

Mark Pearson added a comment - 16/Jul/09 10:20 PM
Could not this Simplepie patch be rolled into 1.9.6? Certainly it should be used in 2.0 I would have thought.

Dan Poltawski added a comment - 30/Jul/09 10:52 PM
I have now made the switch to simplepie in the rss_feed block and removed magpie.

There are also unit tests for simplepie - see: lib/simpletest/testrss.php