Moodle

Language strings and different versions

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Duplicate
  • Affects Version/s: 1.6.3
  • Fix Version/s: None
  • Component/s: General, Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_16_STABLE

Description

There are some ongoing problems with update of language strings. In 1.7 are some strings in lang/en_utf8 deleted. They are part of the lang/en_utf8 package in 1.6.x. We are creating new language strings in 1.7 systems and old strings are automatically deleted.
After an update of the language files in 1.6.x in all other languages there are several strings missing, because they are deleted during actual translations.

It seems that some of the strings are not used in 1.6.x systems. So they should be deleted in the 1.6.x systems in lang/en_utf8 folder. Others can'tbe deleted.

Here are the problem strings:

moodle.php
$string['statsreport6'] = "All teacher activity (views and posts)";
$string['statsreportstudentactivity'] = "All student activity (views and posts)";
$string['statsreportteacheractivity'] = "All teacher activity (views and posts)";

assignment.php
$string['allowmultiple'] = "Allow multiple files";
$string['attachfile'] = "Attach file";
$string['attachfiletoassignment'] = "Attach file(s) to assignment";
$string['backtoassignment'] = "Back to Assignment";
$string['backtofeedback'] = "Back to Feedback";
$string['choosereviewfile'] = "Choose a file to upload as an assignment review:";
$string['deletecheckfile'] = "Are you absolutely sure you want to delete this file?";
$string['deleteednotification'] = "File has been deleted.";
$string['deletefail'] = "The following file has not been deleted:";
$string['markingsubmitnotification'] = "File has been submitted for marking successfully.";
$string['namedeletefile'] = "You about to delete this file:";
$string['nofilesforsubmit'] = "No file was found for submitting - are you sure you uploaded any?";
$string['removelink'] = "Remove";
$string['responsefile'] = "Response File:";
$string['responsesfromteacher'] = "Responses Uploaded by the Teacher";
$string['step1'] = "Step 1: ";
$string['step2'] = "Step 2: ";
$string['submissionstatus'] = "Submission status:";
$string['submissionstatusblank'] = "Blank";
$string['submissionstatusdraft'] = "Draft";
$string['submissionstatusmarked'] = "Marked";
$string['submissionstatusreturned'] = "Returned";
$string['submissionstatussubmitted'] = "Submitted";
$string['uploadsuccessresponse'] = "Response file uploaded successfully.";

blog.php 1 String

hotpot.php 2 Strings

lesson.php 7 Strings

And there is an ongoing problem with currencies.php. There are some old currencies in the en_utf8 file that should be deleted. Nobody can pay in old 'historic' currencies.

Issue Links

Activity

Hide
Petr Škoda (skodak) added a comment -

Yes, there are some strings in 1.6 that are coming from 1.5 or 1.7dev that are not used in any version - those are usually removed in some newer versions, but were kept in 1.6.x so that it gets tested in HEAD and nothing breaks in old stable versions.

It should not be a major problem for translators because they should be working in latest stable or development version.
I agree that it might be a bit confusing that the latest language packs when used in 1.6.x show untranslated strings, but it is not a major problem IMHO.

I am proposing not fixing this in 1.6.x

Show
Petr Škoda (skodak) added a comment - Yes, there are some strings in 1.6 that are coming from 1.5 or 1.7dev that are not used in any version - those are usually removed in some newer versions, but were kept in 1.6.x so that it gets tested in HEAD and nothing breaks in old stable versions. It should not be a major problem for translators because they should be working in latest stable or development version. I agree that it might be a bit confusing that the latest language packs when used in 1.6.x show untranslated strings, but it is not a major problem IMHO. I am proposing not fixing this in 1.6.x
Hide
Petr Škoda (skodak) added a comment -

...the currencies and not much useful because the course cost option is broken see MDL-7568, but I have fixed it in 1.6.x anyway...

Show
Petr Škoda (skodak) added a comment - ...the currencies and not much useful because the course cost option is broken see MDL-7568, but I have fixed it in 1.6.x anyway...
Hide
Nicolas Martignoni added a comment -

Closing as dupe.

Show
Nicolas Martignoni added a comment - Closing as dupe.

People

Dates

  • Created:
    Updated:
    Resolved: