[#MDL-8050] 1.2 Remove all target="_top"

Issue Details (XML | Word | Printable)

Key:	MDL-8050
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Martin Dougiamas
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-7860

1.2 Remove all target="_top"

Created: 03/Jan/07 05:29 PM Updated: 24/Sep/09 09:58 AM

Return to search

Component/s:

Accessibility

Affects Version/s:

1.8

Fix Version/s:

1.8

Issue Links:

Dependency

This issue will help resolve:

~~MDL-7861~~ Strict XHTML 1.0

Relates

This issue has been marked as being related by:

~~MDL-20327~~ Links in framed resource header don't load in _top if javascript is disabled.

Participants:	Martin Dougiamas and Petr Skoda
Security Level:	None
Resolved date:	05/Jan/07
Affected Branches:	MOODLE_18_STABLE
Fixed Branches:	MOODLE_18_STABLE

Description

« Hide

When the $CFG->framename is _top or blank, then don't print target="_top" in links

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Petr Skoda added a comment - 04/Jan/07 03:24 AM

fixed in cvs...

Petr Skoda made changes - 04/Jan/07 03:24 AM

Field	Original Value	New Value
Assignee	Martin Dougiamas [ dougiamas ]	Petr ?koda [ skodak ]
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Petr Skoda committed 23 files to 'Moodle CVS' - 04/Jan/07 04:24 AM

~~MDL-8050~~ 1.2 Remove all target="_top"

MODIFY	lib/weblib.php	Rev. 1.731	(+110 -24 lines)
MODIFY	mod/quiz/Attic/pagelib.php	Rev. 1.10	(+8 -2 lines)
MODIFY	mod/forum/lib.php	Rev. 1.519	(+9 -2 lines)
MODIFY	admin/enrol.php	Rev. 1.25	(+8 -2 lines)
MODIFY	filter/activitynames/filter.php	Rev. 1.18	(+8 -2 lines)
MODIFY	mod/resource/lib.php	Rev. 1.59	(+10 -4 lines)
MODIFY	admin/auth.php	Rev. 1.44	(+8 -3 lines)
MODIFY	mod/resource/Attic/filter.php	Rev. 1.16	(+8 -2 lines)
MODIFY	admin/Attic/pagelib.php	Rev. 1.13	(+8 -2 lines)
MODIFY	admin/enrol_config.php	Rev. 1.9	(+8 -2 lines)
MODIFY	admin/lang.php	Rev. 1.76	(+11 -5 lines)
MODIFY	calendar/lib.php	Rev. 1.159	(+8 -2 lines)
MODIFY	mod/resource/type/ims/Attic/deploy.php	Rev. 1.18	(+9 -4 lines)
MODIFY	mod/resource/type/file/Attic/resource.class.php	Rev. 1.42	(+7 -2 lines)
MODIFY	mod/lesson/locallib.php	Rev. 1.57	(+9 -3 lines)
MODIFY	mod/chat/Attic/pagelib.php	Rev. 1.8	(+7 -2 lines)
MODIFY	mod/data/filter.php	Rev. 1.10	(+7 -3 lines)
MODIFY	theme/chameleon/footer.html	Rev. 1.6	(+8 -2 lines)
MODIFY	blog/Attic/blogpage.php	Rev. 1.10	(+9 -2 lines)
MODIFY	mod/assignment/lib.php	Rev. 1.204	(+17 -5 lines)
MODIFY	mod/data/Attic/pagelib.php	Rev. 1.7	(+8 -2 lines)
MODIFY	admin/dbperformance.php	Rev. 1.7	(+8 -2 lines)
MODIFY	mod/resource/type/repository/Attic/resource.class.php	Rev. 1.7	(+8 -3 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 04/Jan/07 05:06 AM

~~MDL-8050~~ 1.2 Remove all target="_top" - fixed typo

MODIFY

lib/weblib.php

Rev. 1.732

(+3 -3 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 04/Jan/07 09:05 AM

search&replace <a href="xxx" $CFG->frametarget>

Petr Skoda made changes - 04/Jan/07 09:05 AM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

Martin Dougiamas made changes - 04/Jan/07 12:48 PM

Link

This issue will help resolve ~~MDL-7861~~ [ ~~MDL-7861~~ ]

moodler committed 2 files to 'Moodle CVS' - 04/Jan/07 01:57 PM

Added CFG->frametarget (defined by frametarget()) ~~MDL-8050~~

MODIFY	lib/setup.php		Rev. 1.192		(+4 -1 lines)
MODIFY	lib/weblib.php		Rev. 1.736		(+16 -2 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 05/Jan/07 02:23 AM

fixed in cvs, reclosing

Petr Skoda made changes - 05/Jan/07 02:23 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Petr Skoda committed 33 files to 'Moodle CVS' - 05/Jan/07 03:23 AM

~~MDL-8050~~ 1.2 Remove all target="_top" - refactoring of previous commit

MODIFY	mod/hotpot/view.php	Rev. 1.24	(+3 -4 lines)
MODIFY	admin/auth_config.php	Rev. 1.2	(+1 -6 lines)
MODIFY	mod/workshop/Attic/submissions.php	Rev. 1.52	(+2 -2 lines)
MODIFY	mod/hotpot/index.php	Rev. 1.17	(+2 -2 lines)
MODIFY	mod/data/filter.php	Rev. 1.11	(+2 -7 lines)
MODIFY	mod/lesson/locallib.php	Rev. 1.59	(+3 -9 lines)
MODIFY	mod/quiz/Attic/pagelib.php	Rev. 1.11	(+2 -8 lines)
MODIFY	mod/resource/type/repository/Attic/resource.class.php	Rev. 1.9	(+2 -7 lines)
MODIFY	mod/resource/lib.php	Rev. 1.60	(+4 -10 lines)
MODIFY	mod/forum/lib.php	Rev. 1.522	(+2 -8 lines)
MODIFY	admin/enrol_config.php	Rev. 1.10	(+2 -8 lines)
MODIFY	admin/Attic/pagelib.php	Rev. 1.14	(+2 -8 lines)
MODIFY	filter/activitynames/filter.php	Rev. 1.19	(+2 -8 lines)
MODIFY	calendar/lib.php	Rev. 1.162	(+2 -8 lines)
MODIFY	admin/auth.php	Rev. 1.46	(+1 -6 lines)
MODIFY	mod/workshop/Attic/view.php	Rev. 1.55	(+2 -2 lines)
MODIFY	mod/chat/Attic/pagelib.php	Rev. 1.9	(+2 -7 lines)
MODIFY	mod/scorm/player.php	Rev. 1.22	(+6 -6 lines)
MODIFY	mod/assignment/lib.php	Rev. 1.205	(+5 -17 lines)
MODIFY	mod/hotpot/lib.php	Rev. 1.61	(+2 -2 lines)
MODIFY	mod/resource/type/ims/Attic/deploy.php	Rev. 1.19	(+4 -9 lines)
MODIFY	mod/resource/type/file/Attic/resource.class.php	Rev. 1.44	(+2 -7 lines)
MODIFY	mod/data/Attic/pagelib.php	Rev. 1.8	(+2 -8 lines)
MODIFY	theme/chameleon/footer.html	Rev. 1.7	(+1 -6 lines)
MODIFY	mod/workshop/Attic/assess.php	Rev. 1.13	(+2 -2 lines)
MODIFY	admin/enrol.php	Rev. 1.26	(+2 -8 lines)
MODIFY	admin/dbperformance.php	Rev. 1.8	(+2 -8 lines)
MODIFY	blog/Attic/blogpage.php	Rev. 1.11	(+2 -8 lines)
MODIFY	mod/resource/Attic/filter.php	Rev. 1.17	(+2 -8 lines)
MODIFY	mod/scorm/view.php	Rev. 1.49	(+6 -6 lines)
MODIFY	lib/weblib.php	Rev. 1.743	(+25 -103 lines)
MODIFY	mod/scorm/locallib.php	Rev. 1.23	(+2 -2 lines)
MODIFY	admin/lang.php	Rev. 1.77	(+4 -10 lines)

Sam Hemelryk made changes - 24/Sep/09 09:58 AM

Link

This issue has been marked as being related by ~~MDL-20327~~ [ ~~MDL-20327~~ ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.