Moodle

1.3 Remove name attribute from <form> and fix focus everywhere

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.8
  • Component/s: Accessibility
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

XHTML Strict does not allow name attribute on forms, but we are using them for focus selection.

Solution:

  • remove the name (or replace it with id)
  • use id of element for focus - needs fixing JS focus code and all places that use it

Issue Links

Activity

Hide
Petr Škoda (skodak) added a comment -

hmm, we could add compatibility hack to use old style focusing code if focus contains dot

Show
Petr Škoda (skodak) added a comment - hmm, we could add compatibility hack to use old style focusing code if focus contains dot
Hide
Petr Škoda (skodak) added a comment -

I have tweaked the focusing javascipt code used from print_header() and modified a few forms (login, jsless messaging and chat).

Show
Petr Škoda (skodak) added a comment - I have tweaked the focusing javascipt code used from print_header() and modified a few forms (login, jsless messaging and chat).
Hide
Petr Škoda (skodak) added a comment -

fixed in cvs

Show
Petr Škoda (skodak) added a comment - fixed in cvs

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: