Issue Details (XML | Word | Printable)

Key: MDL-8062
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-7860

1.3 Remove name attribute from <form> and fix focus everywhere

Created: 04/Jan/07 03:42 AM   Updated: 07/Jan/07 04:19 AM
Return to search
Component/s: Accessibility
Affects Version/s: 1.7
Fix Version/s: 1.8

Issue Links:
Dependency
 

Participants: Petr Skoda
Security Level: None
Resolved date: 07/Jan/07
Affected Branches: MOODLE_17_STABLE
Fixed Branches: MOODLE_18_STABLE


 Description  « Hide
XHTML Strict does not allow name attribute on forms, but we are using them for focus selection.

Solution:
* remove the name (or replace it with id)
* use id of element for focus - needs fixing JS focus code and all places that use it

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Petr Skoda added a comment - 04/Jan/07 03:43 AM
hmm, we could add compatibility hack to use old style focusing code if focus contains dot

[ Permalink | « Hide ]
Petr Skoda added a comment - 04/Jan/07 04:42 AM
I have tweaked the focusing javascipt code used from print_header() and modified a few forms (login, jsless messaging and chat).

Petr Skoda committed 5 files to 'Moodle CVS' - 04/Jan/07 05:35 AM
MDL-8062 chat, login page and messaging - removed name attribute from some <form>s and fixed focus; changed set_focus() JS to accept element ID == the $focus parameter in print_header() + other minor Strict XHTML fixes
MODIFY login/index_form.html   Rev. 1.39    (+12 -8 lines)
MODIFY mod/chat/gui_basic/index.php   Rev. 1.3    (+7 -7 lines)
MODIFY login/index.php   Rev. 1.101    (+3 -3 lines)
MODIFY lib/Attic/javascript.php   Rev. 1.32    (+7 -5 lines)
MODIFY message/discussion.php   Rev. 1.13    (+8 -14 lines)
Martin Dougiamas made changes - 04/Jan/07 12:47 PM
Field Original Value New Value
Summary Remove name attribute from <form> and fix focus everywhere 1.3 Remove name attribute from <form> and fix focus everywhere
Martin Dougiamas made changes - 04/Jan/07 12:48 PM
Link This issue will help resolve MDL-7861 [ MDL-7861 ]
Martin Dougiamas made changes - 04/Jan/07 11:24 PM
Assignee Martin Dougiamas [ dougiamas ] Petr ?koda [ skodak ]
Petr Skoda committed 120 files to 'Moodle CVS' - 05/Jan/07 06:32 AM
MDL-8062 1.3 Remove name attribute from <form> and fix focus everywhere - more changes ahead
MODIFY files/index.php   Rev. 1.107    (+6 -6 lines)
MODIFY admin/langimport.php   Rev. 1.26    (+4 -4 lines)
MODIFY admin/xmldb/actions/edit_key/edit_key.class.php   Rev. 1.4    (+2 -2 lines)
MODIFY mod/glossary/editcategories.php   Rev. 1.31    (+3 -3 lines)
MODIFY blocks/login/block_login.php   Rev. 1.18    (+2 -2 lines)
MODIFY mod/scorm/locallib.php   Rev. 1.24    (+3 -3 lines)
MODIFY mod/lesson/action/addbranchtable.php   Rev. 1.12    (+3 -3 lines)
MODIFY user/index.php   Rev. 1.159    (+2 -2 lines)
MODIFY enrol/mnet/Attic/remote_enrolment.html   Rev. 1.2    (+13 -13 lines)
MODIFY mod/lesson/action/continue.html   Rev. 1.11    (+4 -4 lines)
MODIFY mod/wiki/Attic/mod.html   Rev. 1.21    (+1 -1 lines)
MODIFY mod/workshop/Attic/view.php   Rev. 1.56    (+2 -2 lines)
MODIFY mod/survey/view.php   Rev. 1.41    (+2 -2 lines)
MODIFY mod/lesson/action/addpage.php   Rev. 1.17    (+3 -3 lines)
MODIFY mod/journal/Attic/edit.html   Rev. 1.17    (+1 -1 lines)
MODIFY course/search.php   Rev. 1.30    (+3 -3 lines)
MODIFY admin/mnet/access_control.php   Rev. 1.3    (+1 -1 lines)
MODIFY calendar/Attic/event_delete.html   Rev. 1.6    (+3 -3 lines)
MODIFY backup/restore_form.html   Rev. 1.42    (+2 -2 lines)
MODIFY mod/lesson/essay.php   Rev. 1.6    (+3 -3 lines)
MODIFY lib/rsslib.php   Rev. 1.44    (+3 -3 lines)
MODIFY admin/auth_config.php   Rev. 1.3    (+13 -9 lines)
MODIFY course/report/participation/index.php   Rev. 1.15    (+2 -2 lines)
MODIFY mod/lesson/action/editpage.php   Rev. 1.20    (+7 -7 lines)
MODIFY admin/register.php   Rev. 1.20    (+2 -2 lines)
MODIFY grade/Attic/exceptions.html   Rev. 1.8    (+11 -11 lines)
MODIFY mod/scorm/Attic/config.html   Rev. 1.16    (+1 -1 lines)
MODIFY admin/search.php   Rev. 1.12    (+2 -2 lines)
MODIFY mod/workshop/Attic/locallib.php   Rev. 1.39    (+2 -2 lines)
MODIFY mod/glossary/import.html   Rev. 1.11    (+1 -1 lines)
MODIFY mod/workshop/Attic/assessments.php   Rev. 1.55    (+2 -2 lines)
MODIFY search/query.php   Rev. 1.12    (+1 -1 lines)
MODIFY mod/glossary/Attic/config.html   Rev. 1.21    (+1 -1 lines)
MODIFY mod/workshop/Attic/submissions.php   Rev. 1.53    (+2 -2 lines)
MODIFY calendar/Attic/event_new.html   Rev. 1.11    (+1 -1 lines)
MODIFY mod/data/preset.php   Rev. 1.18    (+3 -3 lines)
MODIFY admin/xmldb/actions/edit_index/edit_index.class.php   Rev. 1.4    (+2 -2 lines)
MODIFY course/lib.php   Rev. 1.469    (+4 -4 lines)
MODIFY admin/roles/manage.php   Rev. 1.40    (+3 -3 lines)
MODIFY mod/quiz/editlib.php   Rev. 1.40    (+5 -5 lines)
MODIFY admin/enrol_config.php   Rev. 1.11    (+2 -11 lines)
MODIFY admin/upgradesettings.php   Rev. 1.17    (+2 -2 lines)
MODIFY lib/speller/Attic/controls.html   Rev. 1.3    (+2 -2 lines)
MODIFY mod/hotpot/lib.php   Rev. 1.62    (+2 -2 lines)
MODIFY admin/lang.php   Rev. 1.78    (+2 -2 lines)
MODIFY course/importstudents.php   Rev. 1.22    (+2 -2 lines)
MODIFY mod/wiki/view.php   Rev. 1.62    (+3 -3 lines)
MODIFY mod/quiz/Attic/jstimer.php   Rev. 1.12    (+2 -2 lines)
MODIFY mod/forum/subscriber.html   Rev. 1.4    (+13 -13 lines)
MODIFY error/index.php   Rev. 1.16    (+4 -4 lines)
MODIFY mod/glossary/view.php   Rev. 1.110    (+2 -2 lines)
MODIFY admin/roles/Attic/manage.html   Rev. 1.30    (+2 -2 lines)
MODIFY mod/glossary/formats.php   Rev. 1.18    (+2 -2 lines)
MODIFY calendar/Attic/event_edit.html   Rev. 1.12    (+1 -1 lines)
MODIFY blog/Attic/preferences.html   Rev. 1.10    (+1 -1 lines)
MODIFY course/reset.php   Rev. 1.4    (+2 -2 lines)
MODIFY admin/enrol.php   Rev. 1.27    (+2 -2 lines)
MODIFY mod/data/field.php   Rev. 1.22    (+2 -2 lines)
MODIFY course/Attic/groups-edit.html   Rev. 1.20    (+4 -4 lines)
MODIFY mod/assignment/lib.php   Rev. 1.206    (+4 -4 lines)
MODIFY mod/lesson/report.php   Rev. 1.34    (+3 -3 lines)
MODIFY mod/chat/gui_header_js/chatinput.php   Rev. 1.17    (+6 -6 lines)
MODIFY sso/hive/expired.php   Rev. 1.5    (+2 -2 lines)
MODIFY mod/assignment/Attic/config.html   Rev. 1.10    (+1 -1 lines)
MODIFY admin/xmldb/actions/edit_sentence/edit_sentence.class.php   Rev. 1.4    (+2 -2 lines)
MODIFY mod/workshop/Attic/mod.html   Rev. 1.29    (+1 -1 lines)
MODIFY mod/chat/Attic/config.html   Rev. 1.11    (+1 -1 lines)
MODIFY mod/lesson/highscores.php   Rev. 1.4    (+3 -3 lines)
MODIFY mod/survey/Attic/mod.html   Rev. 1.20    (+1 -1 lines)
MODIFY mod/quiz/report/overview/report.php   Rev. 1.74    (+2 -2 lines)
MODIFY course/importstudents.html   Rev. 1.10    (+13 -13 lines)
MODIFY mod/forum/lib.php   Rev. 1.523    (+3 -3 lines)
MODIFY course/category.php   Rev. 1.88    (+4 -4 lines)
MODIFY mod/quiz/attempt.php   Rev. 1.102    (+6 -6 lines)
MODIFY user/Attic/edit.html   Rev. 1.102    (+1 -1 lines)
MODIFY mod/assignment/type/Attic/common.html   Rev. 1.5    (+1 -1 lines)
MODIFY course/scales.php   Rev. 1.29    (+2 -2 lines)
MODIFY mod/lams/Attic/config.html   Rev. 1.3    (+1 -1 lines)
MODIFY message/settings.html   Rev. 1.9    (+1 -1 lines)
MODIFY enrol/mnet/allowed_courses.php   Rev. 1.2    (+13 -13 lines)
MODIFY admin/roles/Attic/override.html   Rev. 1.18    (+1 -1 lines)
MODIFY admin/roles/Attic/assign.html   Rev. 1.21    (+13 -13 lines)
MODIFY course/Attic/mod_delete.html   Rev. 1.8    (+1 -1 lines)
MODIFY admin/auth.php   Rev. 1.47    (+1 -1 lines)
MODIFY mod/wiki/lib.php   Rev. 1.44    (+2 -2 lines)
MODIFY blocks/loancalc/block_loancalc.php   Rev. 1.7    (+2 -2 lines)
MODIFY mod/data/lib.php   Rev. 1.108    (+4 -4 lines)
MODIFY mod/data/Attic/config.html   Rev. 1.4    (+1 -1 lines)
MODIFY mod/workshop/Attic/assessment_grading_form.html   Rev. 1.3    (+1 -1 lines)
MODIFY course/Attic/editsection.html   Rev. 1.13    (+1 -1 lines)
MODIFY admin/Attic/langdoc.php   Rev. 1.19    (+3 -3 lines)
MODIFY course/Attic/pending-reject.html   Rev. 1.3    (+1 -1 lines)
MODIFY mod/survey/report.php   Rev. 1.45    (+2 -2 lines)
MODIFY admin/settings.php   Rev. 1.33    (+2 -2 lines)
MODIFY mod/quiz/report/analysis/Attic/report.php   Rev. 1.29    (+2 -2 lines)
MODIFY mod/hotpot/report/overview/report.php   Rev. 1.9    (+5 -5 lines)
MODIFY backup/backup_form.html   Rev. 1.28    (+2 -2 lines)
MODIFY user/extendenrol.php   Rev. 1.9    (+2 -2 lines)
MODIFY user/message.html   Rev. 1.6    (+1 -1 lines)
MODIFY auth/cas/Attic/index_form.html   Rev. 1.6    (+7 -7 lines)
MODIFY mod/glossary/editcategories.html   Rev. 1.14    (+2 -2 lines)
MODIFY admin/xmldb/actions/edit_field/edit_field.class.php   Rev. 1.4    (+2 -2 lines)
MODIFY grade/lib.php   Rev. 1.62    (+7 -7 lines)
MODIFY mod/hotpot/view.php   Rev. 1.25    (+2 -2 lines)
MODIFY calendar/preferences.html   Rev. 1.9    (+1 -1 lines)
MODIFY mod/lesson/view.php   Rev. 1.120    (+6 -6 lines)
MODIFY mod/forum/prune.html   Rev. 1.8    (+1 -1 lines)
MODIFY enrol/manual/enrol.html   Rev. 1.6    (+2 -2 lines)
MODIFY mod/data/templates.php   Rev. 1.58    (+3 -3 lines)
MODIFY mod/wiki/admin.php   Rev. 1.24    (+3 -3 lines)
MODIFY mod/forum/Attic/config.html   Rev. 1.13    (+1 -1 lines)
MODIFY blocks/search/block_search.php   Rev. 1.6    (+1 -1 lines)
MODIFY backup/backup_check.html   Rev. 1.32    (+2 -2 lines)
MODIFY mod/lesson/importppt.php   Rev. 1.17    (+3 -3 lines)
MODIFY mod/choice/view.php   Rev. 1.92    (+2 -2 lines)
MODIFY course/index.php   Rev. 1.62    (+2 -2 lines)
MODIFY message/search.html   Rev. 1.13    (+1 -1 lines)
MODIFY user/edit.php   Rev. 1.134    (+2 -2 lines)
MODIFY message/send.php   Rev. 1.18    (+2 -2 lines)
MODIFY mod/hotpot/Attic/config.html   Rev. 1.5    (+1 -1 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 07/Jan/07 04:19 AM
fixed in cvs

Petr Skoda made changes - 07/Jan/07 04:19 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Petr Skoda committed 38 files to 'Moodle CVS' - 07/Jan/07 04:22 AM
MDL-8062 Remove name attribute from <form> and related javascript code cleanup (tested with FF, IE, Konq and Opera)
MODIFY question/type/rqp/Attic/editquestion.html   Rev. 1.2    (+1 -1 lines)
MODIFY lib/editor/htmlarea/Attic/coursefiles.php   Rev. 1.9    (+3 -3 lines)
MODIFY files/index.php   Rev. 1.108    (+2 -2 lines)
MODIFY mod/exercise/Attic/view.php   Rev. 1.31    (+2 -2 lines)
MODIFY mod/resource/type/file/Attic/localfile.php   Rev. 1.3    (+3 -3 lines)
MODIFY mod/survey/view.php   Rev. 1.42    (+3 -3 lines)
MODIFY lib/editor/htmlarea/popups/Attic/insert_image.php   Rev. 1.8    (+8 -8 lines)
MODIFY mod/forum/search.php   Rev. 1.71    (+6 -6 lines)
MODIFY mod/exercise/Attic/assessments.php   Rev. 1.35    (+3 -3 lines)
MODIFY mod/workshop/Attic/submissions.php   Rev. 1.54    (+4 -4 lines)
MODIFY mod/exercise/Attic/locallib.php   Rev. 1.26    (+7 -7 lines)
MODIFY mod/resource/type/repository/hive/Attic/openhive.php   Rev. 1.5    (+3 -3 lines)
MODIFY lib/editor/htmlarea/popups/Attic/link.php   Rev. 1.5    (+7 -7 lines)
MODIFY question/type/calculated/questiontype.php   Rev. 1.5    (+2 -2 lines)
MODIFY mod/lesson/action/continue.html   Rev. 1.12    (+3 -3 lines)
MODIFY mod/workshop/Attic/locallib.php   Rev. 1.40    (+23 -23 lines)
MODIFY install.php   Rev. 1.56    (+5 -5 lines)
MODIFY question/type/random/Attic/editquestion.html   Rev. 1.3    (+1 -1 lines)
MODIFY question/import.php   Rev. 1.27    (+3 -3 lines)
MODIFY question/type/Attic/editquestionstart.html   Rev. 1.3    (+1 -1 lines)
MODIFY question/type/datasetdependent/Attic/questiondatasets.html   Rev. 1.2    (+1 -1 lines)
MODIFY mod/assignment/lib.php   Rev. 1.209    (+8 -8 lines)
MODIFY mod/scorm/Attic/mod.html   Rev. 1.46    (+4 -4 lines)
MODIFY mod/resource/Attic/config.html   Rev. 1.15    (+1 -1 lines)
MODIFY question/type/datasetdependent/Attic/datasetitems.php   Rev. 1.6    (+2 -2 lines)
MODIFY mod/workshop/Attic/assessments.php   Rev. 1.56    (+3 -3 lines)
MODIFY mod/resource/type/file/Attic/localpath.php   Rev. 1.3    (+5 -5 lines)
MODIFY mod/assignment/Attic/mod.html   Rev. 1.44    (+1 -1 lines)
MODIFY mod/quiz/Attic/config.html   Rev. 1.27    (+2 -2 lines)
MODIFY mod/exercise/Attic/submissions.php   Rev. 1.24    (+2 -2 lines)
MODIFY mod/lams/Attic/mod.html   Rev. 1.6    (+2 -2 lines)
MODIFY lib/javascript-static.js   Rev. 1.23    (+29 -19 lines)
MODIFY lib/editor/htmlarea/popups/Attic/createanchor.php   Rev. 1.4    (+2 -2 lines)
MODIFY question/type/calculated/Attic/editquestion.html   Rev. 1.4    (+3 -3 lines)
MODIFY mod/lesson/view.php   Rev. 1.121    (+3 -3 lines)
MODIFY question/editlib.php   Rev. 1.38    (+5 -5 lines)
MODIFY mod/hotpot/Attic/mod.html   Rev. 1.11    (+2 -2 lines)
MODIFY mod/resource/type/Attic/common.html   Rev. 1.10    (+1 -1 lines)
gbateson committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 28/Feb/07 12:26 PM
replace document.form with document.forms[form], because <form> now uses an "id" instead of a "name" attribute. (see MDL-8062)
MODIFY mod/hotpot/Attic/mod.html   Rev. 1.12.2.1    (+19 -15 lines)
gbateson committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 28/Feb/07 01:41 PM
cogmitting merged changes for lib.php (MDL-8675) and mod.html(MDL-8062)
MODIFY mod/hotpot/Attic/mod.html   Rev. 1.12.2.2    (+15 -19 lines)
MODIFY mod/hotpot/lib.php   Rev. 1.66.2.3    (+2 -2 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators