[#MDL-8069] Hunt down and convert all hardcoded English strings in the source to use lang pack

Issue Details (XML | Word | Printable)

Key:	MDL-8069
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Blocker
Assignee:	Donal McMullan
Reporter:	Donal McMullan
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-8068

Hunt down and convert all hardcoded English strings in the source to use lang pack

Created: 04/Jan/07 02:19 PM Updated: 12/Jan/07 04:00 AM

Return to search

Component/s:

Networking

Affects Version/s:

1.8

Fix Version/s:

1.8

Issue Links:

Relates

This issue has been marked as being related by:

~~MDL-8151~~ Typo in new string $string['auth_ldap_exprireattr_key'] = 'Expiration attribute';

Participants:	Donal McMullan and Martin Dougiamas
Security Level:	None
Resolved date:	11/Jan/07
Affected Branches:	MOODLE_18_STABLE
Fixed Branches:	MOODLE_18_STABLE

Description

« Hide

Hunt down and convert all hardcoded English strings in the source to use lang pack, otherwise people can't translate them.

All

Comments

Change History

Version Control

Sort Order:

Martin Dougiamas made changes - 04/Jan/07 02:20 PM

Field	Original Value	New Value
Assignee	Martin Dougiamas [ dougiamas ]	Donal McMullan [ donal@catalyst.net.nz ]

donal72 committed 14 files to 'Moodle CVS' - 05/Jan/07 02:58 PM

mnet: Removed hardcoded English strings from some MNET files: ~~MDL-8069~~

MODIFY	admin/mnet/trustedhosts.php	Rev. 1.3	(+1 -1 lines)
MODIFY	mnet/lib.php	Rev. 1.5	(+2 -2 lines)
DEL	admin/mnet/Attic/mnet_log.php	Rev. 1.2	(+0 -0 lines)
MODIFY	admin/mnet/mnet_services.html	Rev. 1.2	(+2 -2 lines)
MODIFY	admin/mnet/mnet_review.html	Rev. 1.3	(+2 -2 lines)
MODIFY	lang/en_utf8/auth.php	Rev. 1.11	(+4 -1 lines)
MODIFY	lang/en_utf8/mnet.php	Rev. 1.5	(+23 -0 lines)
MODIFY	admin/mnet/delete.html	Rev. 1.3	(+3 -3 lines)
MODIFY	admin/mnet/mnet_services.php	Rev. 1.3	(+1 -1 lines)
MODIFY	admin/mnet/delete.php	Rev. 1.2	(+4 -8 lines)
MODIFY	admin/mnet/access_control.php	Rev. 1.4	(+11 -11 lines)
MODIFY	admin/mnet/peers.php	Rev. 1.6	(+3 -3 lines)
MODIFY	admin/auth.php	Rev. 1.48	(+3 -3 lines)
MODIFY	admin/mnet/index.php	Rev. 1.7	(+5 -5 lines)

martignoni committed 1 file to 'Lang CVS' - 05/Jan/07 11:24 PM

mnet: Removed hardcoded English strings from some MNET files: ~~MDL-8069~~

MODIFY

fr_utf8/mnet.php

Rev. 1.6

(+22 -1 lines)

martignoni committed 1 file to 'Lang CVS' - 07/Jan/07 12:11 AM

mnet: Removed hardcoded English strings from some MNET files: ~~MDL-8069~~

MODIFY

fr_utf8/auth.php

Rev. 1.12

(+2 -0 lines)

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 09/Jan/07 07:44 PM

This is one is a pretty critical breach of the coding guidelines, I'm running into heaps of them.

Basically the mnet strings need to be in the language pack mnet.php and you use either get_string() for normal usage or errorcode() when it's an error.

Martin Dougiamas made changes - 09/Jan/07 07:44 PM

Priority

Minor [ 4 ]

Blocker [ 1 ]

donal72 committed 2 files to 'Moodle CVS' - 10/Jan/07 09:25 AM

Auth: Replace a hardcoded string: ~~MDL-8069~~

MODIFY	auth/pop3/auth.php		Rev. 1.2		(+2 -1 lines)
MODIFY	auth/nntp/auth.php		Rev. 1.2		(+2 -1 lines)

donal72 committed 1 file to 'Moodle CVS' - 10/Jan/07 09:32 AM

mnet: Replace a hardcoded string: ~~MDL-8069~~

MODIFY

enrol/mnet/Attic/remote_enrolment.php

Rev. 1.2

(+6 -6 lines)

donal72 committed 2 files to 'Moodle CVS' - 10/Jan/07 09:39 AM

mnet: Replace hardcoded strings: ~~MDL-8069~~

MODIFY	lang/en_utf8/mnet.php		Rev. 1.7		(+3 -0 lines)
MODIFY	lang/en_utf8/auth.php		Rev. 1.12		(+8 -1 lines)

Mitsuhiro Yoshida committed 1 file to 'Lang CVS' - 10/Jan/07 11:59 AM

Translated new strings for authentication ~~MDL-8069~~.

MODIFY

ja_utf8/auth.php

Rev. 1.18

(+5 -0 lines)

martignoni committed 2 files to 'Lang CVS' - 10/Jan/07 07:33 PM

mnet: Replace hardcoded strings: ~~MDL-8069~~

MODIFY	fr_utf8/auth.php		Rev. 1.13		(+5 -0 lines)
MODIFY	fr_utf8/mnet.php		Rev. 1.7		(+4 -2 lines)

donal72 committed 2 files to 'Moodle CVS' - 11/Jan/07 06:43 AM

Auth: Replace hardcoded strings: ~~MDL-8069~~

MODIFY	lang/en_utf8/auth.php		Rev. 1.13		(+3 -1 lines)
MODIFY	auth/mnet/config.html		Rev. 1.2		(+2 -2 lines)

Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 11/Jan/07 07:23 AM

Translated new strings for mnet auth config ~~MDL-8069~~.

MODIFY	ja_utf8/auth.php		Rev. 1.19		(+2 -0 lines)
MODIFY	ja_utf8/README		Rev. 1.294		(+1 -1 lines)

donal72 committed 5 files to 'Moodle CVS' - 11/Jan/07 08:15 AM

mnet: Replace hardcoded strings: ~~MDL-8069~~

MODIFY	admin/mnet/mnet_services.php	Rev. 1.4	(+1 -1 lines)
MODIFY	admin/mnet/delete.php	Rev. 1.3	(+2 -2 lines)
MODIFY	admin/mnet/trustedhosts.php	Rev. 1.5	(+1 -1 lines)
MODIFY	admin/mnet/peers.php	Rev. 1.8	(+2 -2 lines)
MODIFY	admin/mnet/index.php	Rev. 1.10	(+2 -2 lines)

donal72 committed 12 files to 'Moodle CVS' - 11/Jan/07 08:17 AM

Auth: Replace hardcoded strings: ~~MDL-8069~~

MODIFY	auth/cas/Attic/login.php	Rev. 1.11	(+4 -8 lines)
MODIFY	auth/fc/config.html	Rev. 1.9	(+6 -7 lines)
MODIFY	lang/en_utf8/auth.php	Rev. 1.14	(+66 -3 lines)
MODIFY	auth/db/config.html	Rev. 1.15	(+10 -10 lines)
MODIFY	auth/ldap/config.html	Rev. 1.30	(+21 -22 lines)
MODIFY	auth/fc/fcFPP.php	Rev. 1.6	(+1 -1 lines)
MODIFY	auth/cas/auth.php	Rev. 1.3	(+1 -1 lines)
MODIFY	auth/cas/Attic/forbidden.php	Rev. 1.5	(+2 -2 lines)
MODIFY	auth/db/auth.php	Rev. 1.3	(+15 -10 lines)
MODIFY	auth/email/auth.php	Rev. 1.3	(+2 -2 lines)
MODIFY	lang/en_utf8/moodle.php	Rev. 1.97	(+2 -1 lines)
MODIFY	auth/cas/config.html	Rev. 1.9	(+9 -9 lines)

donal72 committed 4 files to 'Moodle CVS' - 11/Jan/07 09:05 AM

Auth: Replace hardcoded strings: ~~MDL-8069~~

MODIFY	auth/ldap/config.html	Rev. 1.31	(+1 -3 lines)
MODIFY	auth/ldap/auth.php	Rev. 1.3	(+6 -6 lines)
MODIFY	auth/imap/config.html	Rev. 1.13	(+4 -4 lines)
MODIFY	lang/en_utf8/auth.php	Rev. 1.15	(+11 -1 lines)

[ Permalink | « Hide ]

Donal McMullan added a comment - 11/Jan/07 09:47 AM

I've hunted down and replaced all the hardcoded strings I can find in the MNet and Auth sections. Please reopen this if you encounter any escapees, and note the offending file and section.

Thanks

Donal

Donal McMullan made changes - 11/Jan/07 09:47 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

donal72 committed 5 files to 'Moodle CVS' - 11/Jan/07 10:41 AM

Auth: Replace hardcoded strings: ~~MDL-8069~~

MODIFY	auth/shibboleth/config.html	Rev. 1.20	(+1 -1 lines)
MODIFY	auth/nntp/config.html	Rev. 1.12	(+4 -4 lines)
MODIFY	lang/en_utf8/auth.php	Rev. 1.16	(+14 -1 lines)
MODIFY	auth/pop3/config.html	Rev. 1.15	(+5 -5 lines)
MODIFY	auth/radius/config.html	Rev. 1.3	(+8 -8 lines)