Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.7, 1.8.5, 1.9
-
Component/s: Database activity module, Themes
-
Labels:None
-
Affected Branches:MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
-
Fixed Branches:MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
Description
MOODLE_17_STABLE missing file moodle/pix/i/approve.gif used by database module.
This makes it impossible to approve database entries in safari, which apparently doesn't fall back to the alt text appropriately, and makes firefox display the string "approve" rather than the image approve.gif.
Issue Links
| This issue has been marked as being related by: | ||||
| MDL-19391 | approve icon style need to be set to iconsmall in database module |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Hide
Eloy Lafuente (stronk7)
added a comment -
Confirmed... assigning to DC:
1) There is one "check.gif" icon in the glossary module.
2) There is another alternative here, courtesy of James Ballard. B-)
3) Please confirm with MD what one to use.
In any case I would propose to (confirm with MD too).
1) Move the decided icon to pix/i/approve.gif (17_STABLE to HEAD)
2) Move glossary usages of mod/glossary/check.gif to pix/i/approve.gif (19_STABLE and HEAD)
3) Test both modules icon appearance.
Ciao 
Show
Eloy Lafuente (stronk7)
added a comment - Confirmed... assigning to DC:
1) There is one "check.gif" icon in the glossary module.
2) There is another alternative here, courtesy of James Ballard. B-)
3) Please confirm with MD what one to use.
In any case I would propose to (confirm with MD too).
1) Move the decided icon to pix/i/approve.gif (17_STABLE to HEAD)
2) Move glossary usages of mod/glossary/check.gif to pix/i/approve.gif (19_STABLE and HEAD)
3) Test both modules icon appearance.
Ciao
This is still missing from 1.8 and 1.9 as well.
It needs a new icon in the right location or I guess pix/t/clear.gif may be suitable.
In mod/data/lib.php:
$patterns[]='##approve##';
if (has_capability('mod/data:approve', $context) && ($data->approval) && (!$record->approved)){ $replacement[] = '<a href="'.$CFG->wwwroot.'/mod/data/view.php?d='.$data->id.'&approve='.$record->id.'&sesskey='.sesskey().'"><img src="'.$CFG->pixpath.'/i/approve.gif" class="iconsmall" alt="'.get_string('approve').'" /></a>'; } else { $replacement[] = ''; }
Could be:
$patterns[]='##approve##';
if (has_capability('mod/data:approve', $context) && ($data->approval) && (!$record->approved)){ $replacement[] = '<a href="'.$CFG->wwwroot.'/mod/data/view.php?d='.$data->id.'&approve='.$record->id.'&sesskey='.sesskey().'"><img src="'.$CFG->pixpath.'/t/clear.gif" class="iconsmall" alt="'.get_string('approve').'" /></a>'; } else { $replacement[] = ''; } }
I added a green tick, approve.gif to the folder instead.
Yours
James