Moodle

New groups code & AS keyword

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8
  • Component/s: Groups
  • Labels:
    None
  • Environment:
    Oracle
  • Database:
    Oracle
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

I was looking groups code when I've detected that the "AS" keyword is being used to alias tables.

This totally forbidden by rule number 11 in http://docs.moodle.org/en/Coding#Database_structures is order to allow Oracle to work properly.

Easy to fix

Issue Links

This issue blocks:
MDL-7380 New groups and groupings Critical Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Assigning to Nick

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Nick
Hide
Permalink
Martin Dougiamas added a comment -

Nick, sorry I missed you on Skype just now. Do you have time to clear this blocker?

Show
Martin Dougiamas added a comment - Nick, sorry I missed you on Skype just now. Do you have time to clear this blocker?
Hide
Permalink
Nick Freear added a comment -

Fixed with this patch, which removes 'AS', fixes missing quotes and moves some SQL from lib/ to db/ directory.

Show
Nick Freear added a comment - Fixed with this patch, which removes 'AS', fixes missing quotes and moves some SQL from lib/ to db/ directory.
Hide
Permalink
Nick Freear added a comment -

Fixed, committed.

Show
Nick Freear added a comment - Fixed, committed.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.