[#MDL-8238] Error "JSON" not found when going into groups link from course page

Issue Details (XML | Word | Printable)

Key:	MDL-8238
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Blocker
Assignee:	Vy-Shane Sin Fat
Reporter:	Eloy Lafuente (stronk7)
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Error "JSON" not found when going into groups link from course page

Created: 21/Jan/07 02:23 AM Updated: 23/Jan/07 01:25 PM

Return to search

Component/s:

Groups

Affects Version/s:

1.8

Fix Version/s:

1.8

Environment:

Any

Issue Links:

Blockers

This issue blocks:

~~MDL-7380~~ New groups and groupings

Database:	Any
Participants:	Eloy Lafuente (stronk7), Martin Dougiamas, Nick Freear and Vy-Shane Sin Fat
Security Level:	None
Resolved date:	23/Jan/07
Affected Branches:	MOODLE_18_STABLE
Fixed Branches:	MOODLE_18_STABLE

Description

« Hide

I'm running HEAD updated. I've created one course and, from the page, I've selected the "groups" icon (in the admin block). It invokes:

/moodle_head/group/index.php?id=2

And is dropping this error:

Warning: require_once(/Users/stronk7/cvs_moodle/moodle_head/lib/json/JSON.php) [function.require-once]: failed to open stream: No such file or directory in /Users/stronk7/cvs_moodle/moodle_head/group/index.php on line 14

Fatal error: require_once() [function.require]: Failed opening required '/Users/stronk7/cvs_moodle/moodle_head/lib/json/JSON.php' (include_path='.:/usr/local/php5/lib/php') in /Users/stronk7/cvs_moodle/moodle_head/group/index.php on line 14

that prevents groups from working completely.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 21/Jan/07 02:24 AM

Assigning to Nick

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 21/Jan/07 02:27 AM

Also, note that "JSON.php" is a name that can potentially cause problems under some environments. I would suggest to lowercase it!

[ Permalink | « Hide ]

Nick Freear added a comment - 22/Jan/07 06:33 PM

One for Vy to look at I think, part of ~~MDL-8048~~.

[ Permalink | « Hide ]

Nick Freear added a comment - 22/Jan/07 06:50 PM

Hi Vy. The JSON library isn't in CVS! Which of these 4 are you using http://gggeek.altervista.org/sw/article_20061113.html and what compatibility issues are there?

(Perhaps we need a non-AJAX solution to ~~MDL-8048~~ this close to a release.)

Thanks, Nick

[ Permalink | « Hide ]

Vy-Shane Sin Fat added a comment - 22/Jan/07 09:48 PM

Sorry, my bad for not having committed it in yet.

It's Services_JSON, now part of PEAR (http://pear.php.net/pepr/pepr-proposal-show.php?id=198)

I'll rename it to lib/json/jsonlib.php if the filename it is distributed as will cause problems.

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 22/Jan/07 10:12 PM

Don't forget to add it to the credits page (with authors, license type, version...).

I hope BSD doesn't conflict with our GPL (ask MD, please).

NP with name under PEAR (we have some uppercase stuff there).... I think.

Ciao

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 22/Jan/07 11:35 PM

The license is fine, I checked that already. It's the "modified BSD license" without the advertising clause.

I've added it to http://docs.moodle.org/en/Credits

[ Permalink | « Hide ]

Vy-Shane Sin Fat added a comment - 23/Jan/07 01:25 PM

I've checked in PEAR's Services_JSON. I've kept the filename since Eloy says it's alright to do so. Less confusion for when we want to upgrade the library in the future.

lib/json/JSON.php

All content on this web site is made available under the GNU General Public License, unless otherwise stated.