Moodle

Error "JSON" not found when going into groups link from course page

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8
  • Component/s: Groups
  • Labels:
    None
  • Environment:
    Any
  • Database:
    Any
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

I'm running HEAD updated. I've created one course and, from the page, I've selected the "groups" icon (in the admin block). It invokes:

/moodle_head/group/index.php?id=2

And is dropping this error:

Warning: require_once(/Users/stronk7/cvs_moodle/moodle_head/lib/json/JSON.php) [function.require-once]: failed to open stream: No such file or directory in /Users/stronk7/cvs_moodle/moodle_head/group/index.php on line 14

Fatal error: require_once() [function.require]: Failed opening required '/Users/stronk7/cvs_moodle/moodle_head/lib/json/JSON.php' (include_path='.:/usr/local/php5/lib/php') in /Users/stronk7/cvs_moodle/moodle_head/group/index.php on line 14

that prevents groups from working completely.

Issue Links

This issue blocks:
MDL-7380 New groups and groupings Critical Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Assigning to Nick

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Nick
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Also, note that "JSON.php" is a name that can potentially cause problems under some environments. I would suggest to lowercase it!

Show
Eloy Lafuente (stronk7) added a comment - Also, note that "JSON.php" is a name that can potentially cause problems under some environments. I would suggest to lowercase it!
Hide
Permalink
Nick Freear added a comment -

One for Vy to look at I think, part of MDL-8048.

Show
Nick Freear added a comment - One for Vy to look at I think, part of MDL-8048.
Hide
Permalink
Nick Freear added a comment -

Hi Vy. The JSON library isn't in CVS! Which of these 4 are you using http://gggeek.altervista.org/sw/article_20061113.html and what compatibility issues are there?

(Perhaps we need a non-AJAX solution to MDL-8048 this close to a release.)

Thanks, Nick

Show
Nick Freear added a comment - Hi Vy. The JSON library isn't in CVS! Which of these 4 are you using http://gggeek.altervista.org/sw/article_20061113.html and what compatibility issues are there? (Perhaps we need a non-AJAX solution to MDL-8048 this close to a release.) Thanks, Nick
Hide
Permalink
Vy-Shane Sin Fat added a comment -

Sorry, my bad for not having committed it in yet.

It's Services_JSON, now part of PEAR (http://pear.php.net/pepr/pepr-proposal-show.php?id=198)

I'll rename it to lib/json/jsonlib.php if the filename it is distributed as will cause problems.

Show
Vy-Shane Sin Fat added a comment - Sorry, my bad for not having committed it in yet. It's Services_JSON, now part of PEAR (http://pear.php.net/pepr/pepr-proposal-show.php?id=198) I'll rename it to lib/json/jsonlib.php if the filename it is distributed as will cause problems.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Don't forget to add it to the credits page (with authors, license type, version...).

I hope BSD doesn't conflict with our GPL (ask MD, please).

NP with name under PEAR (we have some uppercase stuff there).... I think.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Don't forget to add it to the credits page (with authors, license type, version...). I hope BSD doesn't conflict with our GPL (ask MD, please). NP with name under PEAR (we have some uppercase stuff there).... I think. Ciao
Hide
Permalink
Martin Dougiamas added a comment -

The license is fine, I checked that already. It's the "modified BSD license" without the advertising clause.

I've added it to http://docs.moodle.org/en/Credits

Show
Martin Dougiamas added a comment - The license is fine, I checked that already. It's the "modified BSD license" without the advertising clause. I've added it to http://docs.moodle.org/en/Credits
Hide
Permalink
Vy-Shane Sin Fat added a comment -

I've checked in PEAR's Services_JSON. I've kept the filename since Eloy says it's alright to do so. Less confusion for when we want to upgrade the library in the future.

lib/json/JSON.php

Show
Vy-Shane Sin Fat added a comment - I've checked in PEAR's Services_JSON. I've kept the filename since Eloy says it's alright to do so. Less confusion for when we want to upgrade the library in the future. lib/json/JSON.php

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.