Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.7
-
Component/s: Administration
-
Labels:None
-
Affected Branches:MOODLE_17_STABLE
-
Fixed Branches:MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
Description
Affects Version/s may go back prior to 1.7.
I was writing my own cron code and was using Moodle's for a reference. I wanted one task to be executed at a specific time like Moodle's statistics. I found that Moodle's admin/cron.php uses the following line to get the time:
$timetocheck = strtotime("$CFG->statsruntimestarthour:$CFG->statsruntimestartminute today");
This always seems return midnight. I switch it to the following and I have had more success:
$timetocheck = strtotime("today $CFG->statsruntimestarthour:$CFG->statsruntimestartminute");
A diff off of HEAD is attached.
Forgot to add, I have not actually tested the diff
I was just looking at the returned time from the strtotime() function in my development code.