Moodle

TTW language updater removes language CVS checkout and thus local modification

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8.4, 1.9, 2.0
  • Component/s: Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

As a translator, I have got CVS checkout of both HEAD source code (CVS module "moodle") and HEAD languages (module "lang"). I regularly run "cvs update" in both working copies and I sometimes do "cvs checkin" in my language pack.

But - if I have to upgrade my dev installation because of the version shift, the first step appears to be an automatic language pack update (TTW - thru the web). This tool probably removes my own CVS checkout and it downloads and unpack standard lang pack from moodle.org.

From my point of view, this is a bug. The tool should check, if the language pack is CVS working copy. If it is so, the automatic update should not proceed, maybe with notification to run "cvs update" in language directory.

Issue Links

This issue is duplicated by:
MDL-10227 Update overwrites Non en-utf8 langfiles Minor Closed
This issue has a non-specific relationship to:
MDL-17094 Allow translators to disable automatic language update during Moodle upgrade Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Nicolas Martignoni added a comment -

Couldn't this be resolved (at least partially) by resolving MDL-6645?

Show
Nicolas Martignoni added a comment - Couldn't this be resolved (at least partially) by resolving MDL-6645?
Hide
Permalink
Koen Roggemans added a comment -

Hi Nicolas
If I understand David correctly, I don't think it is related.

Is this not a translator-only problem? Personally I never noticed it. Probably because I don't do version shifts, but have a test installation for each version.
Isn't your problem solved by first updating your installation and then updating your language packs or do I understand this completely wrong?

Show
Koen Roggemans added a comment - Hi Nicolas If I understand David correctly, I don't think it is related. Is this not a translator-only problem? Personally I never noticed it. Probably because I don't do version shifts, but have a test installation for each version. Isn't your problem solved by first updating your installation and then updating your language packs or do I understand this completely wrong?
Hide
Permalink
Nicolas Martignoni added a comment -

Hi Koen,
You're probably right. Neither did I suffer from this myself, and I think too that this is not related too MDL-6645.

Suggesting resolving as not reproducible, unless reporter experiment it still now.

Show
Nicolas Martignoni added a comment - Hi Koen, You're probably right. Neither did I suffer from this myself, and I think too that this is not related too MDL-6645. Suggesting resolving as not reproducible, unless reporter experiment it still now.
Hide
Permalink
Koen Roggemans added a comment -

Assume it is ok to close this now

Show
Koen Roggemans added a comment - Assume it is ok to close this now
Hide
Permalink
Nicolas Martignoni added a comment -

Closing, as not reproducible.

Show
Nicolas Martignoni added a comment - Closing, as not reproducible.
Hide
Permalink
David Mudrak added a comment -

Sorry guys, but I have to reopen this issue again. See http://moodle.org/mod/forum/discuss.php?d=70849
You are right, this is just translators' problem. But as long as this issue may lead to accidental translated string lost, I vote for fix. Or, at least, upgrade script should produce some warnings about removing the current language pack and confirmation should be needed.

Here are steps to reproduce:
1. I suppose you have a 1.8 installation. Do some modifications in a datamoodle/lang/xxx_utf8 package as a translator (e.g. by admin/lang.php)
2. Imagine you forget to check in these modifications, send them by email to the pack maintainer or just want to continue later.
3. Proceed a Moodle upgrade, i.e. overwrite source codes with new version and go to /admin
4. Please note - the language pack are automatically downloaded and you version is SILENTLY removed.

So, without any warning, your translations are lost just because you forgot to backup your lang/xxx_utf8... Is the problem more clear now?

Show
David Mudrak added a comment - Sorry guys, but I have to reopen this issue again. See http://moodle.org/mod/forum/discuss.php?d=70849 You are right, this is just translators' problem. But as long as this issue may lead to accidental translated string lost, I vote for fix. Or, at least, upgrade script should produce some warnings about removing the current language pack and confirmation should be needed. Here are steps to reproduce: 1. I suppose you have a 1.8 installation. Do some modifications in a datamoodle/lang/xxx_utf8 package as a translator (e.g. by admin/lang.php) 2. Imagine you forget to check in these modifications, send them by email to the pack maintainer or just want to continue later. 3. Proceed a Moodle upgrade, i.e. overwrite source codes with new version and go to /admin 4. Please note - the language pack are automatically downloaded and you version is SILENTLY removed. So, without any warning, your translations are lost just because you forgot to backup your lang/xxx_utf8... Is the problem more clear now?
Hide
Permalink
Nicolas Martignoni added a comment -

Yes, David, thank you for the clarification.

Confirming. And my +1 for resolution.

Show
Nicolas Martignoni added a comment - Yes, David, thank you for the clarification. Confirming. And my +1 for resolution.
Hide
Permalink
Koen Roggemans added a comment -

Assigned this to Martin.
Can we have a warning or maybe better: the possibility not to upgrade the language packs while doing an upgrade?

Show
Koen Roggemans added a comment - Assigned this to Martin. Can we have a warning or maybe better: the possibility not to upgrade the language packs while doing an upgrade?
Hide
Permalink
Nicolas Martignoni added a comment -

Like Koen, I would find better not to upgrade the lang packs while doing an upgrade.

Another option would be to let the admin choose if he does want the lang update or not.

Show
Nicolas Martignoni added a comment - Like Koen, I would find better not to upgrade the lang packs while doing an upgrade. Another option would be to let the admin choose if he does want the lang update or not.
Hide
Permalink
David Mudrak added a comment -

See comments in MDL-10227

Show
David Mudrak added a comment - See comments in MDL-10227
Hide
Permalink
David Mudrak added a comment -

Several possible solutions have been proposed here and at MDL-10227. IMO it is enough to just put a warning message for translators that their modifications might be overwritten. See the attached MDL-8330.patch introducing such a message.

Show
David Mudrak added a comment - Several possible solutions have been proposed here and at MDL-10227. IMO it is enough to just put a warning message for translators that their modifications might be overwritten. See the attached MDL-8330.patch introducing such a message.
Hide
Permalink
Nicolas Martignoni added a comment -

David, I think your solution is at least a progress in regard of the current situation. My +1 (if it counts) for it.
Thanks.

Show
Nicolas Martignoni added a comment - David, I think your solution is at least a progress in regard of the current situation. My +1 (if it counts) for it. Thanks.
Hide
Permalink
Yu Zhang added a comment -

Patch in 1.8, 1.9 and HEAD, thanks!

Show
Yu Zhang added a comment - Patch in 1.8, 1.9 and HEAD, thanks!
Hide
Permalink
Nicolas Martignoni added a comment -

Verified, closing. Thanks!

Show
Nicolas Martignoni added a comment - Verified, closing. Thanks!

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.