Issue Details (XML | Word | Printable)

Key: MDL-8330
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Yu Zhang
Reporter: David Mudrak
Votes: 1
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

TTW language updater removes language CVS checkout and thus local modification

Created: 28/Jan/07 11:01 PM   Updated: 01/Nov/08 05:33 AM
Return to search
Component/s: Languages
Affects Version/s: 1.8
Fix Version/s: 1.8.4, 1.9, 2.0

File Attachments: 1. Text File MDL-8330.patch (2 kB)
Issue Links:
Duplicate
 
Relates
 

Participants: David Mudrak, Koen Roggemans, Nicolas Martignoni and Yu Zhang
Security Level: None
QA Assignee: Nicolas Martignoni
Resolved date: 15/Nov/07
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
As a translator, I have got CVS checkout of both HEAD source code (CVS module "moodle") and HEAD languages (module "lang"). I regularly run "cvs update" in both working copies and I sometimes do "cvs checkin" in my language pack.

But - if I have to upgrade my dev installation because of the version shift, the first step appears to be an automatic language pack update (TTW - thru the web). This tool probably removes my own CVS checkout and it downloads and unpack standard lang pack from moodle.org.

From my point of view, this is a bug. The tool should check, if the language pack is CVS working copy. If it is so, the automatic update should not proceed, maybe with notification to run "cvs update" in language directory.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 13/Feb/07 03:58 AM
Couldn't this be resolved (at least partially) by resolving MDL-6645?

[ Permalink | « Hide ]
Koen Roggemans added a comment - 09/Mar/07 06:25 AM
Hi Nicolas
If I understand David correctly, I don't think it is related.

Is this not a translator-only problem? Personally I never noticed it. Probably because I don't do version shifts, but have a test installation for each version.
Isn't your problem solved by first updating your installation and then updating your language packs or do I understand this completely wrong?


[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 09/Mar/07 03:07 PM
Hi Koen,
You're probably right. Neither did I suffer from this myself, and I think too that this is not related too MDL-6645.

Suggesting resolving as not reproducible, unless reporter experiment it still now.


[ Permalink | « Hide ]
Koen Roggemans added a comment - 17/Mar/07 06:23 AM
Assume it is ok to close this now

Koen Roggemans made changes - 17/Mar/07 06:23 AM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Cannot Reproduce [ 5 ]
[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 17/Mar/07 06:25 PM
Closing, as not reproducible.

Nicolas Martignoni made changes - 17/Mar/07 06:25 PM
QA Assignee mina
Status Resolved [ 5 ] Closed [ 6 ]
[ Permalink | « Hide ]
David Mudrak added a comment - 05/May/07 11:57 PM
Sorry guys, but I have to reopen this issue again. See http://moodle.org/mod/forum/discuss.php?d=70849
You are right, this is just translators' problem. But as long as this issue may lead to accidental translated string lost, I vote for fix. Or, at least, upgrade script should produce some warnings about removing the current language pack and confirmation should be needed.

Here are steps to reproduce:
1. I suppose you have a 1.8 installation. Do some modifications in a datamoodle/lang/xxx_utf8 package as a translator (e.g. by admin/lang.php)
2. Imagine you forget to check in these modifications, send them by email to the pack maintainer or just want to continue later.
3. Proceed a Moodle upgrade, i.e. overwrite source codes with new version and go to /admin
4. Please note - the language pack are automatically downloaded and you version is SILENTLY removed.

So, without any warning, your translations are lost just because you forgot to backup your lang/xxx_utf8... Is the problem more clear now?


David Mudrak made changes - 05/May/07 11:57 PM
Resolution Cannot Reproduce [ 5 ]
Status Closed [ 6 ] Reopened [ 4 ]
[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 06/May/07 06:30 PM
Yes, David, thank you for the clarification.

Confirming. And my +1 for resolution.


Koen Roggemans made changes - 09/May/07 06:00 AM
Assignee Koen Roggemans [ koen ] Martin Dougiamas [ dougiamas ]
[ Permalink | « Hide ]
Koen Roggemans added a comment - 09/May/07 06:01 AM
Assigned this to Martin.
Can we have a warning or maybe better: the possibility not to upgrade the language packs while doing an upgrade?

[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 09/May/07 02:33 PM
Like Koen, I would find better not to upgrade the lang packs while doing an upgrade.

Another option would be to let the admin choose if he does want the lang update or not.


Nicolas Martignoni made changes - 02/Jul/07 03:24 PM
Link This issue has been marked as being related by MDL-10227 [ MDL-10227 ]
Nicolas Martignoni made changes - 02/Jul/07 04:51 PM
Link This issue is duplicated by MDL-10227 [ MDL-10227 ]
Nicolas Martignoni made changes - 02/Jul/07 04:52 PM
Link This issue has been marked as being related by MDL-10227 [ MDL-10227 ]
[ Permalink | « Hide ]
David Mudrak added a comment - 24/Jul/07 12:49 AM
See comments in MDL-10227

[ Permalink | « Hide ]
David Mudrak added a comment - 15/Nov/07 04:38 AM
Several possible solutions have been proposed here and at MDL-10227. IMO it is enough to just put a warning message for translators that their modifications might be overwritten. See the attached MDL-8330.patch introducing such a message.

David Mudrak made changes - 15/Nov/07 04:38 AM
Attachment MDL-8330.patch [ 12381 ]
[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 15/Nov/07 05:14 AM
David, I think your solution is at least a progress in regard of the current situation. My +1 (if it counts) for it.
Thanks.

[ Permalink | « Hide ]
Yu Zhang added a comment - 15/Nov/07 09:21 AM
Patch in 1.8, 1.9 and HEAD, thanks!

Yu Zhang made changes - 15/Nov/07 09:21 AM
Assignee Martin Dougiamas [ dougiamas ] Yu Zhang [ lazyfish ]
Fix Version/s 1.9 [ 10190 ]
Status Reopened [ 4 ] Resolved [ 5 ]
Fix Version/s 1.8.4 [ 10242 ]
Resolution Fixed [ 1 ]
Fix Version/s 2.0 [ 10122 ]
toyomoyo committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 15/Nov/07 10:15 AM
MDL-8330, adding a warning to translators about updating of lang packs
MODIFY admin/index.php   Rev. 1.265.2.9    (+7 -2 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.103.2.17    (+2 -1 lines)
toyomoyo committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 15/Nov/07 10:17 AM
MDL-8330, adding a warning to translators about updating of lang packs
MODIFY lang/en_utf8/admin.php   Rev. 1.154.2.10    (+1 -0 lines)
MODIFY admin/index.php   Rev. 1.286.2.2    (+7 -2 lines)
toyomoyo committed 2 files to 'Moodle CVS' - 15/Nov/07 10:18 AM
MDL-8330, adding a warning to translators about updating of lang packs
MODIFY lang/en_utf8/admin.php   Rev. 1.164    (+1 -0 lines)
MODIFY admin/index.php   Rev. 1.288    (+7 -2 lines)
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 15/Nov/07 10:51 AM
Brushed up translated strings for database.
Brushed up a translated help file for database.
Translated a new string for warning to translators MDL-8330.
MODIFY ja_utf8/admin.php   Rev. 1.215    (+2 -1 lines)
MODIFY ja_utf8/help/data/fieldmappings.html   Rev. 1.3    (+2 -2 lines)
MODIFY ja_utf8/data.php   Rev. 1.73    (+3 -3 lines)
martignoni committed 1 file to 'Lang CVS' - 15/Nov/07 04:02 PM
MDL-8330, adding a warning to translators about updating of lang packs
MODIFY fr_utf8/admin.php   Rev. 1.210    (+2 -1 lines)
[ Permalink | « Hide ]
Nicolas Martignoni added a comment - 21/Nov/07 04:53 PM
Verified, closing. Thanks!

Nicolas Martignoni made changes - 21/Nov/07 04:53 PM
Status Resolved [ 5 ] Closed [ 6 ]
David Mudrak made changes - 01/Nov/08 05:33 AM
Link This issue has a non-specific relationship to MDL-17094 [ MDL-17094 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators