Moodle

Extend check_browser_version() to include other A-Grade YUI browsers

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.7.1, 1.8
  • Fix Version/s: 1.7.2, 1.8
  • Component/s: AJAX
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE

Description

Why does the function check_browser_version() exclude Opera?

I do not see any reason. Opera 9 is an A-Grad Browser and fully supported by YUI. Please change the Opera Opera 9 exclusion for 1.7 and 1.8. Thank you very much.

Please see http://developer.yahoo.com/yui/articles/gbs/gbs_browser-chart.html

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Urs Hunkler added a comment -

And Safari 2 is an A-Grad Browser and is rejcted when I read the function right. Safari 2 should be allowed too.

Show
Urs Hunkler added a comment - And Safari 2 is an A-Grad Browser and is rejcted when I read the function right. Safari 2 should be allowed too.
Hide
Permalink
Martin Dougiamas added a comment -

We're being conservative and adding platforms as they start working 100% (much harder to remove them than add them!)

However, Vy, can you test Opera 9 and Safari 2? Do they work?

Show
Martin Dougiamas added a comment - We're being conservative and adding platforms as they start working 100% (much harder to remove them than add them!) However, Vy, can you test Opera 9 and Safari 2? Do they work?
Hide
Permalink
Urs Hunkler added a comment -

Martin, being conservative for the Moodle part is the best way to go.

But developersd/designers can and do use YUI for added interface enhancements or flexibility. These efforts should be supported because they add the opportunity that Moodle will benefit from YUI much faster. If these projects work with all A-Grade Browsers they should be possible in Moodle too.

A way around this dilemma - as I see it in the moment - would be to rework the loading function in a way that:

1) YUI is used for Moodle core functionality like Drag&Drop with Moodle tested Browser support
2) YUI can transparently be used from developers/designers without any Moodle internal filtering for all A-Grade Browsers

One solution may be that the Moodle Ajax option works only for the Moodle Drag&Drop and other internal Ajax.

What do you think?

Show
Urs Hunkler added a comment - Martin, being conservative for the Moodle part is the best way to go. But developersd/designers can and do use YUI for added interface enhancements or flexibility. These efforts should be supported because they add the opportunity that Moodle will benefit from YUI much faster. If these projects work with all A-Grade Browsers they should be possible in Moodle too. A way around this dilemma - as I see it in the moment - would be to rework the loading function in a way that: 1) YUI is used for Moodle core functionality like Drag&Drop with Moodle tested Browser support 2) YUI can transparently be used from developers/designers without any Moodle internal filtering for all A-Grade Browsers One solution may be that the Moodle Ajax option works only for the Moodle Drag&Drop and other internal Ajax. What do you think?
Hide
Permalink
Vy-Shane Sin Fat added a comment -

There are still issues with the AJAX course editing for Safari 2 (MDL-6381) and Opera 9 (MDL-7598).

Show
Vy-Shane Sin Fat added a comment - There are still issues with the AJAX course editing for Safari 2 (MDL-6381) and Opera 9 (MDL-7598).
Hide
Permalink
Martin Dougiamas added a comment -

I'm confused ... we aren't stopping developers using AJAX at all!

If they choose to implement it then they can (we'll fix the detection to address a wider range of browsers).

However if the user or admin decides to switch ajax off then moodle must still function (for accessibility).

Show
Martin Dougiamas added a comment - I'm confused ... we aren't stopping developers using AJAX at all! If they choose to implement it then they can (we'll fix the detection to address a wider range of browsers). However if the user or admin decides to switch ajax off then moodle must still function (for accessibility).
Hide
Permalink
Martin Dougiamas added a comment -

I'm working on adding checks for all grade-A browsers to ajaxenabled, but also adding support for a parameter which will be an array of browsers supported.

This allows the developer to restrict ajax enablement to only those browsers they know works, just for that specific page.

Show
Martin Dougiamas added a comment - I'm working on adding checks for all grade-A browsers to ajaxenabled, but also adding support for a parameter which will be an array of browsers supported. This allows the developer to restrict ajax enablement to only those browsers they know works, just for that specific page.
Hide
Permalink
Martin Dougiamas added a comment -

Nick's finishing this for me.

Show
Martin Dougiamas added a comment - Nick's finishing this for me.
Hide
Permalink
Nicolas Connault added a comment -

Enabled YUI on Opera 9.0 and Safari 2.0. Tested Opera (very slow!), needs Safari testing.

Show
Nicolas Connault added a comment - Enabled YUI on Opera 9.0 and Safari 2.0. Tested Opera (very slow!), needs Safari testing.
Hide
Permalink
Nicolas Connault added a comment -

See Version Control for comments. This task is complete, but YUI support for Safari and Opera isn't very usable. Try drag&drop for an example.

Show
Nicolas Connault added a comment - See Version Control for comments. This task is complete, but YUI support for Safari and Opera isn't very usable. Try drag&drop for an example.
Hide
Permalink
Martin Dougiamas added a comment -

Yes, that's why we need the second part of this bug to disable those specific browsers again on the course pages.

Show
Martin Dougiamas added a comment - Yes, that's why we need the second part of this bug to disable those specific browsers again on the course pages.
Hide
Permalink
Nicolas Connault added a comment -

Second part is complete. See lib/simpletest/testajaxlib.php for an example

Show
Nicolas Connault added a comment - Second part is complete. See lib/simpletest/testajaxlib.php for an example
Hide
Permalink
Martin Dougiamas added a comment -

OK, now it's complete , the final part was to add those new bits to the course formats.

Show
Martin Dougiamas added a comment - OK, now it's complete , the final part was to add those new bits to the course formats.
Hide
Permalink
Urs Hunkler added a comment -

I checked a feature using YUI in Opera 9 and it works.

Great and thanks a lot Nicolas and Martin

Show
Urs Hunkler added a comment - I checked a feature using YUI in Opera 9 and it works. Great and thanks a lot Nicolas and Martin

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.