Moodle

1.8 standart theme - support for right to left languages

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8.3
  • Component/s: Themes
  • Labels:
    None
  • URL:
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

The Theme support for right to left languages is partial and gives user a non proffesional appearence.
ALL sites which use righ to left languege (e.g. Hebew Arabic etc.) have to fix code or give users non-intuitive/non-professional system to work with:

I hope you could make 1.8 standart theme have a true support for right to legt languages:

http://kab4u.org/login/index.php

  • header (for most pages) title on right , connect/Jump .. on left
  • NavBar right justified + arrow pointing right to left
  • login page should reverse table columns and also inside columns "First visit" should be right justified

this is correct for all right to left languages

http://kab4u.org/mod/quiz/attempt.php?q=3
page order should be reversed (righ to left)
for supporting both direction langs - tabs should be round both directions (or flip dir)

this is a partial suggestion

I think moodle should have same professional look for languages in both directions (rtol and ltor).- your greate translation tool is only half the task of supporting right to left langueges.

thanks.

Issue Links

This issue is a clone of:
MDL-10424 CLONE -1.8 standart theme - support for right to left languages Major Closed
This issue will be resolved by:
MDL-10075 Can't add rtl css files. Does Moodle load theme/config.php several times with different $CFG set? Blocker Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Urs Hunkler added a comment -

Martin, I read that you are working on rtl issues. What is the actual state of this work. Is some work to be done for the standard theme?

Show
Urs Hunkler added a comment - Martin, I read that you are working on rtl issues. What is the actual state of this work. Is some work to be done for the standard theme?
Hide
Permalink
Shahar Dolev added a comment -

I am working on an RTL solution as well.

My idea was to use the direction flag from the config file, and add an additional CSS file that will fix all the RTL alignment issues (there are many...).

I added the following code to lib/weblib.php at the end of function theme_setup() [line 2607 in my version]:

/// only for RTL languages, add RTL CSS
if ( get_string('thisdirection') == 'rtl' ) { $CFG->stylesheets[] = $CFG->themewww.'/standard/rtl.css'.$paramstring; }

It works quite well. I have a CSS file with about 25 definitions that fixes most of the alignment problems.

However, when scanning for RTL problem, I found about 800 places where a direct aligning was done using "<td align="right">". The solution should be going through all these places and add a CSS class that will align to the right on LTR language, and to the left on RTL languages.

I'd like to hear any idea you have regarding this problem.

If you are interested in the CSS file, please contact me at shahar.dolev at gmail.com. I hope to have a complete solution soon that will enter the main trunk of moodle...

Thanks,

– Shahar

Show
Shahar Dolev added a comment - I am working on an RTL solution as well. My idea was to use the direction flag from the config file, and add an additional CSS file that will fix all the RTL alignment issues (there are many...). I added the following code to lib/weblib.php at the end of function theme_setup() [line 2607 in my version]: /// only for RTL languages, add RTL CSS if ( get_string('thisdirection') == 'rtl' ) { $CFG->stylesheets[] = $CFG->themewww.'/standard/rtl.css'.$paramstring; } It works quite well. I have a CSS file with about 25 definitions that fixes most of the alignment problems. However, when scanning for RTL problem, I found about 800 places where a direct aligning was done using "<td align="right">". The solution should be going through all these places and add a CSS class that will align to the right on LTR language, and to the left on RTL languages. I'd like to hear any idea you have regarding this problem. If you are interested in the CSS file, please contact me at shahar.dolev at gmail.com. I hope to have a complete solution soon that will enter the main trunk of moodle... Thanks, – Shahar
Hide
Permalink
Kab added a comment -

This is a BUG in ALL moodle version

Including 1.9 it a solution for this Rtol problem will not be present.

Show
Kab added a comment - This is a BUG in ALL moodle version Including 1.9 it a solution for this Rtol problem will not be present.
Hide
Permalink
Urs Hunkler added a comment -

With 1.8.3 and 1.9 STABLE this issue is solved. If you still find places please reopen the bug with detailed description.

Show
Urs Hunkler added a comment - With 1.8.3 and 1.9 STABLE this issue is solved. If you still find places please reopen the bug with detailed description.
Hide
Permalink
Kab added a comment -

thanks for the work but Only partial fix:

I upgraded to Dec 7 , 2007 1.8.3+ version
see: http://ashlagbaroch.org/kab4u1/

Problems on front page (small sample of the problems):
1) header should be right to left

2) all boxes should have title on right and minimize box on left

3) course on the available courses list: title name on right, description on left

4) Randum (from dictonary) title should be on right

remark:
many thing should change from: ltor to rtol, e.g titles icons etc.

Show
Kab added a comment - thanks for the work but Only partial fix: I upgraded to Dec 7 , 2007 1.8.3+ version see: http://ashlagbaroch.org/kab4u1/ Problems on front page (small sample of the problems): 1) header should be right to left 2) all boxes should have title on right and minimize box on left 3) course on the available courses list: title name on right, description on left 4) Randum (from dictonary) title should be on right remark: many thing should change from: ltor to rtol, e.g titles icons etc.
Hide
Permalink
Urs Hunkler added a comment -

Please hand the rtl issues over to the people working on it.

Show
Urs Hunkler added a comment - Please hand the rtl issues over to the people working on it.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.