if ((!empty($CFG->sitemailcharset) || !empty($CFG->allowusermailcharset))) {

Can you confirm that this fixes your problem in 1.7?

>Martin Dougiamas [13/Feb/07 12:23 PM]
>In 1.8 this line appears to have been changed to:
>
> if ((!empty($CFG->sitemailcharset) || !empty($CFG->allowusermailcharset))) {
>
>Can you confirm that this fixes your problem in 1.7?

No, it doesn't. I substituted the above line for the one you see commented out below, placed a check mark in the "allowusermailcharset" setting in the administrative settings/server/email panel, and then attempted to send two emails, one the normal way, and another with "immediate send". Neither message was send out but the messages are now labelled "sent" in the database.

if ((!empty($CFG->sitemailcharset) || !empty($CFG->allowusermailcharset))) {
// if (!empty($CFG->allowusermailcharset)) {

When I removed the check mark and attempted to send out another message, it went out as expected.

I'm not sure if this is related to this bug or not, but as adminstrator or when I log on with a user who is a teacher of the course, all of the messages, when pulled up, have a "edit" link at the bottom in addition to "delete" and "reply" even though the messages have been sent out. I have not explicity allowed the admin to edit all messages in the config file.

thanks for the report!