Just testing this improvement and found it confusing to have the role reset button appear for new roles.

For example:

1. Create a duplicate teacher role and change some permissions.
2. Click the role reset button and obtain the message "Are you sure that you want to reset role "Teacher copy 1 (editingteache_1)" to defaults?"
3. Choose Yes.

Expected result: Role reset
Actual result: Nothing changed

Is it possible to hide the role reset button for new roles?

• If role has legacy type selected - it is reset to default permissions for legacy type
• If no legacy selected - all permissions are cleared

please help me with the languages strings so that ppl understand that

$string['resetrolesure'] = 'Are you sure that you want to reset role \"$a->name ($a->shortname)\" to defaults?<p></p>The defaults are taken from the selected legacy capability ($a->legacytype).';

$string['resetrolesurenolegacy'] = 'Are you sure that you want to removed all permissions defined in this role \"$a->name ($a->shortname)\"?';

I tested your changes using the duplicate teacher role example above and found that the reset button worked exactly as expected

However, I think the role reset button for new roles is still confusing.

Example 2:

1. Create a new role allowing moodle/legacy:editingteacher only.
2. Click the role reset button and obtain the message "Are you sure that you want to reset role "new role (new2)" to defaults? The defaults are taken from the selected legacy capability (editingteacher)."
3. Choose Yes.

Result: All legacy editingteacher permissions are set, even though they weren't before!

I still think it would be preferable if the role reset button is hidden for new roles.

Isn't it simpler to just delete any new role with no legacy selected rather than having to reset it to clear all permissions?

However, if this is just not possible then perhaps the language strings could read:

$string['resetrolesure'] = 'Are you sure that you want to reset role \"$a->name ($a->shortname)\" to defaults?';

$string['resetrolesurenolegacy'] = 'Are you sure that you want to clear all permissions defined in the role \"$a->name ($a->shortname)\"?';

thanks for the feedback