Moodle

Time remaining covers question text in Quiz Module

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.7, 1.7.1, 1.9.7
  • Fix Version/s: 1.9.10
  • Component/s: Quiz
  • Labels:
    None
  • Environment:
    Linux, Windows
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

When a student is taking a quiz in a secure windows the Time Remainin block is covering part of the question text. So students cannot read the fist and/or second word of the questions.

Attachments

  1. Text File
    jstimer_hide_timer.actual.patch
    30/May/08 1:02 AM
    2 kB
    Nate H
  2. Text File
    jstimer_hide_timer.patch
    30/May/08 12:57 AM
    1.0 kB
    Nate H
  3. File
    timer_shrink_16.diff
    19/Feb/07 5:45 AM
    2 kB
    Anthony Borrow
  1. moodle_time_remaining_covers.jpg
    28 kB
    17/Feb/07 1:55 AM
  2. quiz_timer_blocking_questions_text_in_IE7.png
    28 kB
    06/Jan/10 6:55 AM
  3. shrink_timer_16.jpg
    121 kB
    19/Feb/07 5:47 AM
  4. Timer.jpg
    129 kB
    20/Oct/08 11:37 PM

Issue Links

This issue is duplicated by:
MDL-12852 Quiz timer covers quiz items Major Closed
MDL-13271 Timer covers first question in secure quiz window Major Closed
MDL-17711 Position of quiz timer Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

You may wish to see the discussion at http://moodle.org/mod/forum/discuss.php?d=45719 where I provided a patch file and documented some changes I made to make the time remaining block less conspicuous. Some argue that it needs to be larger in order to be noticed; however, many of my students report that the larger time is distracting. I will attach the patch file and an image to show how the shrunken time remaining block appears. It still covers the number but at least it does not cover up the text of the question. Peace.

Show
Anthony Borrow added a comment - You may wish to see the discussion at http://moodle.org/mod/forum/discuss.php?d=45719 where I provided a patch file and documented some changes I made to make the time remaining block less conspicuous. Some argue that it needs to be larger in order to be noticed; however, many of my students report that the larger time is distracting. I will attach the patch file and an image to show how the shrunken time remaining block appears. It still covers the number but at least it does not cover up the text of the question. Peace.
Hide
Permalink
Anthony Borrow added a comment -

Here is a diff generated from WinMerge (it is not a perfectly clean diff in terms of the filenames; however, it should provide a clear idea of the changes that I made.

Show
Anthony Borrow added a comment - Here is a diff generated from WinMerge (it is not a perfectly clean diff in terms of the filenames; however, it should provide a clear idea of the changes that I made.
Hide
Permalink
Anthony Borrow added a comment -

here is a screenshot with the applied shrink_timer_16.diff applied to Moodle 1.6+

Show
Anthony Borrow added a comment - here is a screenshot with the applied shrink_timer_16.diff applied to Moodle 1.6+
Hide
Permalink
Tim Hunt added a comment -

This patch does not apply to Moodle 1.6.4+. Also, it would be really great to have a patch against 1.8 as well (they changed a lot of the HTML in 1.8, to make it valid and more accessible).

Show
Tim Hunt added a comment - This patch does not apply to Moodle 1.6.4+. Also, it would be really great to have a patch against 1.8 as well (they changed a lot of the HTML in 1.8, to make it valid and more accessible).
Hide
Permalink
Eric Merrill added a comment -

Sorry I dupped this one, I searched, but didn't find it. This should also be linked to 1.8 and 1.9. Under at least 1.9 this fixes it:

Change line 51 in mod/quiz/jstimer.php from
var theTop = 10;
to
var theTop = <?php echo $popup ? 10 : 100; ?>;

And line 85 in mod/quiz/quiz.js from
pos += 100;
to
pos += 10;

Show
Eric Merrill added a comment - Sorry I dupped this one, I searched, but didn't find it. This should also be linked to 1.8 and 1.9. Under at least 1.9 this fixes it: Change line 51 in mod/quiz/jstimer.php from var theTop = 10; to var theTop = <?php echo $popup ? 10 : 100; ?>; And line 85 in mod/quiz/quiz.js from pos += 100; to pos += 10;
Hide
Permalink
Nate H added a comment -

I like Anthony's shrunk timer. Here's another route we could pursue to fix this bug.

I've attached a patch against 1.9's mod/quiz/jstimer.php that allows the student to temporarily hide the timer (it pops back up after a minute).

Show
Nate H added a comment - I like Anthony's shrunk timer. Here's another route we could pursue to fix this bug. I've attached a patch against 1.9's mod/quiz/jstimer.php that allows the student to temporarily hide the timer (it pops back up after a minute).
Hide
Permalink
Nate H added a comment -

Oops - that last "patch" had no context lines, it was a simple diff. I've now attached a more proper patch (jstimer_hide_timer.actual.patch)

Show
Nate H added a comment - Oops - that last "patch" had no context lines, it was a simple diff. I've now attached a more proper patch (jstimer_hide_timer.actual.patch)
Hide
Permalink
Glenn Wiggins added a comment -

This is a simple fix that works. Should it not be included in the next release?

Show
Glenn Wiggins added a comment - This is a simple fix that works. Should it not be included in the next release?
Hide
Permalink
Ann Adamcik added a comment -

Here's a simpler fix. The timer is 150px wide, so giving the question div a 155px left margin will ensure that the timer doesn't ever cover up the question text. The question number will still get covered, but I think that's probably acceptable.

Add this to your theme's css:

/* allow a fixed margin for the timer so it won't cover question text */
.que .content {
float: none;
margin-left: 155px;
width: auto;
}

Also, the timer in IE is wider than in Firefox. Adjusting the padding will make it the same width in both browsers:

/* adjust the timer width for IE */
#timer .generalbox {
padding: 0;
}

This fix could be used in conjunction with Nate's hide timer fix, or Anthony's shrunken timer (adjust the margin-left as needed).

Show
Ann Adamcik added a comment - Here's a simpler fix. The timer is 150px wide, so giving the question div a 155px left margin will ensure that the timer doesn't ever cover up the question text. The question number will still get covered, but I think that's probably acceptable. Add this to your theme's css: /* allow a fixed margin for the timer so it won't cover question text */ .que .content { float: none; margin-left: 155px; width: auto; } Also, the timer in IE is wider than in Firefox. Adjusting the padding will make it the same width in both browsers: /* adjust the timer width for IE */ #timer .generalbox { padding: 0; } This fix could be used in conjunction with Nate's hide timer fix, or Anthony's shrunken timer (adjust the margin-left as needed).
Hide
Permalink
Tim Hunt added a comment -

As part of the changes I have made for Moodle 2.0 in MDL-15452, that is the change in MDL-15750 where I move the timer into the new navigation panel, this issue will go away in the future. I think that life is too short to fix this issue separately in old stable branches. So I am closing this bug.

Show
Tim Hunt added a comment - As part of the changes I have made for Moodle 2.0 in MDL-15452, that is the change in MDL-15750 where I move the timer into the new navigation panel, this issue will go away in the future. I think that life is too short to fix this issue separately in old stable branches. So I am closing this bug.
Hide
Permalink
Tim Hunt added a comment -

Reopening, to commit a fix in Moodle 1.9.

Show
Tim Hunt added a comment - Reopening, to commit a fix in Moodle 1.9.
Hide
Permalink
Tim Hunt added a comment -

Fixed for 1.9.3. Note that I have done this by adding a 155px margin on each side of the page. That is, this will change the layout. Since secure mode opens full screen, hopefully this improves the layout, but do be aware that it will change.

Show
Tim Hunt added a comment - Fixed for 1.9.3. Note that I have done this by adding a 155px margin on each side of the page. That is, this will change the layout. Since secure mode opens full screen, hopefully this improves the layout, but do be aware that it will change.
Hide
Permalink
Ann Adamcik added a comment -

Hi Tim,

This works great if the quiz is in a secure window, but the timer still covers questions when the quiz is not in a secure window. The margin really needs to be added to both cases.

Show
Ann Adamcik added a comment - Hi Tim, This works great if the quiz is in a secure window, but the timer still covers questions when the quiz is not in a secure window. The margin really needs to be added to both cases.
Hide
Permalink
Tim Hunt added a comment -

I thought that there the timer only overlapped the page header when not in secure mode? Do you have a screen-shot?

Show
Tim Hunt added a comment - I thought that there the timer only overlapped the page header when not in secure mode? Do you have a screen-shot?
Hide
Permalink
Ann Adamcik added a comment -

Here's a screenshot from demo.moodle.org, the 'Short quiz about Moodle (with timer)' in the features demo. This is not in a secure window, using Firefox 3, and a screen resolution of 1280x1024. The timer covers the questions in IE7 as well.

Show
Ann Adamcik added a comment - Here's a screenshot from demo.moodle.org, the 'Short quiz about Moodle (with timer)' in the features demo. This is not in a secure window, using Firefox 3, and a screen resolution of 1280x1024. The timer covers the questions in IE7 as well.
Hide
Permalink
Tim Hunt added a comment -

Sure, it looks a bit ugly, but if you scroll a bit, you can see the whole question. The problem in secure mode was that there was no way to see the text of the first question. And adding the margins would be bad for people who do not have their browser maximised. Therefore, I think I am not going to change this in non-secure mode. You will have to wait until Moodle 2.0, or change your theme yourself. Sorry. Too much else on my todo list.

Show
Tim Hunt added a comment - Sure, it looks a bit ugly, but if you scroll a bit, you can see the whole question. The problem in secure mode was that there was no way to see the text of the first question. And adding the margins would be bad for people who do not have their browser maximised. Therefore, I think I am not going to change this in non-secure mode. You will have to wait until Moodle 2.0, or change your theme yourself. Sorry. Too much else on my todo list.
Hide
Permalink
Jerome Mouneyrac added a comment -

Tested on IE 7 with virtual box (1152x864), I went on demo.moodle.org, connect as student/demo, select Moodle Feature Demo course and the Quizz with limit
=> the timer hides the question (note that the student can still read the question if he scrolls down, but that's a bit not user friendly)
I think the timer should be tested on 800x600.

Show
Jerome Mouneyrac added a comment - Tested on IE 7 with virtual box (1152x864), I went on demo.moodle.org, connect as student/demo, select Moodle Feature Demo course and the Quizz with limit => the timer hides the question (note that the student can still read the question if he scrolls down, but that's a bit not user friendly) I think the timer should be tested on 800x600.
Hide
Permalink
Jerome Mouneyrac added a comment -

In fact demo.moodle.org is an old version 1.9.2. I tried on my machine it works fine. I close this issue.

Show
Jerome Mouneyrac added a comment - In fact demo.moodle.org is an old version 1.9.2. I tried on my machine it works fine. I close this issue.
Hide
Permalink
Wen Hao Chuang added a comment -

If I may I would like to reopen this ticket, as I just found out that for IE7, this issue is not fixed. Tested this with the latest 1.9.7+ build (20100105), please see attached screenshot. If someone could please double check, that would be great! Thanks!

Show
Wen Hao Chuang added a comment - If I may I would like to reopen this ticket, as I just found out that for IE7, this issue is not fixed. Tested this with the latest 1.9.7+ build (20100105), please see attached screenshot. If someone could please double check, that would be great! Thanks!
Hide
Permalink
Wen Hao Chuang added a comment -

quiz timer is still blocking the question text in IE7

Show
Wen Hao Chuang added a comment - quiz timer is still blocking the question text in IE7
Hide
Permalink
Tim Hunt added a comment -

What theme is that? - rather hard to fix CSS issues without knowing that.

Show
Tim Hunt added a comment - What theme is that? - rather hard to fix CSS issues without knowing that.
Hide
Permalink
Tim Hunt added a comment -

No answer to my last question, so re-closing.

Show
Tim Hunt added a comment - No answer to my last question, so re-closing.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.