[#MDL-8567] Workshop cron produces invalid SQL statement

Issue Details (XML | Word | Printable)

Key:	MDL-8567
Type:	Sub-task
Status:	Closed
Resolution:	Won't Fix
Priority:	Major
Assignee:	David Mudrak
Reporter:	David Mudrak
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-13392

Workshop cron produces invalid SQL statement

Created: 19/Feb/07 05:42 PM Updated: 04/May/09 05:27 PM

Component/s:

Forum, General, Workshop

Affects Version/s:

1.6.4

Fix Version/s:

1.9.5

Database:	PostgreSQL
Participants:	David Mudrak, Martin Dougiamas and Petr Škoda (skodak)
Security Level:	None
Affected Branches:	MOODLE_16_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

I can see these error messages in my database log file. It seems that at least cron.php is using invalid SQL statement and my database server complains about this:

2007-02-19 10:25:01 CET moodle_cz SELECTERROR: invalid input syntax for integer: ""
2007-02-19 10:25:01 CET moodle_cz SELECTSTATEMENT: SELECT * FROM mdl_workshop_assessments WHERE id = '' LIMIT 1
...
2007-02-19 10:28:25 CET moodle_cz SELECTERROR: invalid input syntax for integer: ""
2007-02-19 10:28:25 CET moodle_cz SELECTSTATEMENT: SELECT * FROM mdl_forum_subscriptions WHERE userid = '' AND forum = '5' LIMIT 1
...
2007-02-19 10:30:01 CET moodle_cz SELECTERROR: invalid input syntax for integer: ""
2007-02-19 10:30:01 CET moodle_cz SELECTSTATEMENT: SELECT * FROM mdl_workshop_assessments WHERE id = '' LIMIT 1
...
2007-02-19 10:35:01 CET moodle_cz SELECTERROR: invalid input syntax for integer: ""
2007-02-19 10:35:01 CET moodle_cz SELECTSTATEMENT: SELECT * FROM mdl_workshop_assessments WHERE id = '' LIMIT 1

Thus Moodle should check if it is providing valid integers before executing the query.