[#MDL-8690] Fix up our use of fieldsets on forms, change some to div

Issue Details (XML | Word | Printable)

Key:	MDL-8690
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Blocker
Assignee:	Yu Zhang
Reporter:	Martin Dougiamas
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Fix up our use of fieldsets on forms, change some to div

Created: 28/Feb/07 04:36 PM Updated: 06/Mar/07 08:59 AM

Return to search

Component/s:

General

Affects Version/s:

1.8

Fix Version/s:

1.8

Issue Links:

Dependency

This issue will help resolve:

~~MDL-8576~~ Feedback messages displayed in the wrong place in Quiz

Participants:	Martin Dougiamas, Petr Skoda, Urs Hunkler and Yu Zhang
Security Level:	None
Resolved date:	06/Mar/07
Affected Branches:	MOODLE_18_STABLE
Fixed Branches:	MOODLE_18_STABLE

Description

« Hide

We've used the fieldset tags (with invisiblefieldset) in some forms that are not appropriate.

If the forms are single buttons or very large things like the quiz reports, then just use a div instead (no class needed).

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 2 files to 'Moodle CVS' - 03/Mar/07 04:57 AM

~~MDL-8690~~ fixed regression in notice_yesno

MODIFY	theme/standard/styles_layout.css		Rev. 1.389		(+6 -3 lines)
MODIFY	lib/weblib.php		Rev. 1.829		(+3 -3 lines)

Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 03/Mar/07 05:00 AM

~~MDL-8690~~ fixed regression in notice_yesno ; backported from HEAD

MODIFY	theme/standard/styles_layout.css		Rev. 1.365.2.19		(+14 -5 lines)
MODIFY	lib/weblib.php		Rev. 1.812.2.17		(+3 -3 lines)

Petr Skoda committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 06/Mar/07 06:41 AM

~~MDL-8690~~ popup form now uses div instead of invisible fieldset

MODIFY	lib/weblib.php		Rev. 1.812.2.26		(+4 -4 lines)
MODIFY	theme/standard/styles_layout.css		Rev. 1.365.2.29		(+3 -2 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 06/Mar/07 06:42 AM

~~MDL-8690~~ popup form now uses div instead of invisible fieldset; merged from MOODLE_18_STABLE

MODIFY	lib/weblib.php		Rev. 1.837		(+5 -5 lines)
MODIFY	theme/standard/styles_layout.css		Rev. 1.399		(+3 -2 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.