Moodle

Fix up our use of fieldsets on forms, change some to div

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8
  • Component/s: General
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

We've used the fieldset tags (with invisiblefieldset) in some forms that are not appropriate.

If the forms are single buttons or very large things like the quiz reports, then just use a div instead (no class needed).

Issue Links

Activity

Hide
Urs Hunkler added a comment -

Some fieldset backgrounds:

W3C cite:
"The FIELDSET element allows authors to group thematically related controls and labels. Grouping controls makes it easier for users to understand their purpose while simultaneously facilitating tabbing navigation for visual user agents and speech navigation for speech-oriented user agents. The proper use of this element makes documents more accessible."

Betca cite:
"The Accessible form guidelines were developed originally for Becta specifically for the 2005 BETT awards.

1. The fieldset tag should encompass complete sections of a complex form [A U], and may encompass the whole of a simple form."

The main aspect is that fieldset helps grouping.

Fieldset helps users using forms.

_ The quiz page is no form in user view.
_ The small forms with few elements don't need grouping with fieldsets.

Show
Urs Hunkler added a comment - Some fieldset backgrounds: W3C cite: "The FIELDSET element allows authors to group thematically related controls and labels. Grouping controls makes it easier for users to understand their purpose while simultaneously facilitating tabbing navigation for visual user agents and speech navigation for speech-oriented user agents. The proper use of this element makes documents more accessible." Betca cite: "The Accessible form guidelines were developed originally for Becta specifically for the 2005 BETT awards. 1. The fieldset tag should encompass complete sections of a complex form [A U], and may encompass the whole of a simple form." The main aspect is that fieldset helps grouping. Fieldset helps users using forms. _ The quiz page is no form in user view. _ The small forms with few elements don't need grouping with fieldsets.
Hide
Yu Zhang added a comment -

changed all small form (single element forms) to use div, as there is no need to use fieldset. The quiz form is already using div, I think.

Show
Yu Zhang added a comment - changed all small form (single element forms) to use div, as there is no need to use fieldset. The quiz form is already using div, I think.
Hide
Petr Škoda (skodak) added a comment -

I have committed a patch for regression in notice_yesno()

Show
Petr Škoda (skodak) added a comment - I have committed a patch for regression in notice_yesno()
Hide
Petr Škoda (skodak) added a comment -

this should be mostly done?

Show
Petr Škoda (skodak) added a comment - this should be mostly done?
Hide
Yu Zhang added a comment -

I think so, gonna resolve this

Show
Yu Zhang added a comment - I think so, gonna resolve this

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: