Moodle

Unable to download / update language pack automatically, if the moodle site is inside of proxy server

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7.1
  • Fix Version/s: 1.9, 2.0
  • Component/s: Libraries
  • Labels:
    None
  • Environment:
    all platforms

Description

Bugs in moodle/lib/componentlib.class.php

fopen() and file_get_contents() does not reach "www.moodle.org" via proxy server.
Then, we can not download / update selected language pack automatically in [Site Administration][Language][Language Packs]

I have detected the cause of this bug, and modified.

See also following forum discussions.

http://moodle.org/mod/forum/discuss.php?d=60405

P.S. Sorry, English is not my native language...

Issue Links

This issue will be resolved by:
MDL-11845 Fix various components that don't respect http proxy settings Minor Closed
This issue has a non-specific relationship to:
MDL-8653 Langimport makes bad assumption about http headers Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Gibson added a comment -

Just tried this fix on my 1.8 install and got 'Downloaded file check failed.' increasing debug level gave no extra clues.

Show
Matt Gibson added a comment - Just tried this fix on my 1.8 install and got 'Downloaded file check failed.' increasing debug level gave no extra clues.
Hide
Permalink
Dan Poltawski added a comment -

This might be related to MDL-8653

Show
Dan Poltawski added a comment - This might be related to MDL-8653
Hide
Permalink
Matt Gibson added a comment -

Fix now works as per instructions at the bottom of the above thread.

Show
Matt Gibson added a comment - Fix now works as per instructions at the bottom of the above thread.
Hide
Permalink
Matt Gibson added a comment -

Any chance this fix could go into CVS? I've just updated and lost the changes so my install can't download language packs again.

Show
Matt Gibson added a comment - Any chance this fix could go into CVS? I've just updated and lost the changes so my install can't download language packs again.
Hide
Permalink
Petr Škoda (skodak) added a comment -

I was already working on another solution, but did not have time to finish and test it properly, sorry
this will be solved in 2.0

Show
Petr Škoda (skodak) added a comment - I was already working on another solution, but did not have time to finish and test it properly, sorry this will be solved in 2.0
Hide
Permalink
Tatsuya Shirai added a comment -

I have posted lib/componentlib.class.php for Moodle1.8.2+ in http://moodle.org/mod/forum/discuss.php?d=60405 .
Try it!

Show
Tatsuya Shirai added a comment - I have posted lib/componentlib.class.php for Moodle1.8.2+ in http://moodle.org/mod/forum/discuss.php?d=60405 . Try it!
Hide
Permalink
Matt Gibson added a comment -

This affects 1.9 too. Will the same patches work?

Show
Matt Gibson added a comment - This affects 1.9 too. Will the same patches work?
Hide
Permalink
Tatsuya Shirai added a comment -

I'm using only Moodle1.8.3+.
I can not try to verify that the patches should work fine in Moodle1.9.Sorry!
I can not upgrade version of my Moodle1.8 to 1.9 so easy since my Moodle system is applied several original paches...

Show
Tatsuya Shirai added a comment - I'm using only Moodle1.8.3+. I can not try to verify that the patches should work fine in Moodle1.9.Sorry! I can not upgrade version of my Moodle1.8 to 1.9 so easy since my Moodle system is applied several original paches...
Hide
Permalink
Dan Poltawski added a comment -

Hi this was fixed recently in CVS, see MDL-11845

Show
Dan Poltawski added a comment - Hi this was fixed recently in CVS, see MDL-11845
Hide
Permalink
Matt Gibson added a comment -

It works now. Thanks for the heads-up Dan.

Show
Matt Gibson added a comment - It works now. Thanks for the heads-up Dan.

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.