Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: 1.7, 1.7.1, 1.7.2, 1.8
-
Component/s: Enrolments, Roles / Access
-
Labels:None
-
Affected Branches:MOODLE_17_STABLE, MOODLE_18_STABLE
-
Fixed Branches:MOODLE_17_STABLE, MOODLE_18_STABLE
Description
Eloy has correctly identified timestart and timeend as a big database bottleneck in load_user_capability because they prevent caching and deal with inequalities, so let's get rid if them!
These times specify the duration that the enrolment is active. Currently they are only used by self-enrolling courses where the course has a duration. In these instance timestart is set to now and timeend is set to some time in the future. Zero in timestart means inifinite past, and in timeend means inifinite future.
We were checking these to cope with all cases where people might want to set enrolment durations starting and ending in the future, but this is actually not very useful. Let's let the enrolment plugins handle such things (adding role assignments on the fly where necessary).
So instead, I propose:
1) We remove the time checks completely from load_user_capability and assume all role assigments in the database are valid.
2) We add a cron check to delete any role assignments where (timeend > 0 AND timeend < $now)
3) We make sure this is documented well in the code and on the wiki.
Issue Links
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Cool!
One minor note. There are some lines that have been added both to 1.8 and HEAD that aren't needed now that timestart and timeend are out from the query:
/// Always round timestart downto 100 secs to help DBs to use their own caching algorithms
2112 /// by repeating queries with the same exact parameters in a 100 secs time window
2113 $newra->timestart = round($timestart, -2);
those were part of my initial patch but, IMO now completely un-needed.
Ciao 
Quick notes: