Moodle

PDF byteserving no more working

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7.1
  • Fix Version/s: 1.7.3, 1.8.1
  • Component/s: Resource
  • Labels:
    None
  • Environment:
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE

Description

PDF byteserving (one page at a time viewing): no need to download the whole file to view the PDF file inside the browser with the Adobe Reader plugin.

It was OK in previous versions of Moodle, but not sure since which version the bug is there (or back).

The problem is located in /usr/share/moodle/lib/filelib.php:

With Moodle v1.7.1 we have filelib.php v1.30.2.3 which has the problem.

I replaced the filelib.php by an older version (v1.15), an the problem is not there anymore (PDF byteserving is working fine).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

I guess this is caused by the workaround for the famous XSS bug in Adobe readers

Could you send me a link to some large sample PDF and user/password via email? ( skodak at moodle dot org)

Show
Petr Škoda (skodak) added a comment - I guess this is caused by the workaround for the famous XSS bug in Adobe readers Could you send me a link to some large sample PDF and user/password via email? ( skodak at moodle dot org)
Hide
Permalink
Eric Dodemont added a comment -

I made some more tests, and the results depend also on which Adobe Reader plugin version is used.

The folowing clients/plugins were tested:

  • FireFox (Windows and Linux)
  • Internet Explorer (Windows)
  • Adobe Reader version 7 [AR7] (Windows and Linux) and 8 [AR8] (Windows)

1) without PHP/filelib (file served directly by the webserver): PDF byteserving always OK.

2) With PHP/filelib v1.30.2.3 (Moodle 1.7.1): PDF byteserving always NOK.

3) With PHP/filelib v1.15 (Moodle 1.6dev): PDF byteserving NOK with IE (AR7/AR8) and OK with FF (AR7/AR8).

Show
Eric Dodemont added a comment - I made some more tests, and the results depend also on which Adobe Reader plugin version is used. The folowing clients/plugins were tested:
  • FireFox (Windows and Linux)
  • Internet Explorer (Windows)
  • Adobe Reader version 7 [AR7] (Windows and Linux) and 8 [AR8] (Windows)
1) without PHP/filelib (file served directly by the webserver): PDF byteserving always OK. 2) With PHP/filelib v1.30.2.3 (Moodle 1.7.1): PDF byteserving always NOK. 3) With PHP/filelib v1.15 (Moodle 1.6dev): PDF byteserving NOK with IE (AR7/AR8) and OK with FF (AR7/AR8).
Hide
Permalink
Petr Škoda (skodak) added a comment -

thanks for the update, I will try to fix it before the 1.8 release

Show
Petr Škoda (skodak) added a comment - thanks for the update, I will try to fix it before the 1.8 release
Hide
Permalink
Petr Škoda (skodak) added a comment -

should be fixed in cvs sorry for the delay and thanks for the report.

please reopen in case of any problems...

Show
Petr Škoda (skodak) added a comment - should be fixed in cvs sorry for the delay and thanks for the report. please reopen in case of any problems...
Hide
Permalink
Eric Dodemont added a comment -

My first tests show that the PDF byteserving ("one page at a time – fast web view") is working fine now!

I am running Moodle 1.7.1.

I fetched filelib.php 1.41 [Moodle 1.7.3/1.8.1] (and libcurlemu) from the CVS repository and put them in the correct directories.

I am making tests with:

  • Adobe Reader 7.0 and 8.0 (with plugin for IE and FF)
  • Internet Explorer 6.0 and 7.0
  • Firefox 1.5 and 2.0
  • Windows XP and Vista
  • Linux Ubuntu

Thanks a lot.

Show
Eric Dodemont added a comment - My first tests show that the PDF byteserving ("one page at a time – fast web view") is working fine now! I am running Moodle 1.7.1. I fetched filelib.php 1.41 [Moodle 1.7.3/1.8.1] (and libcurlemu) from the CVS repository and put them in the correct directories. I am making tests with:
  • Adobe Reader 7.0 and 8.0 (with plugin for IE and FF)
  • Internet Explorer 6.0 and 7.0
  • Firefox 1.5 and 2.0
  • Windows XP and Vista
  • Linux Ubuntu
Thanks a lot.
Hide
Permalink
Petr Škoda (skodak) added a comment -

Thanks for testing

Show
Petr Škoda (skodak) added a comment - Thanks for testing

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.