Moodle

Students can view grade for hidden assignments

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7.1
  • Fix Version/s: 1.8.3, 1.9
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

Students can view the grading for hidden assignments. This can be extremely harmful from a pedagogical way, since many times teachers want a hidden place to keep their own thoughts about a student's work, a different place from the "official" grading presented to the student. A way to do this is adding a hidden assignment that can be used for that purpose.

First I supposed there could be something wrong with a capability, but I could temporarily solve it by changing line 3059 of grade/lib.php:

FROM: if (empty($mod->modname)) { continue; // Just in case, see MDL-7150 }

TO: if (empty($mod->modname) || empty($mod->visible)) { continue; // Just in case, see MDL-7150 }

Maybe ther should be a check for capabilities in place of this.

Activity

Hide
Pablo Etcheverry added a comment -

It's also affecting 1.7.2...

Show
Pablo Etcheverry added a comment - It's also affecting 1.7.2...
Hide
Rorshack Vision added a comment -

I don't think this is a bug.

Teachers have an option of hiding assignments after they have been completed to remove clutter, but maintain grades for students.

You also have the option of changing the weighting / category of the assignment to show that it's being reviewed. On our moodle, we hide assignments, just so we can design our own User Interface, so if your feature was introduce we'd destroy our system's entire organisation

Show
Rorshack Vision added a comment - I don't think this is a bug. Teachers have an option of hiding assignments after they have been completed to remove clutter, but maintain grades for students. You also have the option of changing the weighting / category of the assignment to show that it's being reviewed. On our moodle, we hide assignments, just so we can design our own User Interface, so if your feature was introduce we'd destroy our system's entire organisation
Hide
Skip Marshall added a comment -

We've noticed that assignments that we place in hidden categories within the gradebook are visible as well.

Perhaps an option that allows an assignment to be hidden within the gradebook would be beneficial.

Show
Skip Marshall added a comment - We've noticed that assignments that we place in hidden categories within the gradebook are visible as well. Perhaps an option that allows an assignment to be hidden within the gradebook would be beneficial.
Hide
Elena Ivanova added a comment - - edited

We run 1.8 + (2007021520) and it has the same issue.
Students can see links/max grades to all hidden activities from the Gradebook. If they click on the link there, they will receive a message : "Sorry, this activity is currently hidden". No good.

Update: Upgrade to 1.8.2 solved this, but kind of.
Gradebook is fine now, but students could still go to their profiles, click on Activity Reports (if allowed by instructor in Settings) and there they will see subtab for Grades, which will display all hidden activities.
As an admin, I have changed Student permission for "See user activity reports" to Prohibit. Which is unfortunate, since people like to see the stats, but I cannot risk showing that Grades area with hidden items.

Show
Elena Ivanova added a comment - - edited We run 1.8 + (2007021520) and it has the same issue. Students can see links/max grades to all hidden activities from the Gradebook. If they click on the link there, they will receive a message : "Sorry, this activity is currently hidden". No good. Update: Upgrade to 1.8.2 solved this, but kind of. Gradebook is fine now, but students could still go to their profiles, click on Activity Reports (if allowed by instructor in Settings) and there they will see subtab for Grades, which will display all hidden activities. As an admin, I have changed Student permission for "See user activity reports" to Prohibit. Which is unfortunate, since people like to see the stats, but I cannot risk showing that Grades area with hidden items.
Hide
Petr Škoda (skodak) added a comment -

activity reports fixed in cvs.
1.9 has independent hiding of grades

closing now, thanks for the reports!

Show
Petr Škoda (skodak) added a comment - activity reports fixed in cvs. 1.9 has independent hiding of grades closing now, thanks for the reports!

People

Dates

  • Created:
    Updated:
    Resolved: