Moodle

fix moodle/category:visibility

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Duplicate
  • Affects Version/s: 1.7
  • Fix Version/s: None
  • Component/s: Administration, Course
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE

Description

moodle/category:visibility has description "See hidden categories" but in reality it displays the link to change visibility, but after clicking the link moodle/category:update is used for access control.

Issue Links

Activity

Hide
Martin Dougiamas added a comment -

Does it ALSO govern the ability to see hidden categories?

Show
Martin Dougiamas added a comment - Does it ALSO govern the ability to see hidden categories?
Hide
Tim Hunt added a comment -

Grabbing a bunch of related course category editing bugs that I plan to work on. Sorry for all the emails.

Show
Tim Hunt added a comment - Grabbing a bunch of related course category editing bugs that I plan to work on. Sorry for all the emails.
Hide
Tim Hunt added a comment -

Looking at the code in datalib, yes, it does control the ability to see hidden categories.

I think to logical thing is to make moodle/category:visibility just about seeing hidden categories, and using moodle/category:update for all aspects of updating a category, which includes changing visibility.

Show
Tim Hunt added a comment - Looking at the code in datalib, yes, it does control the ability to see hidden categories. I think to logical thing is to make moodle/category:visibility just about seeing hidden categories, and using moodle/category:update for all aspects of updating a category, which includes changing visibility.

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: