Issue Details (XML | Word | Printable)

Key: MDL-8922
Type: Bug Bug
Status: Reopened Reopened
Priority: Minor Minor
Assignee: moodle.com
Reporter: Dan Poltawski
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

RSS Block Can Break Strict

Created: 16/Mar/07 12:28 AM   Updated: 13/Nov/09 04:08 PM
Return to search
Component/s: Administration
Affects Version/s: 1.9
Fix Version/s: 2.0

Participants: Dan Poltawski, Mathieu Petit-Clair, moodle.com and Nicolas Connault
Security Level: None
Resolved date: 26/Mar/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
Feed titles with & in will break strict

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dan Poltawski made changes - 16/Mar/07 12:54 AM
Field Original Value New Value
Summary RSS Block Can Breaks Strict RSS Block Can Break Strict
[ Permalink | « Hide ]
Dan Poltawski added a comment - 16/Mar/07 12:59 AM
Fixed some of the output functions for the main page.

The configuration page doesn't validate at all, though


Dan Poltawski committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 16/Mar/07 01:57 AM
MDL-8922 - some xhtml fixes
MODIFY blocks/rss_client/block_rss_client.php   Rev. 1.69.2.2    (+5 -4 lines)
Dan Poltawski committed 1 file to 'Moodle CVS' - 16/Mar/07 01:58 AM
MDL-8922 Some Xhtml fixes, merged from MOODLE_18_STABLE
MODIFY blocks/rss_client/block_rss_client.php   Rev. 1.71    (+5 -4 lines)
Nicolas Connault made changes - 23/Mar/07 08:36 AM
Assignee Dan Poltawski [ poltawski ] Nicolas Connault [ nicolasconnault ]
Nicolas Connault made changes - 23/Mar/07 08:36 AM
Status Open [ 1 ] In Progress [ 3 ]
Nicolas Connault committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 23/Mar/07 04:46 PM
MDL-8922 : Fixed a number of xhtml simple issues, but heaps of hard-core fixes yet to do.
MODIFY blocks/moodleblock.class.php   Rev. 1.79.2.4    (+4 -2 lines)
MODIFY blocks/rss_client/Attic/config_instance_tabs.php   Rev. 1.8.4.1    (+4 -4 lines)
Nicolas Connault committed 2 files to 'Moodle CVS' - 23/Mar/07 04:48 PM
MDL-8922 : Fixed a number of xhtml simple issues, but heaps of hard-core fixes yet to do.
MODIFY blocks/moodleblock.class.php   Rev. 1.84    (+4 -2 lines)
MODIFY blocks/rss_client/Attic/config_instance_tabs.php   Rev. 1.9    (+3 -3 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 23/Mar/07 04:49 PM
MDL-8922 : Fixed a number of xhtml simple issues, but heaps of hard-core fixes yet to do.
MODIFY theme/standard/styles_layout.css   Rev. 1.365.2.45    (+20 -1 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 23/Mar/07 04:51 PM
MDL-8922 : Fixed a number of xhtml simple issues, but heaps of hard-core fixes yet to do.
MODIFY theme/standard/styles_layout.css   Rev. 1.414    (+20 -1 lines)
Nicolas Connault committed 4 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 23/Mar/07 04:58 PM
MDL-8922 : More work on cleaning up RSS block, but not quite there yet.
MODIFY lib/rsslib.php   Rev. 1.46.2.4    (+19 -9 lines)
MODIFY lib/weblib.php   Rev. 1.812.2.47    (+36 -19 lines)
MODIFY blocks/rss_client/Attic/config_instance.html   Rev. 1.29.2.1    (+24 -24 lines)
MODIFY lib/blocklib.php   Rev. 1.119.2.1    (+2 -2 lines)
Nicolas Connault committed 4 files to 'Moodle CVS' - 23/Mar/07 05:01 PM
MDL-8922 More work on fixing RSS block XHTML
MODIFY lib/weblib.php   Rev. 1.856    (+36 -19 lines)
MODIFY lib/rsslib.php   Rev. 1.50    (+19 -9 lines)
MODIFY blocks/rss_client/Attic/config_instance.html   Rev. 1.30    (+24 -24 lines)
MODIFY lib/blocklib.php   Rev. 1.121    (+1 -1 lines)
Nicolas Connault committed 5 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 26/Mar/07 10:57 AM
MDL-8922: Had to modify another bunch of files to fix a simple problem:
when a config block contains a form, the previous form needs to be closed
properly (it was, but there were non-matching closing divs etc...).
MODIFY blocks/rss_client/Attic/config_instance.html   Rev. 1.29.2.2    (+3 -4 lines)
MODIFY blocks/moodleblock.class.php   Rev. 1.79.2.5    (+2 -4 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.365.2.46    (+6 -1 lines)
MODIFY lib/blocklib.php   Rev. 1.119.2.2    (+2 -2 lines)
MODIFY blocks/rss_client/styles.php   Rev. 1.9.18.1    (+3 -1 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 26/Mar/07 11:04 AM
MDL-8922: Had to modify another bunch of files to fix a simple problem:
when a config block contains a form, the previous form needs to be closed
properly (it was, but there were non-matching closing divs etc...).
MODIFY blocks/rss_client/block_rss_client.php   Rev. 1.69.2.3    (+4 -4 lines)
Nicolas Connault committed 6 files to 'Moodle CVS' - 26/Mar/07 11:06 AM
MDL-8922: Had to modify another bunch of files to fix a simple problem:
when a config block contains a form, the previous form needs to be closed
properly (it was, but there were non-matching closing divs etc...).
MODIFY blocks/rss_client/Attic/config_instance.html   Rev. 1.31    (+3 -4 lines)
MODIFY blocks/rss_client/styles.php   Rev. 1.10    (+3 -1 lines)
MODIFY lib/blocklib.php   Rev. 1.122    (+2 -2 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.415    (+6 -1 lines)
MODIFY blocks/rss_client/block_rss_client.php   Rev. 1.72    (+2 -2 lines)
MODIFY blocks/moodleblock.class.php   Rev. 1.85    (+2 -4 lines)
[ Permalink | « Hide ]
Nicolas Connault added a comment - 26/Mar/07 11:07 AM
MDL-8922: Had to modify another bunch of files to fix a simple problem: 2 when a config block contains a form, the previous form needs to be closed 3 properly (it was, but there were non-matching closing divs etc...)

Nicolas Connault made changes - 26/Mar/07 11:07 AM
Resolution Fixed [ 1 ]
Status In Progress [ 3 ] Resolved [ 5 ]
[ Permalink | « Hide ]
Mathieu Petit-Clair added a comment - 19/Dec/07 05:22 PM
In recent 19_STABLE, this problem seems to be back. When following the link to manage rss feeds from a RSS block, the first screens work all right, but the feed management screen breaks down with a "mismatched tag. Expected: </form>" message.

Putting the "</div></form>" line back on line 529 of lib/rsslib.php fixes the problem.


Mathieu Petit-Clair made changes - 19/Dec/07 05:22 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Mathieu Petit-Clair made changes - 19/Dec/07 05:25 PM
Affects Version/s 1.9 [ 10190 ]
[ Permalink | « Hide ]
Mathieu Petit-Clair added a comment - 19/Dec/07 05:28 PM
This is only in 1.9. This does not occur in 1.8, which is quite strange since both versions of rss_get_form() are identical (to a single blank character).

I'm wondering if this is a local bug, but since I've got a clean checkout...


Mathieu Petit-Clair made changes - 19/Dec/07 05:28 PM
Affects Version/s 1.8 [ 10130 ]
Martin Dougiamas made changes - 12/Jan/08 05:45 PM
Fix Version/s 2.0 [ 10122 ]
Fix Version/s 1.8 [ 10130 ]
Martin Dougiamas made changes - 13/Nov/09 04:08 PM
Assignee Nicolas Connault [ nicolasconnault ] moodle.com [ moodle.com ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators