Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.6, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.7, 1.7.1
-
Component/s: SCORM
-
Labels:None
-
Affected Branches:MOODLE_16_STABLE, MOODLE_17_STABLE
-
Fixed Branches:MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
Description
Proof of concept: put \' character in errorlogs string from scorm. Then try to put a scorm activity (you'll get a "no manifest found" error). See mod.html in scorm directory and the line result.concat('<?php print_string('errorlogs','scorm',NULL,"'") ?>:\n'+errorlogs);
If errorlogs has a ' in it causes a problem because the string within concat is prematurely closed.
I don't think putting a
before the \' in the language file is the best solution. Perhaps this strings are reused in another context... i don't know really :-P So here comes this report 
Thanks in advance
Attachments
Issue Links
| This issue has a non-specific relationship to: | ||||
| MDL-8193 | Incorrect handling of quotes in SetValue processing |
|
|
|
Activity
Thanks Petr for your quick response
I've made a mistake in the description. It was:
<?php print_string('errorlogs','scorm') ?>:\n'+errorlogs);
I'll patch my code now with your comments 
I've made a mistake in the description. It was:
<?php print_string('errorlogs','scorm') ?>:\n'+errorlogs);
I'll patch my code now with your comments this should now be fixed as part of MDL-8193 - please upgrade to the latest 1.9stable or 1.8stable.
thanks,
Dan
Dan 
Language packs are IMO ok, but we have to use our php function addslashes_js() in javascript code. Please not that addslashes() must not be used there because of sybase quotes.