Moodle

Let qtype lang files live in a subfolder of the question/type/qtype folder

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7.1
  • Fix Version/s: 1.8, 1.9
  • Component/s: Language, Questions
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

Modules can already do this.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

The was fixed recently be changes in moodlelib.php/get_string and help.php.

Lang string should go into

question/type/xxx/lang/en_utf8/qtype_xxx.php

and help files into

with any help files in the

question/type/xxx/lang/en_utf8/help/xxx/ folder.

Show
Tim Hunt added a comment - The was fixed recently be changes in moodlelib.php/get_string and help.php. Lang string should go into question/type/xxx/lang/en_utf8/qtype_xxx.php and help files into with any help files in the question/type/xxx/lang/en_utf8/help/xxx/ folder.
Hide
Permalink
Oleg Sychev added a comment -

Using question/type/xxx/lang/en_utf8/help/xxx/ folder isn't convenient since
a) there is no real need to have a subfolder there, it's may be as well question/type/xxx/lang/en_utf8/help
b) in language pack subfolder name must be qtype_xxx (help button near questiontype name on editing screen assumes that), so if we must have subfolder it probably should be qtype_xxx too to make further integration easier.

Show
Oleg Sychev added a comment - Using question/type/xxx/lang/en_utf8/help/xxx/ folder isn't convenient since a) there is no real need to have a subfolder there, it's may be as well question/type/xxx/lang/en_utf8/help b) in language pack subfolder name must be qtype_xxx (help button near questiontype name on editing screen assumes that), so if we must have subfolder it probably should be qtype_xxx too to make further integration easier.
Hide
Permalink
Tim Hunt added a comment -

I know it is not an ideal naming convention, however, this convention is the same for all types of plugin, and it has been like that for years. Changing it now would break all the plugins out there for a very minor gain. I am afraid that you will just have to live with things the way they are.

Show
Tim Hunt added a comment - I know it is not an ideal naming convention, however, this convention is the same for all types of plugin, and it has been like that for years. Changing it now would break all the plugins out there for a very minor gain. I am afraid that you will just have to live with things the way they are.
Hide
Permalink
Oleg Sychev added a comment -

I really can't see why we should change naming convention and break anything. You can just add a new place to search instead, so the old code will be alright.

Show
Oleg Sychev added a comment - I really can't see why we should change naming convention and break anything. You can just add a new place to search instead, so the old code will be alright.
Hide
Permalink
Tim Hunt added a comment -

Because one extra place to search actually translates into a few extra places to search once you consider non-English languages, and accessing the disc is (relatively) slow. It is not difficult to live with things the way they are, so this is an unnecessary performance hit, so we won't do it.

Show
Tim Hunt added a comment - Because one extra place to search actually translates into a few extra places to search once you consider non-English languages, and accessing the disc is (relatively) slow. It is not difficult to live with things the way they are, so this is an unnecessary performance hit, so we won't do it.
Hide
Permalink
Tim Hunt added a comment -

This has been working for ages without complaint, so closing. (It just got into the QA list because of recent comments.)

Show
Tim Hunt added a comment - This has been working for ages without complaint, so closing. (It just got into the QA list because of recent comments.)

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.