Issue Details (XML | Word | Printable)

Key: MDL-8945
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-2727

Let qtype lang files live in a subfolder of the question/type/qtype folder

Created: 17/Mar/07 07:22 PM   Updated: 25/Nov/08 11:16 AM
Return to search
Component/s: Languages, Questions
Affects Version/s: 1.7.1
Fix Version/s: 1.8, 1.9

Participants: Oleg Sychev and Tim Hunt
Security Level: None
QA Assignee: Tim Hunt
Resolved date: 17/Mar/07
Affected Branches: MOODLE_17_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
Modules can already do this.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Tim Hunt added a comment - 17/Mar/07 07:26 PM
The was fixed recently be changes in moodlelib.php/get_string and help.php.

Lang string should go into

question/type/xxx/lang/en_utf8/qtype_xxx.php

and help files into

with any help files in the

question/type/xxx/lang/en_utf8/help/xxx/ folder.


Oleg Sychev added a comment - 10/Nov/08 08:15 AM
Using question/type/xxx/lang/en_utf8/help/xxx/ folder isn't convenient since
a) there is no real need to have a subfolder there, it's may be as well question/type/xxx/lang/en_utf8/help
b) in language pack subfolder name must be qtype_xxx (help button near questiontype name on editing screen assumes that), so if we must have subfolder it probably should be qtype_xxx too to make further integration easier.

Tim Hunt added a comment - 10/Nov/08 11:48 AM
I know it is not an ideal naming convention, however, this convention is the same for all types of plugin, and it has been like that for years. Changing it now would break all the plugins out there for a very minor gain. I am afraid that you will just have to live with things the way they are.

Oleg Sychev added a comment - 11/Nov/08 06:26 AM
I really can't see why we should change naming convention and break anything. You can just add a new place to search instead, so the old code will be alright.

Tim Hunt added a comment - 11/Nov/08 01:08 PM
Because one extra place to search actually translates into a few extra places to search once you consider non-English languages, and accessing the disc is (relatively) slow. It is not difficult to live with things the way they are, so this is an unnecessary performance hit, so we won't do it.

Tim Hunt added a comment - 25/Nov/08 11:16 AM
This has been working for ages without complaint, so closing. (It just got into the QA list because of recent comments.)