Moodle

Multilang filter doesn't accept different attribute order

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8
  • Component/s: Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

When creating a new multilang string, only one attribute order is accepted by the regular expression in filter/multilang/filter.php:48 :

<span lang="en" class="multilang">Blah Blah</span>

If the order of attributes is changed, the string doesn't get filtered at all.

The task is to upgrade this regular expression so that the attributes (including any future additional attributes) can be entered by the course creator in any order.

Issue Links

Activity

Hide
Petr Škoda (skodak) added a comment -

This was a known problem

my+1 for fixing it

Show
Petr Škoda (skodak) added a comment - This was a known problem my+1 for fixing it
Hide
Martin Dougiamas added a comment -

How's it going then?

Show
Martin Dougiamas added a comment - How's it going then?
Hide
Petr Škoda (skodak) added a comment -

I did not find an elegant and fast regex yet

Show
Petr Škoda (skodak) added a comment - I did not find an elegant and fast regex yet
Hide
Petr Škoda (skodak) added a comment -

fixed in cvs, please test and reopen if needed, thanks!

Show
Petr Škoda (skodak) added a comment - fixed in cvs, please test and reopen if needed, thanks!
Hide
Nicolas Martignoni added a comment -

Closing as verified.

Show
Nicolas Martignoni added a comment - Closing as verified.

Dates

  • Created:
    Updated:
    Resolved: