Issue Details (XML | Word | Printable)

Key: MDL-8973
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Improve OOP model of new multi auth plugins

Created: 21/Mar/07 12:07 AM   Updated: 30/Apr/07 12:24 AM
Return to search
Component/s: Authentication
Affects Version/s: 1.8
Fix Version/s: 1.8

File Attachments: 1. Text File auth_oop_hooks.patch (56 kB)
2. Text File patchfile.txt (0.6 kB)
Issue Links:
Relates
 

Participants: Donal McMullan, Martin Dougiamas, Martín Langhoff and Petr Skoda
Security Level: None
Resolved date: 11/Apr/07
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE


 Description  « Hide
Fix OOP model of new multi auth plugins; add hooks for pre-login and pre-logout actions (needed for sso plugins)

patch ready: testing...

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 37 files to 'Moodle CVS' - 22/Mar/07 09:27 PM
(MDL-8973) Fix OOP model of new multi auth plugins + some other auth related fixes, fixed change_password, ldap updates, etc.; TODO: fix docs
MODIFY auth/email/auth.php   Rev. 1.10    (+17 -7 lines)
MODIFY login/signup_form.php   Rev. 1.26    (+77 -76 lines)
MODIFY login/change_password.php   Rev. 1.58    (+19 -26 lines)
MODIFY login/index.php   Rev. 1.115    (+27 -28 lines)
MODIFY login/logout.php   Rev. 1.21    (+9 -7 lines)
MODIFY login/signup.php   Rev. 1.55    (+3 -3 lines)
MODIFY login/change_password_form.php   Rev. 1.8    (+14 -46 lines)
MODIFY auth/db/auth.php   Rev. 1.16    (+4 -7 lines)
MODIFY auth/radius/auth.php   Rev. 1.5    (+4 -6 lines)
MODIFY auth/fc/auth.php   Rev. 1.3    (+33 -14 lines)
MODIFY admin/auth.php   Rev. 1.59    (+2 -2 lines)
MODIFY admin/auth_config.php   Rev. 1.8    (+1 -3 lines)
MODIFY user/view.php   Rev. 1.150    (+2 -2 lines)
MODIFY lib/db/Attic/mysql.php   Rev. 1.253    (+4 -3 lines)
MODIFY auth/none/auth.php   Rev. 1.9    (+4 -9 lines)
MODIFY auth/cas/auth.php   Rev. 1.6    (+15 -6 lines)
MODIFY blocks/login/block_login.php   Rev. 1.22    (+2 -2 lines)
MODIFY lib/accesslib.php   Rev. 1.249    (+5 -1 lines)
MODIFY user/edit.php   Rev. 1.158    (+10 -12 lines)
MODIFY lib/db/Attic/postgres7.php   Rev. 1.234    (+4 -3 lines)
MODIFY login/confirm.php   Rev. 1.27    (+4 -6 lines)
MODIFY auth/imap/auth.php   Rev. 1.5    (+4 -6 lines)
MODIFY user/editadvanced.php   Rev. 1.13    (+11 -17 lines)
DEL auth/Attic/authlib.php   Rev. 1.2    (+0 -0 lines)
MODIFY auth/mnet/auth.php   Rev. 1.18    (+14 -7 lines)
MODIFY auth/shibboleth/auth.php   Rev. 1.5    (+20 -6 lines)
MODIFY auth/nntp/auth.php   Rev. 1.5    (+4 -6 lines)
MODIFY auth/ldap/auth.php   Rev. 1.10    (+35 -21 lines)
MODIFY auth/pam/auth.php   Rev. 1.5    (+4 -6 lines)
MODIFY auth/pop3/auth.php   Rev. 1.5    (+4 -6 lines)
MODIFY auth/manual/auth.php   Rev. 1.8    (+4 -9 lines)
ADD lib/authlib.php   Rev. 1.1    (+0 -0 lines)
MODIFY login/forgot_password.php   Rev. 1.42    (+2 -2 lines)
MODIFY lib/moodlelib.php   Rev. 1.868    (+23 -53 lines)
MODIFY auth/nologin/auth.php   Rev. 1.3    (+4 -1 lines)
MODIFY lang/en_utf8/auth.php   Rev. 1.22    (+2 -1 lines)
MODIFY login/index_form.html   Rev. 1.50    (+7 -10 lines)
Petr Skoda committed 37 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 22/Mar/07 09:40 PM
(MDL-8973) Fix OOP model of new multi auth plugins + some other auth related fixes, fixed change_password, ldap updates, etc.; TODO: fix docs
backported from HEAD
MODIFY login/logout.php   Rev. 1.18.2.3    (+9 -7 lines)
MODIFY auth/cas/auth.php   Rev. 1.3.2.3    (+15 -6 lines)
MODIFY auth/manual/auth.php   Rev. 1.4.2.4    (+4 -9 lines)
MODIFY lib/db/Attic/mysql.php   Rev. 1.251.2.2    (+4 -3 lines)
MODIFY login/change_password.php   Rev. 1.54.2.4    (+19 -26 lines)
MODIFY blocks/login/block_login.php   Rev. 1.19.2.3    (+2 -2 lines)
MODIFY auth/pop3/auth.php   Rev. 1.2.2.3    (+4 -6 lines)
MODIFY auth/radius/auth.php   Rev. 1.2.2.3    (+4 -6 lines)
MODIFY auth/imap/auth.php   Rev. 1.2.2.3    (+4 -6 lines)
MODIFY auth/ldap/auth.php   Rev. 1.6.2.4    (+35 -21 lines)
MODIFY auth/mnet/auth.php   Rev. 1.14.2.4    (+14 -7 lines)
MODIFY admin/auth.php   Rev. 1.53.2.6    (+2 -2 lines)
MODIFY login/index_form.html   Rev. 1.48.2.2    (+7 -10 lines)
MODIFY auth/fc/auth.php   Rev. 1.1.2.2    (+33 -14 lines)
MODIFY login/change_password_form.php   Rev. 1.6.2.2    (+14 -46 lines)
MODIFY user/view.php   Rev. 1.143.2.7    (+2 -2 lines)
MODIFY auth/shibboleth/auth.php   Rev. 1.1.2.4    (+20 -6 lines)
DEL auth/Attic/authlib.php   Rev. 1.1.2.1    (+0 -0 lines)
MODIFY auth/nntp/auth.php   Rev. 1.2.2.3    (+4 -6 lines)
MODIFY lib/db/Attic/postgres7.php   Rev. 1.232.2.2    (+4 -3 lines)
MODIFY login/index.php   Rev. 1.109.2.6    (+27 -28 lines)
MODIFY auth/pam/auth.php   Rev. 1.2.2.3    (+4 -6 lines)
MODIFY user/edit.php   Rev. 1.152.2.5    (+10 -12 lines)
MODIFY user/editadvanced.php   Rev. 1.8.2.4    (+11 -17 lines)
MODIFY auth/nologin/auth.php   Rev. 1.1.2.4    (+4 -1 lines)
MODIFY login/signup.php   Rev. 1.52.2.3    (+3 -3 lines)
MODIFY lang/en_utf8/auth.php   Rev. 1.18.2.4    (+2 -1 lines)
MODIFY auth/none/auth.php   Rev. 1.4.2.5    (+4 -9 lines)
MODIFY auth/db/auth.php   Rev. 1.11.2.5    (+4 -7 lines)
MODIFY lib/moodlelib.php   Rev. 1.837.2.34    (+23 -53 lines)
MODIFY admin/auth_config.php   Rev. 1.6.2.2    (+1 -3 lines)
MODIFY lib/authlib.php   Rev. 1.1.2.2    (+281 -0 lines)
MODIFY auth/email/auth.php   Rev. 1.5.2.5    (+17 -7 lines)
MODIFY login/forgot_password.php   Rev. 1.38.2.4    (+2 -2 lines)
MODIFY login/signup_form.php   Rev. 1.23.2.3    (+77 -76 lines)
MODIFY login/confirm.php   Rev. 1.24.2.3    (+4 -6 lines)
MODIFY lib/accesslib.php   Rev. 1.221.2.27    (+5 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 22/Mar/07 10:11 PM
(MDL-8973) Fix OOP model of new multi auth plugins + some other auth related fixes, fixed change_password, ldap updates, etc.; TODO: fix docs
MODIFY fr_utf8/auth.php   Rev. 1.22    (+1 -0 lines)
Petr Skoda committed 3 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 22/Mar/07 10:28 PM
(MDL-8973) Fix OOP model of new multi auth plugins - updated docs
MODIFY lib/authlib.php   Rev. 1.1.2.3    (+32 -5 lines)
MODIFY auth/Attic/README   Rev. 1.9.2.2    (+21 -153 lines)
MODIFY auth/nologin/auth.php   Rev. 1.1.2.5    (+10 -22 lines)
Petr Skoda committed 3 files to 'Moodle CVS' - 22/Mar/07 10:31 PM
(MDL-8973) Fix OOP model of new multi auth plugins - updated docs; merged from MOODLE_18_STABLE
MODIFY auth/Attic/README   Rev. 1.11    (+21 -153 lines)
MODIFY auth/nologin/auth.php   Rev. 1.4    (+10 -22 lines)
MODIFY lib/authlib.php   Rev. 1.2    (+32 -5 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 22/Mar/07 10:31 PM
(MDL-8973) Fix OOP model of new multi auth plugins - updated docs
DEL auth/Attic/README2   Rev. 1.1.2.2    (+0 -0 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 22/Mar/07 10:32 PM
(MDL-8973) Fix OOP model of new multi auth plugins - updated docs; merged from MOODLE_18_STABLE
DEL auth/Attic/README2   Rev. 1.3    (+0 -0 lines)
Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 23/Mar/07 06:45 AM
Translated a new string for auth MDL-8973.
MODIFY ja_utf8/auth.php   Rev. 1.34    (+2 -1 lines)
MODIFY ja_utf8/README   Rev. 1.362    (+1 -1 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 23/Mar/07 08:26 PM
MDL-8973 improved auth plugin docs
MODIFY auth/Attic/README   Rev. 1.9.2.3    (+9 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 23/Mar/07 08:28 PM
MDL-8973 improved auth plugin docs; merged from MOODLE_18_STABLE
MODIFY auth/Attic/README   Rev. 1.12    (+9 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 27/Mar/07 03:27 AM
MDL-8973 fixed typo in signup form validation
MODIFY login/signup_form.php   Rev. 1.23.2.4    (+2 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 27/Mar/07 03:28 AM
MDL-8973 fixed typo in signup form validation; merged from MOODLE_18_STABLE
MODIFY login/signup_form.php   Rev. 1.27    (+2 -2 lines)
Petr Skoda committed 9 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 28/Mar/07 04:26 PM
MDL-8973 auth hooks final cleanup
MODIFY sso/README.txt   Rev. 1.1.2.1    (+2 -0 lines)
MODIFY lib/moodlelib.php   Rev. 1.837.2.39    (+23 -15 lines)
MODIFY login/logout.php   Rev. 1.18.2.6    (+2 -2 lines)
MODIFY auth/mnet/auth.php   Rev. 1.14.2.5    (+6 -2 lines)
MODIFY auth/shibboleth/auth.php   Rev. 1.1.2.5    (+1 -1 lines)
MODIFY auth/Attic/README   Rev. 1.9.2.4    (+1 -2 lines)
MODIFY lib/authlib.php   Rev. 1.1.2.4    (+28 -16 lines)
MODIFY auth/cas/auth.php   Rev. 1.3.2.4    (+6 -1 lines)
MODIFY login/index.php   Rev. 1.109.2.10    (+2 -2 lines)
Petr Skoda committed 9 files to 'Moodle CVS' - 28/Mar/07 04:28 PM
MDL-8973 auth hooks final cleanup; merged from MOODLE_18_STABLE
MODIFY auth/shibboleth/auth.php   Rev. 1.6    (+1 -1 lines)
MODIFY lib/authlib.php   Rev. 1.3    (+28 -16 lines)
MODIFY auth/mnet/auth.php   Rev. 1.19    (+6 -2 lines)
MODIFY login/index.php   Rev. 1.119    (+2 -2 lines)
MODIFY sso/README.txt   Rev. 1.2    (+2 -0 lines)
MODIFY auth/Attic/README   Rev. 1.13    (+1 -2 lines)
MODIFY login/logout.php   Rev. 1.24    (+2 -2 lines)
MODIFY lib/moodlelib.php   Rev. 1.873    (+23 -15 lines)
MODIFY auth/cas/auth.php   Rev. 1.7    (+6 -1 lines)
donal72 committed 1 file to 'Moodle CVS' - 29/Apr/07 11:01 PM
MDL-8973 : Update to the require_logout function to ensure that the user's auth plugin is the first (& only) one to have its prelogout_hook invoked.
MODIFY lib/moodlelib.php   Rev. 1.895    (+15 -7 lines)
donal72 committed 1 file to 'Moodle CVS' - 29/Apr/07 11:08 PM
Typo in previous commit: MDL-8973 : Update to the require_logout function
MODIFY lib/moodlelib.php   Rev. 1.896    (+3 -3 lines)
donal72 committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 29/Apr/07 11:09 PM
MDL-8973 : Update to the require_logout function to ensure that the user's auth plugin is the first (& only) one to have its prelogout_hook invoked.
MODIFY lib/moodlelib.php   Rev. 1.837.2.55    (+15 -7 lines)
donal72 committed 1 file to 'Moodle CVS' - 30/Apr/07 11:14 AM
MDL-8973 : Undo API change in previous commit
MODIFY lib/moodlelib.php   Rev. 1.897    (+6 -6 lines)
donal72 committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 30/Apr/07 11:19 AM
MDL-8973 : Undo API change in previous commit
MODIFY lib/moodlelib.php   Rev. 1.837.2.56    (+6 -6 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators