Moodle

From Martin Dougiamas (martin at moodle.com) Friday, 11 July 2003, 04:46 PM:

Moving this out to version 2.0 ... fits with the whole resource management rethink.

Is this, and WebDAV support in general, still on track for 2.0?

We have a good patch, as seen in this thread http://moodle.org/mod/forum/discuss.php?d=89123

The plan is as follows:

• Merge into 1.9 the bits needed to support WebDAV, but not the /webdav directory which implements the feature (perhaps this should be delayed until 1.9.1)

• Merge into HEAD all of it

This is the patch for 1.9 on top of the patches merged today.

Here is a cleaner patch. With the parts I already landed in 19_STABLE and HEAD out of the way, and MD putting the locks table in lib/db, this is what we'll land in HEAD.

please use xmldb editor to produce valid install.xml - it broke install, going to fix it now

another blocker - we must include our pear libs first because we rely on specific version of quickforms

pear include fixed in cvs

Petr

• sorry about the install.xml breakage! - I did generate them with XMLDB, but it may have gotten broken along the way (ah! I see, I changed the field name by hand!)
• PEAR inclusion order - sorry again! - probably depends on having (or not) local PEAR libs – I have been using/testing this for awhile, and I didn't see any forms break.

Thanks for the fixes!

Martín,

Have you packaged up your 1.9-compatible 'drop-in' webdav folder anywhere?

Here is a patch which I think is what is required for applying straight onto 1.9

just tried the patch on 1.9.1+ from CVS and got an error saying that /lib/pear/console/getopt.php already existed. I chose no for using -R and then said apply anyway. Seems to have installed cleanly otherwise and the settings came up when I went to the notifications page.

However, when I go to http://mymoodle.com/webdav/moodledata-server.php in firefox, I just get a blank page and I also the same in konqueror. Debug is set to max, but still no error.

Does this mean its broken or have I missed something?

Trying webdav://mymoodle.com/webdav/moodledata-server.php in konqueror gives me a 'does not exist' error, even though the file is clearly present.

oops, it was magic_quotes_gpc set to on. works fine now!

Cool, for others info, you must check your apache error log to find errors, since inline errors are not supported

Hi everyone,

please take apologise for my question but could you please confirm that this patch works with windows Moodle (1.9+) and if could you please advise how to implement it?

Many thanks in advance
Wojciech

Hi,

I've tried to apply the patch using git on windows, but get some complaints about trailing whitespaces, and then errors stating 'patch does not apply'. (for serve.php, index.php, admin.php, moodlelib.php and then that Getopt.php already exists.

Is it possible to get a fresh patch based off of catalyst's repo? (I am assuming the problem is that there have been changes to these files since the patch was created?)

Lael

Here's a patch which adds proper access control to the PROPFIND method.

We found that people using a DAV client were able to manually type in the course ID of a course they do not teach, and were able to view the files (but not read or modify them).

Thanks