[#MDL-9021] View of html resource not adds in log in certain conditions - Moodle Tracker

Affected Branches:
MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
Fixed Branches:
MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE

I talk about the display function in the resource_html class definition ( mod/resource/type/html/resource.class.php )

I think it miss a call of the add_to_log function when $resource->popup is true and $inpopup is false.

In any case I think that this function must be call one time, before the first "if" and why not, in the parent::display function ,

Are you agree ?

This issue has a clone:
MDL-15387	HTML resource page views are not logged when blocks are showing

Ascending order - Click to sort in descending order

Hide

Permalink

Martin Dougiamas added a comment - 30/Mar/07 9:54 AM

Out to Yu on the wing

Show

Martin Dougiamas added a comment - 30/Mar/07 9:54 AM Out to Yu on the wing

Hide

Permalink

Yu Zhang added a comment - 30/Mar/07 4:04 PM

Hi, moved the add_to_log call out of the if() clause. Should work now, cheers.

Show

Yu Zhang added a comment - 30/Mar/07 4:04 PM Hi, moved the add_to_log call out of the if() clause. Should work now, cheers.

Vote (0)

Watch (1)