-Students doesn't see their group events.
-Teachers can see all the events (only if the teacher is not in the group). I think they should see their groups events.

After having look at code, there seems to be typo in the routine,
groups_get_all_groups_for_user(), defined in group/lib/basicgrouplib.php.

I attached the patch for this issue even though I am not sure if this is right way or not (at least, the code seems to be different from what comment of routine says).

I'm seeing a similar issue: when a teacher creates an event for a group, it does not show up in the calendar. No one can see it – not teachers, not students and not even admins. Looking in the database, I can see my events in mdl_events and they do have a groupid associated with them.

Course created, teacher assigned, student assigned, group created and student placed in group.

I login as admin, I add a group event in a course.

• As admin, I cannot see group event.
• As admin, switching to role "teacher", I CAN see group event.
• As admin, switching to role "student", I cannot see group event.
• As teacher, I can see the group event that admin added to the course.

I login as teacher, I add a group event in a course.

• As teacher, I can see group event
• As teacher, switching to role "non-editing teacher", I can see the group event
• As teacher, switching to role "student", I cannot see the group event

I login as student, I cannot see the group event.

> I tried the patch, but it had no effect on this problem.

Could you let me know the version written in version.php?

I am afraid that your moodle code does not include the fix which should be applied before applying my patch.

I upgraded to 1.8.1_STABLE yesterday and tried this patch. Here's what I'm seeing:

• Login as a teacher or admin
• Add a group event
• The event is visible to students in the group.
• The event is not visible to the teacher or admin.

Admins do see the group events if the calendar setting 'Admins See All' is checked (Administration->Appearance->Calendar).

I have a test user who is a Course Creator in Course A, and a Teacher in Course B.

• Logged in as the test user, I created a group event in Course A.
• From within Course A, I hover over the date and do not see the event.
• I click on the date to bring up the day view for Course A and do not see the event
• I select All courses from the day view drop-down, and the group event created in Course A appears.
• From the front page, or from Course B, I hover over the date and the group event created in Course A appears.
• Group events created by the teacher in Course B are not visible to this user anywhere.

It doesn't seem to matter how I set up the course. I get the same results for each possible setting: course settings with no group mode set, no force but separate, no force but visible, forced separate, forced visible.

Teacher sees both events, student 1 sees no events, student 2 sees no events, admin does not see shading on calendar or link in upcoming events, but DOES see the events if clicking on the calendar link to go to the daily view.

I actually logged out and in as each role to verify (no switching).

That bit about what the admin can see is a little different. Did anyone else actually click on the "go to calendar" link to verify events displayed there?

I am using default role definitions.

I'm at Groups version 2007012400 running Moodle 1.8.1 (2007021510). If it matters, this site was created using Moodle 1.7.0 and our upgrade path was Moodle 1.7.0->Moodle 1.7.1->Moodle 1.8.0->Moodle 1.8.1.

Here's the results of my most recent run through:

Create a new course with group mode set to "separate".

Login as faculty test account to new course.

Create Group A, which consists of Joe
Create Group B, which consists of Jill

Assign Joe to Group A
Assign Jill to Group B.

Create an event for Group A taking place on 6/29 with no duration.
Create an event for Group B taking place on 6/30 with no duration.

Teacher can not see either event.

Login as Joe. Joe can see Group A event created by the teacher.
Login as Jill. Jill can see Group B events create by the teacher.

Login as site admin. Admin can not see any group events.
Login as myself (also with admin rights). Still can't see any group events.
Create an event for Group A, also on June 30 in my admin role. I can't see the event.

Login as Joe. Joe can see the event.

Login as Teacher. Teacher can't see the event; downshifting to the non-editing teacher or student roles doesn't show the events. If I change the group type to "visible" and try downshifting to student again, I still can't see the events.

Your code seems not to be old and enough new. The bug might be brought into newer code that you use. I try newest code (I do not actually use the newest code now).

After applying my two patches, group events are visible to members of students and teachers.

BTW, if and only if 'group mode' is set to 'no' and 'force' is set to 'no', students and teachers cannot see event according to the code. I am not sure the reason though.

In adittion, when 'adminseesall' is checked, admin can see all group events even in upcomming event in my environment (today's 1.8+). Speaking of editing the event, admin seems to be able to edit all events anytime according to the code.

See this query?

$sql = "SELECT id, groupid FROM {$CFG->prefix}groups_courses_groups WHERE courseid IN (".implode(',', $groupids).')';

This produces something like this:

SELECT id, groupid FROM mdl_groups_courses_groups WHERE courseid IN (740);

Which returns results that look like this:

-----------+

-----------+

-----------+

The 'id' here refers to the primary key for the "mdl_groups_courses_groups" table; the groupid is the primary key for the "mdl_groups" table

Now if you look for this code from the calendar-lib.php.patch, around line 1196, you'll see the problem.

foreach ($grouprecords as $grouprecord) {
array_push($grouparray, $grouprecord->id);
}

$grouprecord->id is referring to the primary key of the "mdl_groups_courses_groups" table NOT the actual id of the group, which is what's in the second column of the data returned.

If we change "$grouprecord->id" to "$grouprecord->groupid", then we pull the right value from the data that was returned.

This allows faculty to see the groups available in their courses. When I made this change, the events were displayed correctly on the courses page and on the calendar page.

The original code has the same problem, but in a different way:

$grouparray = array_merge($grouparray, array_keys($grouprecords))

This takes the keys of the array returned from the initial query, which are the same as the keys for the table "mdl_groups_courses_groups", but NOT the same as the actual groupid numbers in "mdl_groups".

You are right and sorry the patch file was different from my own patch file in my PC...
my calendar-lib.php.patch is wrong and I attached correct one to this.

BTW, I write down what I notice:

• basicgrouplib.php.patch works well for a little bit old 1.8+ (even though the patch seems to still fix group bug of current 1.8+).
• calendar-lib.php.patch-20070628 works well for current 1.8+ (2007/06/17 or later maybe)

Sorry for my confusing you.

Admin:
Role Capabilities: Manage Own and Manage Any calendar entries are set to Allow.

• Can add User event fine
• Can try to add"Course event, but it will not show up on the calendar
• Can add Site event fine

Teacher:
Role Capabilities: Manage Own and Manage Any calendar entries are set to Allow.

• Can add User event fine
• Selection for Group events is there, and they can try to add events. But they will not appear on the Calendar.
• Can add Course event fine

It's reproducible too on original 1.8!

Seems same symptoms like on HEAD before your fix.

Version 1.8.2+ (2007021520)

Hi Nicholas and Roger, I was unable to reproduce the problem of teachers unable to post, I can add group events as teacher. Could you please post more info on this? Do you get error messages? Can you post a screenshot? The fix on 1.9 is totally unrelated to this, the fix on 1.9 was on perf patch.

Cheers,

Yu

I just installed a fresh 1.8.3 and made some tests. Here are the results, following A.T.Wyatt protocol (see above):

Course created, teacher assigned, student assigned, 2 groups created and student placed in group 1, teacher in group 2.

I login as admin, I add group events in a course, in multiple groups.

• As admin, I CAN see group events in the calendar view, but NOT in the calendar and Upcoming Events blocks.
• As admin, switching to role "teacher", I CAN see group events in the calendar view, but NOT in the calendar
  and Upcoming Events blocks.
• As admin, switching to role "student", I CANNOT see group events at all.

I login as teacher.

• As teacher, I can see the group events that admin added to the course, in the calendar view AND in
  the calendar and upcoming events blocks.
• As teacher, I add group events in a course (both groups) and see them everywhere.
• As teacher, switching to role "non-editing teacher", I can see all the group events everywhere.
• As teacher, switching to role "student", I can see all my group events everywhere.

I login as student, I can see all my group events everywhere.

Summary
=======

The remaining problem in 1.8.3 are the lacking view in the blocks for the admin and switching roles.

I've have a similar problem. Perhaps it's related or perhaps its another issue with calendar. A teacher was seeing group events from groups she was not member of. And group events that she should be able to see were not appearing.

Problem is in function calendar_set_filters() at calendar/lib.php. Look at the query:

$sql = "SELECT id, groupid
FROM {$CFG->prefix}groups_courses_groups
WHERE courseid IN (".implode(',', $groupids).')';

and change the order of the fields in the SELECT line:

$sql = "SELECT groupid, id
FROM {$CFG->prefix}groups_courses_groups
WHERE courseid IN (".implode(',', $groupids).')';

The $grouparray variable was not filled with groupids. That was our problem... hope this helps.

Juan, I am not able to duplicate this problem, I see correct groups for my users. Could you please describe how to reproduce the problem in greater detail? I think using the ids of groups_courses_groups in 1.8 is correct.

Cheers,

Yu

Sorry for the noisy comment

Kenneth guess it before Both his or our patch solves the problem we described.

Sorry if i misunderstud something, but there are lots of comments now :-P

Thanks for your work Yu

The blocks problem is fixed in 1.8.3+. I have yet to test it in 1.9beta2.

The problem is still present

Cheers,

Yu

Should I close this bug and open another one?

Ciao
Nicolas

Cheers,

Yu

Thank you