Issue Details (XML | Word | Printable)

Key: MDL-9076
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: Howard Miller
Votes: 1
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Overall Feedback "add 3 fields" button outside of box

Created: 27/Mar/07 09:36 PM   Updated: 09/Oct/07 11:44 PM
Return to search
Component/s: Quiz
Affects Version/s: 1.8
Fix Version/s: 1.8.3, 1.9

File Attachments: None
Image Attachments:

1. Picture 2.png
(28 kB)

Participants: Howard Miller, Jamie Pratt and Tim Hunt
Security Level: None
Resolved date: 09/Oct/07
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
The button marked "add 3 fields to form" is outside of the box that encompasses the form it is referring to. This might be confusing.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Tim Hunt added a comment - 30/Mar/07 07:21 AM
Jamie, is this easy to do with formslib?

[ Permalink | « Hide ]
Jamie Pratt added a comment - 30/Mar/07 02:44 PM
This is not so easy to do although it would be possible to add a parameter to the repeat elements method to optionally not close the fieldset before the add button. What about just giving the button a more helpful label?

tjhunt committed 3 files to 'Moodle CVS' - 09/Oct/07 11:44 PM
MDL-9076 - Move the 'Add 3 more overall feedbacks' button inside that group of elements on the quiz settings form.

To make this possible, I added an extra argument to the repeat_elements method, which other people may find helpful on other forms.
MODIFY lib/formslib.php   Rev. 1.129    (+8 -4 lines)
MODIFY mod/quiz/mod_form.php   Rev. 1.28    (+3 -2 lines)
MODIFY lang/en_utf8/quiz.php   Rev. 1.83    (+2 -1 lines)
Tim Hunt made changes - 09/Oct/07 11:44 PM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Fix Version/s 1.8.3 [ 10230 ]
Fix Version/s 1.9 [ 10190 ]
tjhunt committed 3 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 09/Oct/07 11:45 PM
MDL-9076 - Move the 'Add 3 more overall feedbacks' button inside that group of elements on the quiz settings form.

To make this possible, I added an extra argument to the repeat_elements method, which other people may find helpful on other forms.

backported from HEAD.
MODIFY lib/formslib.php   Rev. 1.96.2.11    (+8 -4 lines)
MODIFY lang/en_utf8/quiz.php   Rev. 1.57.2.14    (+2 -1 lines)
MODIFY mod/quiz/mod_form.php   Rev. 1.11.2.10    (+3 -2 lines)
Mitsuhiro Yoshida committed 6 files to 'Lang CVS' - 10/Oct/07 01:36 AM
Translated new strings for category related MDL-11543.
Translated new strings for quiz MDL-11617 MDL-9076.
Adding a new translated help file for quiz MDL-11617.
Updated a translated help file for quiz MDL-11617.
MODIFY ja_utf8/moodle.php   Rev. 1.245    (+5 -2 lines)
MODIFY ja_utf8/quiz.php   Rev. 1.126    (+4 -2 lines)
MODIFY ja_utf8/README   Rev. 1.537    (+1 -1 lines)
MODIFY ja_utf8/help/quiz/review2.html   Rev. 1.7    (+3 -1 lines)
MODIFY ja_utf8/help/glossary/displayformat.html   Rev. 1.8    (+2 -0 lines)
ADD ja_utf8/help/quiz/reviewoptions.html   Rev. 1.1    (+0 -0 lines)
martignoni committed 1 file to 'Lang CVS' - 10/Oct/07 03:16 AM
MDL-9076 - Move the 'Add 3 more overall feedbacks' button inside that group of elements on the quiz settings form.
MODIFY fr_utf8/quiz.php   Rev. 1.86    (+2 -1 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators