Issue Details (XML | Word | Printable)

Key: MDL-9077
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Piers Harding
Reporter: Peter Chamberlin
Votes: 6
Watchers: 5
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

SCORM Package Import Failure

Created: 27/Mar/07 10:18 PM   Updated: 28/Jul/08 05:27 AM
Return to search
Component/s: Forms Library, SCORM
Affects Version/s: 1.8
Fix Version/s: 1.8.7, 1.9.3, 2.0

File Attachments: 1. Text File MDL-9077-head.patch (1 kB)
2. Text File MDL-9077-moodle18.patch (1 kB)
3. Text File MDL-9077-moodle18.patch (1 kB)

Environment: Windows XP SP2, MySQL, Apache, IE7 (and Firefox)
Issue Links:
Duplicate
 
Relates
 

Database: MySQL
Participants: CommLab India, Dan Marsden, Jamie Pratt, Jose Martin, Martin Dougiamas, Peter Chamberlin, Piers Harding and Roberto Pinna
Security Level: None
QA Assignee: Dan Marsden
Resolved date: 24/Jul/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
If I install Moodle 1.8 Windows complete package, let the database install and complete first setup, then rename the moodle folder to moodle-1.7 and extract the latest moodle-1.8 generic build in its place, then go to the /admin/ page and authenticate as administrator to apply the database table changes, then create a new course in the Miscellaneous group, then automatically get prompted to Add an AICC/SCORM package, then choose to upload the package as uploaded to http://www.peterchamberlin.dsl.pipex.com/M2775101-2004.zip, then provide a title and description for it and then click the Save Changes button then...

I get the following JavaScript error to begin with:

Line: 189
Char: 3
Error: 'parentNode' is null or not an object
Code: 0
URL: http://ws806/course/modedit.php?add=scorm&type=&course=2&section=0&return=0

This is caused by:
function validate_mod_scorm_mod_form_reference(element) {
var frm = element.parentNode; // This line

Which is called by:
ret = validate_mod_scorm_mod_form_reference(frm.elements['reference']) && ret

Which fails because there's no such element "reference"

Getting past this error then results in a pause while the package is extracted and made ready to be added to the course and then I receive an empty HTML page and no error message. If I wipe down the filename and go to the /course/ folder then I see that the package has not been added and it goes through the auto-add process again. I see that the package files have been extracted to course folder "2" but in the \moodledata\2\moddata\scorm\KdkWOQVF\ folder I see some of the extracted files and the package .zip file - but in checking what's been extracting I see that the operation stopped before file \M2775101\help\help\measureDCVoltage_images\MeasureDCVoltage_04.jpg was in place. On repeating this entire process in Firefox I note that the extraction stops around the same place, but not on the exact file. Firefox also raises a JavaScript error and receives an empty page in response to the Save Changes form submission.

This seems like a pretty major fault to have in a 1.8 version that's being "polished". It seems to be package specific as most of my generated content files, and some from other vendors, goes wrong in a similar manor. Others work fine. Our package is SCORM 2004 3rd Edition conformant.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
moodler committed 1 file to 'Moodle CVS' - 06/Jun/07 05:19 PM
Merged fix for MDL-9077 and MDL-9557
MODIFY mod/scorm/locallib.php   Rev. 1.43    (+6 -7 lines)
Piers Harding committed 1 file to 'Moodle CVS' - 23/Jul/08 08:32 AM
MDL-9077 switch from client to server side validation for reference field as client side not supported for this type (file upload name).
MODIFY mod/scorm/mod_form.php   Rev. 1.13    (+1 -1 lines)
Piers Harding committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 24/Jul/08 09:40 AM
MDL-9077 switch from client to server side validation for reference field as client side not supported for this type (file upload name) - propogate to 1.9.
MODIFY mod/scorm/mod_form.php   Rev. 1.11.2.2    (+1 -1 lines)
Piers Harding committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 24/Jul/08 09:44 AM
MDL-9077 switch from client to server side validation for reference field as client side not supported for this type (file upload name) - propogate to 1.8.
MODIFY mod/scorm/mod_form.php   Rev. 1.2.2.5    (+1 -1 lines)