Issue Details (XML | Word | Printable)

Key: MDL-9137
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Martin Dougiamas
Reporter: Martin Dougiamas
Votes: 3
Watchers: 6
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

META: Rewrite the entire Gradebook system in Moodle 1.9

Created: 31/Mar/07 01:46 PM   Updated: 12/Oct/07 02:10 PM
Component/s: Gradebook
Affects Version/s: 1.9
Fix Version/s: 1.9

File Attachments: 1. Text File grades_impr1.patch (112 kB)
Issue Links:
Blockers
 

Participants: Hui Chun Kit, Martin Dougiamas, Nicolas Connault and Petr Skoda (frankenstein)
Security Level: None
Resolved date: 10/Oct/07
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE

Sub-Tasks:   All   Open   
 Sub-Task Progress: 
1.
 Create core tables for storing grades Sub-task Closed Closed Yu Zhang  
2.
 Write core API functions lib/gradelib.php and unit tests Sub-task Resolved Resolved Nicolas Connault  
3.
 Write core classes and functionality for managing grades Sub-task Resolved Resolved Nicolas Connault  
4.
 Implement main handler for grade changes Sub-task Resolved Resolved Martin Dougiamas  
5.
 Define plugin directory structure for grade-related plugins Sub-task Resolved Resolved Martin Dougiamas  
6.
 Cron job for support of legacy grade functions in modules Sub-task Resolved Resolved Yu Zhang  
7.
 Add new core capabilities for grades permissions Sub-task Closed Closed Petr Skoda (frankenstein)  
8.
 Add support for all grades-based plugins for db, cron event, access.php, events.php etc Sub-task Closed Closed Yu Zhang  
9.
 Include grade tables in course backup/restore Sub-task Closed Closed Yu Zhang  
10.
 Implement calls of grade_update() function in all major modules Sub-task Resolved Resolved Petr Skoda (frankenstein)  
11.
 Implement grade_updated event handler in all modules that allow manual setting of grades Sub-task Resolved Resolved Petr Skoda (frankenstein)  
12.
 Implement standard grades report for graders Sub-task Closed Closed Martin Dougiamas  
13.
 Implement standard grades report for users Sub-task Resolved Resolved Yu Zhang  
14.
 Implement standard exports (like 1.8) Sub-task Closed Closed Yu Zhang  
15.
 Implement new XML export (OU format) Sub-task Closed Closed Yu Zhang  
16.
 Implement CSV import Sub-task Closed Closed Petr Skoda (frankenstein)  
17.
 Implement parser with standard spreadsheet syntax Sub-task Resolved Resolved Petr Skoda (frankenstein)  
18.
 Implement function to detect circular references Sub-task Resolved Resolved Petr Skoda (frankenstein)  
19.
 Implement upgrade code for pre-1.9 sites Sub-task Closed Closed Petr Skoda (frankenstein)  
20.
 Remove old gradebook UI Sub-task Resolved Resolved Petr Skoda (frankenstein)  
21.
 Implement basic support for outcomes Sub-task Resolved Resolved Martin Dougiamas  
22.
 Implement item exclude from aggregation support Sub-task Resolved Resolved Petr Skoda (frankenstein)  
23.
 Implement capability checks in grade import/export/report/edit pages Sub-task Resolved Resolved Petr Skoda (frankenstein)  
24.
 Create test data Sub-task Resolved Resolved Nicolas Connault  
25.
 cleanup scales code Sub-task Resolved Resolved Petr Skoda (frankenstein)  
26.
 add delete of grade data when deleting module or course Sub-task Resolved Resolved Petr Skoda (frankenstein)  
27.
 Extend import plugins to support web access Sub-task Resolved Resolved Petr Skoda (frankenstein)  
28.
 Extend export plugins to support web access - link Sub-task Resolved Resolved Nicolas Connault  
29.
 do not use events for changed raw grades Sub-task Resolved Resolved Petr Skoda (frankenstein)  
30.
 add aggregation inside all subcategories + add graded/all aggregation option Sub-task Resolved Resolved Petr Skoda (frankenstein)  

 Description  « Hide
We are going to completely rebuild the gradebook from the ground up, according to the spec at:

http://docs.moodle.org/en/Development:Grades

All 1.9 gradebook bugs and subtasks should be linked to this issue.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Nicolas Connault added a comment - 28/May/07 10:10 AM
Applied most of Petr's patch related to gradebook objects. Only thing I didn't merge in was related to the assumption that grade_raw objects have their scaleid and scale object already set up by the grade_handler function. All unit tests pass without problem.

Thanks Petr!


[ Permalink | « Hide ]
Petr Skoda (frankenstein) added a comment - 29/May/07 07:01 AM
new patch attached, removing the original one that is already in cvs

[ Permalink | « Hide ]
Petr Skoda (frankenstein) added a comment - 18/Jun/07 04:33 AM
attaching new patch that should solve multiple issues:
1/ initial support for migration of old grade_items and categories (not tested)
2/ rewritten grade update and calculation login
3/ initial support for calculation
4/ minor API refactoring and cleanup
5/ various small bugfixes
6/ fixed use of grademax with scales
7/ fixed some unit tests

TODO:

  • implement proper locking of grades - needs discussion
  • force recalculation of all formulas after adding/removing/changing of grade items
  • better delete support - needs discussion
  • support for NULLs n backup - Eloy already proposed a solution
  • support for NULLs in set_field()
  • speedup
  • more unit tests nd functional tests

Please review (or even commit if ok)


[ Permalink | « Hide ]
Hui Chun Kit added a comment - 22/Jun/07 05:13 PM
Dear all,

Would it be possible to rewrite the UI code for the gradebook as well. I wonder if we can use the table form (like the one used in user module) to display the grades so as to make it easier to track and follow.

Besides, would it be possible to let users choose which user fields (or even user profile fields) will be displayed/exported ? This will be a very nice feature.

If there are anything I can help, I will do it.

Cheers,
Jacky Hui
Hong Kong


[ Permalink | « Hide ]
Martin Dougiamas added a comment - 10/Oct/07 02:30 PM
Yay, great job all!


Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators