Moodle

META: Rewrite the entire Gradebook system in Moodle 1.9

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

We are going to completely rebuild the gradebook from the ground up, according to the spec at:

http://docs.moodle.org/en/Development:Grades

All 1.9 gradebook bugs and subtasks should be linked to this issue.

Issue Links

This issue is blocked by:
MDL-11509 New gradebook backup/restore problems - meta Critical Closed
MDL-11573 META: New gradebook bugs reported by OU Major Closed
MDL-9628 META: Implement standard grades report for graders Critical Closed
MDL-10541 META: Develop core classes to handle and manage grades Critical Closed
MDL-10544 META: Implement basic outcomes support Major Closed
MDL-9501 META: Implement Event API Blocker Closed
Progress
Resolved Sub-Tasks

Sub-Tasks

1.
 Create core tables for storing grades Sub-task Closed Closed Yu Zhang
 
2.
 Write core API functions lib/gradelib.php and unit tests Sub-task Closed Closed Nicolas Connault
 
3.
 Write core classes and functionality for managing grades Sub-task Closed Closed Nicolas Connault
 
4.
 Implement main handler for grade changes Sub-task Closed Closed Martin Dougiamas
 
5.
 Define plugin directory structure for grade-related plugins Sub-task Closed Closed Martin Dougiamas
 
6.
 Cron job for support of legacy grade functions in modules Sub-task Closed Closed Yu Zhang
 
7.
 Add new core capabilities for grades permissions Sub-task Closed Closed Petr Škoda (skodak)
 
8.
 Add support for all grades-based plugins for db, cron event, access.php, events.php etc Sub-task Closed Closed Yu Zhang
 
9.
 Include grade tables in course backup/restore Sub-task Closed Closed Yu Zhang
 
10.
 Implement calls of grade_update() function in all major modules Sub-task Closed Closed Petr Škoda (skodak)
 
11.
 Implement grade_updated event handler in all modules that allow manual setting of grades Sub-task Closed Closed Petr Škoda (skodak)
 
12.
 Implement standard grades report for graders Sub-task Closed Closed Martin Dougiamas
 
13.
 Implement standard grades report for users Sub-task Closed Closed Yu Zhang
 
14.
 Implement standard exports (like 1.8) Sub-task Closed Closed Yu Zhang
 
15.
 Implement new XML export (OU format) Sub-task Closed Closed Yu Zhang
 
16.
 Implement CSV import Sub-task Closed Closed Petr Škoda (skodak)
 
17.
 Implement parser with standard spreadsheet syntax Sub-task Closed Closed Petr Škoda (skodak)
 
18.
 Implement function to detect circular references Sub-task Closed Closed Petr Škoda (skodak)
 
19.
 Implement upgrade code for pre-1.9 sites Sub-task Closed Closed Petr Škoda (skodak)
 
20.
 Remove old gradebook UI Sub-task Closed Closed Petr Škoda (skodak)
 
21.
 Implement basic support for outcomes Sub-task Closed Closed Martin Dougiamas
 
22.
 Implement item exclude from aggregation support Sub-task Closed Closed Petr Škoda (skodak)
 
23.
 Implement capability checks in grade import/export/report/edit pages Sub-task Closed Closed Petr Škoda (skodak)
 
24.
 Create test data Sub-task Closed Closed Nicolas Connault
 
25.
 cleanup scales code Sub-task Closed Closed Petr Škoda (skodak)
 
26.
 add delete of grade data when deleting module or course Sub-task Closed Closed Petr Škoda (skodak)
 
27.
 Extend import plugins to support web access Sub-task Closed Closed Petr Škoda (skodak)
 
28.
 Extend export plugins to support web access - link Sub-task Closed Closed Nicolas Connault
 
29.
 do not use events for changed raw grades Sub-task Closed Closed Petr Škoda (skodak)
 
30.
 add aggregation inside all subcategories + add graded/all aggregation option Sub-task Closed Closed Petr Škoda (skodak)
 

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Nicolas Connault added a comment -

Applied most of Petr's patch related to gradebook objects. Only thing I didn't merge in was related to the assumption that grade_raw objects have their scaleid and scale object already set up by the grade_handler function. All unit tests pass without problem.

Thanks Petr!

Show
Nicolas Connault added a comment - Applied most of Petr's patch related to gradebook objects. Only thing I didn't merge in was related to the assumption that grade_raw objects have their scaleid and scale object already set up by the grade_handler function. All unit tests pass without problem. Thanks Petr!
Hide
Permalink
Petr Škoda (skodak) added a comment -

new patch attached, removing the original one that is already in cvs

Show
Petr Škoda (skodak) added a comment - new patch attached, removing the original one that is already in cvs
Hide
Permalink
Petr Škoda (skodak) added a comment -

attaching new patch that should solve multiple issues:
1/ initial support for migration of old grade_items and categories (not tested)
2/ rewritten grade update and calculation login
3/ initial support for calculation
4/ minor API refactoring and cleanup
5/ various small bugfixes
6/ fixed use of grademax with scales
7/ fixed some unit tests

TODO:

  • implement proper locking of grades - needs discussion
  • force recalculation of all formulas after adding/removing/changing of grade items
  • better delete support - needs discussion
  • support for NULLs n backup - Eloy already proposed a solution
  • support for NULLs in set_field()
  • speedup
  • more unit tests nd functional tests

Please review (or even commit if ok)

Show
Petr Škoda (skodak) added a comment - attaching new patch that should solve multiple issues: 1/ initial support for migration of old grade_items and categories (not tested) 2/ rewritten grade update and calculation login 3/ initial support for calculation 4/ minor API refactoring and cleanup 5/ various small bugfixes 6/ fixed use of grademax with scales 7/ fixed some unit tests TODO:
  • implement proper locking of grades - needs discussion
  • force recalculation of all formulas after adding/removing/changing of grade items
  • better delete support - needs discussion
  • support for NULLs n backup - Eloy already proposed a solution
  • support for NULLs in set_field()
  • speedup
  • more unit tests nd functional tests
Please review (or even commit if ok)
Hide
Permalink
Hui Chun Kit added a comment -

Dear all,

Would it be possible to rewrite the UI code for the gradebook as well. I wonder if we can use the table form (like the one used in user module) to display the grades so as to make it easier to track and follow.

Besides, would it be possible to let users choose which user fields (or even user profile fields) will be displayed/exported ? This will be a very nice feature.

If there are anything I can help, I will do it.

Cheers,
Jacky Hui
Hong Kong

Show
Hui Chun Kit added a comment - Dear all, Would it be possible to rewrite the UI code for the gradebook as well. I wonder if we can use the table form (like the one used in user module) to display the grades so as to make it easier to track and follow. Besides, would it be possible to let users choose which user fields (or even user profile fields) will be displayed/exported ? This will be a very nice feature. If there are anything I can help, I will do it. Cheers, Jacky Hui Hong Kong
Hide
Permalink
Martin Dougiamas added a comment -

Yay, great job all!

Show
Martin Dougiamas added a comment - Yay, great job all!

People

Vote (3)
Watch (7)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.