Moodle

Port complete formslib from 1.8 back to 1.7

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.7.2
  • Fix Version/s: 1.7.3
  • Component/s: Forms Library
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE

Description

There seems to be quite a few changes to formslib in 1.8 that were NOT ported to 1.7.

Has anyone got any objections to me copying the WHOLE 1.8 formslib back to 1.7?

I don't think anyone's really using it yet, and it would mean that any new 1.7 modules that use it would work better in 1.8.

Are there any problems with this that I'm not seeing?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jamie Pratt added a comment -

Most of the work on formslib was done only on 1.8. The full api is not available now in 1.7. I think that there wouldn't be any problem copying the code into 1.7. There were extensions to the questiontype and activity module apis to allow editing of qtype and modules with the new forms but they work alongside support for the old form - the old api will still work alongside the new.

I can't see that there would be any difficulties doing this.

Show
Jamie Pratt added a comment - Most of the work on formslib was done only on 1.8. The full api is not available now in 1.7. I think that there wouldn't be any problem copying the code into 1.7. There were extensions to the questiontype and activity module apis to allow editing of qtype and modules with the new forms but they work alongside support for the old form - the old api will still work alongside the new. I can't see that there would be any difficulties doing this.
Hide
Permalink
Martin Dougiamas added a comment -

OK, I think it's done.

There may be a few niggly things left, please file new bugs for those.

Show
Martin Dougiamas added a comment - OK, I think it's done. There may be a few niggly things left, please file new bugs for those.
Hide
Permalink
Petr Škoda (skodak) added a comment -

The formslib code needs some changes in weblib.php (id parameter in various functions) and maybe javascript. Please test focusing and html editor in formslib.

Show
Petr Škoda (skodak) added a comment - The formslib code needs some changes in weblib.php (id parameter in various functions) and maybe javascript. Please test focusing and html editor in formslib.
Hide
Permalink
Jamie Pratt added a comment -

I did a little testing and things seem to be working OK in course/edit2.php at least. There are a couple of styles to do with the required stuff missing. I didn't test focus and that might be broken but it will just give a js error which we just ignore for now? The htmlarea seems to work ok.

Show
Jamie Pratt added a comment - I did a little testing and things seem to be working OK in course/edit2.php at least. There are a couple of styles to do with the required stuff missing. I didn't test focus and that might be broken but it will just give a js error which we just ignore for now? The htmlarea seems to work ok.

People

Vote (0)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.