Moodle

Frameset used to display PDF

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8.1
  • Component/s: Accessibility
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

Add a resource "link to a file or web site" and link a pdf.
Visit the page with the resource.
Look at the xhtml code.
Frameset are not allowed by xhtml strict.

It exists the way to embed pdf and Moodle 1.8 should use it.
See: http://joliclic.free.fr/html/object-tag/en/index.php
or
http://joliclic.free.fr/html/object-tag/en/object-application.html#pdf
or, for details of the tested browsers and theirs plugins,
http://joliclic.free.fr/html/object-tag/en/object-results.php#browsersDetails

Issue Links

Activity

Hide
Daniele Cordella added a comment -

I forget to tell it has to be:
"Keep page navigation visible on the same page" = checked

Show
Daniele Cordella added a comment - I forget to tell it has to be: "Keep page navigation visible on the same page" = checked
Hide
Martin Dougiamas added a comment -

Hmm, PDFs have got to be the most inaccessible way ever invented for publishing a document. You can't have an accessible site AND use PDFs ...

However, we should improve XHTML strict, sure...

Show
Martin Dougiamas added a comment - Hmm, PDFs have got to be the most inaccessible way ever invented for publishing a document. You can't have an accessible site AND use PDFs ... However, we should improve XHTML strict, sure...
Hide
Martin Dougiamas added a comment -

On this page http://joliclic.free.fr/html/object-tag/en/object-application.html with firefox 2 on mac os x, none of the plugins display for me, even after I installed Adobe Reader 8.

Show
Martin Dougiamas added a comment - On this page http://joliclic.free.fr/html/object-tag/en/object-application.html with firefox 2 on mac os x, none of the plugins display for me, even after I installed Adobe Reader 8.
Hide
Nicolas Connault added a comment -

embedded PDF works on my Firefox 2 and IE 7 (on the page showed by Daniele). However it's quite probable that only a small minority of users will have the latest Adobe plugin installed for their browser.

Show
Nicolas Connault added a comment - embedded PDF works on my Firefox 2 and IE 7 (on the page showed by Daniele). However it's quite probable that only a small minority of users will have the latest Adobe plugin installed for their browser.
Hide
Daniele Cordella added a comment -

I do use the PDF Browser Plugin 2.2.3 from Manfred Shubert on my MacOS X PPC. I took it from http://www.schubert-it.com/pluginpdf/ and I see PDF correctly.
I was not able (shhhhh don't share this information) to install a PDF plugin (PDF Browser Plugin 2.2.3 or Adobe Reader 8) on my MacOS X Intel.

Show
Daniele Cordella added a comment - I do use the PDF Browser Plugin 2.2.3 from Manfred Shubert on my MacOS X PPC. I took it from http://www.schubert-it.com/pluginpdf/ and I see PDF correctly. I was not able (shhhhh don't share this information) to install a PDF plugin (PDF Browser Plugin 2.2.3 or Adobe Reader 8) on my MacOS X Intel.
Hide
Daniele Cordella added a comment -

> Hmm, PDFs have got to be the most inaccessible way ever invented for publishing a document. You can't have an accessible site AND use PDFs

You are right and I agree with you.
There are a lot of issues to talk about but... I don't want to.
Let me close saying, "You are right Martin and I would agree with you."

Show
Daniele Cordella added a comment - > Hmm, PDFs have got to be the most inaccessible way ever invented for publishing a document. You can't have an accessible site AND use PDFs You are right and I agree with you. There are a lot of issues to talk about but... I don't want to. Let me close saying, "You are right Martin and I would agree with you."
Hide
Nicolas Connault added a comment -

Embedded PDF now works fine in FF 1.5, FF 2, IE5, IE6, IE7 and Opera, and degrades beautifully in non-supported browsers (or when plugin is missing).

Show
Nicolas Connault added a comment - Embedded PDF now works fine in FF 1.5, FF 2, IE5, IE6, IE7 and Opera, and degrades beautifully in non-supported browsers (or when plugin is missing).
Hide
Daniele Cordella added a comment -

Thank you Nicolas.
> and degrades beautifully in non-supported browsers (or when plugin is missing)
I believe that if browser is not supported or plugin is missing the browser will try to download the PDF.
Is this true?

Show
Daniele Cordella added a comment - Thank you Nicolas. > and degrades beautifully in non-supported browsers (or when plugin is missing) I believe that if browser is not supported or plugin is missing the browser will try to download the PDF. Is this true?
Hide
Daniele Cordella added a comment -

Important warning:
I just downloaded the file
<?php // $Id: resource.class.php,v 1.62 2007/04/05 05:51:12 nicolasconnault Exp $
and nothing more. I don't know if there are more files to download in order to see your improvement (see: my post in http://moodle.org/mod/forum/discuss.php?d=68499)

I tried it and... I can't see the PDF unless I add width="300" height="200" to
<object data="http://daniele-ure.local/%7Edaniele/moodle18/file.php/2/sitoISS.pdf" type="application/pdf">
I feel that width and height are necessary! otherwise people can't see embedded pdfs.

To summarize:
What I have is this
<div class="resourcepdf">
<object data="http://daniele-ure.local/%7Edaniele/moodle18/file.php/2/sitoISS.pdf" type="application/pdf">
[[clicktoopen]]
<a href="http://daniele-ure.local/%7Edaniele/moodle18/file.php/2/sitoISS.pdf"> PDF </a>
</object>
</div>
<div class="box generalbox generalboxcontent boxaligncenter">
<p> PDF </p>
</div>
and doesn't work.

If I change it to
<div class="resourcepdf">
<object data="http://daniele-ure.local/%7Edaniele/moodle18/file.php/2/sitoISS.pdf" type="application/pdf" width="300" height="200">
[[clicktoopen]]
<a href="http://daniele-ure.local/%7Edaniele/moodle18/file.php/2/sitoISS.pdf"> PDF </a>
</object>
</div>
<div class="box generalbox generalboxcontent boxaligncenter">
<p> PDF </p>
</div>
it works

Show
Daniele Cordella added a comment - Important warning: I just downloaded the file <?php // $Id: resource.class.php,v 1.62 2007/04/05 05:51:12 nicolasconnault Exp $ and nothing more. I don't know if there are more files to download in order to see your improvement (see: my post in http://moodle.org/mod/forum/discuss.php?d=68499) I tried it and... I can't see the PDF unless I add width="300" height="200" to <object data="http://daniele-ure.local/%7Edaniele/moodle18/file.php/2/sitoISS.pdf" type="application/pdf"> I feel that width and height are necessary! otherwise people can't see embedded pdfs. To summarize: What I have is this <div class="resourcepdf"> <object data="http://daniele-ure.local/%7Edaniele/moodle18/file.php/2/sitoISS.pdf" type="application/pdf"> [[clicktoopen]] <a href="http://daniele-ure.local/%7Edaniele/moodle18/file.php/2/sitoISS.pdf"> PDF </a> </object> </div> <div class="box generalbox generalboxcontent boxaligncenter"> <p> PDF </p> </div> and doesn't work. If I change it to <div class="resourcepdf"> <object data="http://daniele-ure.local/%7Edaniele/moodle18/file.php/2/sitoISS.pdf" type="application/pdf" width="300" height="200"> [[clicktoopen]] <a href="http://daniele-ure.local/%7Edaniele/moodle18/file.php/2/sitoISS.pdf"> PDF </a> </object> </div> <div class="box generalbox generalboxcontent boxaligncenter"> <p> PDF </p> </div> it works
Hide
Nicolas Connault added a comment -

Please check the version control tab, you will see that there is a css file you need to update as well. We always try to avoid hard-coding visual elements in php files.

Show
Nicolas Connault added a comment - Please check the version control tab, you will see that there is a css file you need to update as well. We always try to avoid hard-coding visual elements in php files.
Hide
Nicolas Connault added a comment -

> I believe that if browser is not supported or plugin is missing the browser will try to download the PDF.
> Is this true?

No it will just display a link to the file. That is the correct behaviour, because the resource is set to open up in the same window, keeping the navigation.

Show
Nicolas Connault added a comment - > I believe that if browser is not supported or plugin is missing the browser will try to download the PDF. > Is this true? No it will just display a link to the file. That is the correct behaviour, because the resource is set to open up in the same window, keeping the navigation.
Hide
Daniele Cordella added a comment -

> Please check the version control tab
in the cvs web page?
in the plug in?
Please, let me uderstand...
TIA

Show
Daniele Cordella added a comment - > Please check the version control tab in the cvs web page? in the plug in? Please, let me uderstand... TIA
Hide
Daniele Cordella added a comment -

I don't know what the "version control tab" is
but I found the update in the standard layout.css and I applied it.
It works greatly. Congratulation Nicolas.

Show
Daniele Cordella added a comment - I don't know what the "version control tab" is but I found the update in the standard layout.css and I applied it. It works greatly. Congratulation Nicolas.
Hide
Daniele Cordella added a comment -

Ok Nicolas
by reading the answer of Tim Hunt in http://moodle.org/mod/forum/discuss.php?d=68499
I now understand what you wrote.
Thank you. It is simple but I didn't know.
Thank you to everybody.

Show
Daniele Cordella added a comment - Ok Nicolas by reading the answer of Tim Hunt in http://moodle.org/mod/forum/discuss.php?d=68499 I now understand what you wrote. Thank you. It is simple but I didn't know. Thank you to everybody.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: