Moodle

BROKEN (2007-07-07) Add a resource... / Link to file or web site. / Window: same window / Keep page navigation visible

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8.1, 1.9
  • Component/s: Resource
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

Using Moodle 1.8 - latest that went online at noon on April 7, 2007 (Japan Standard Time)

This doesn't work now.

Add a resource...

Link to file or web site.

Window: same window

Keep page navigation visible on the same page CHECKED

(Plus all previously done ones, quit working correctly – instead trying to display an image, apparently.)

PS: I hate the fact that the "Summary" is now a requied field.

Issue Links

Activity

Hide
Nicolas Connault added a comment -

Not sure what you mean here. What type of file are you trying to link to? Some types (video, pdf, mp3) require plug-ins before they can work with these settings.

What are "previously done ones"? And how do they not work correctly?

The summary field being required is unrelated to this issue, and is not a bug anyway. You could submit a request for enhancement, asking that such field be only required optionally (based on a setting).

Show
Nicolas Connault added a comment - Not sure what you mean here. What type of file are you trying to link to? Some types (video, pdf, mp3) require plug-ins before they can work with these settings. What are "previously done ones"? And how do they not work correctly? The summary field being required is unrelated to this issue, and is not a bug anyway. You could submit a request for enhancement, asking that such field be only required optionally (based on a setting).
Hide
Nicolas Connault added a comment -

Resolved, see MDL-9241

Show
Nicolas Connault added a comment - Resolved, see MDL-9241
Hide
Charles Kelly added a comment -

I downloaded Moodle 1.8+ (April 11, 2007) and the problem still seems to exist.

You can see screen shots of what I see here.
http://www.manythings.org/tesl/moodle/problem1/

Show
Charles Kelly added a comment - I downloaded Moodle 1.8+ (April 11, 2007) and the problem still seems to exist. You can see screen shots of what I see here. http://www.manythings.org/tesl/moodle/problem1/
Hide
Charles Kelly added a comment -

Perhaps this will help you track down the bug.

1. In the install of Moodle 1.8+ (April 11, 2007)
It tries to embed the page with the OBJECT tag.

This is is the relavent HTML code.

<div id="content">
<div class="resourcepdf"><object data="http://www.DOMAIN_NAME.com/index.php?n=Lesson1.Lesson1" type="application/pdf">[[clicktoopen]]<a href="http://www.DOMAIN_NAME.com/index.php?n=Lesson1.Lesson1">harm harm</a></object></div><div class="box generalbox generalboxcontent boxaligncenter"><p>harm harm</p></div><img class="spacer" height="20" width="20" src="http://study.aitech.ac.jp/siu/pix/spacer.gif" alt="" /><br />
</div> <!-- end div containerContent -->

2. In the older install of Moodle 1.8+, it properly puts the page in a frame.
Here is partial HTML code from the page.

<frameset rows="130,*"><frame src="view.php?id=4187&type=file&frameset=top" title="Resource"/>
<frame src="http://www.DOMAIN_NAME.com/index.php?n=Lesson1.Lesson1" title="Resource"/></frameset></html>

Show
Charles Kelly added a comment - Perhaps this will help you track down the bug. 1. In the install of Moodle 1.8+ (April 11, 2007) It tries to embed the page with the OBJECT tag. This is is the relavent HTML code. <div id="content"> <div class="resourcepdf"><object data="http://www.DOMAIN_NAME.com/index.php?n=Lesson1.Lesson1" type="application/pdf">[[clicktoopen]]<a href="http://www.DOMAIN_NAME.com/index.php?n=Lesson1.Lesson1">harm harm</a></object></div><div class="box generalbox generalboxcontent boxaligncenter"><p>harm harm</p></div><img class="spacer" height="20" width="20" src="http://study.aitech.ac.jp/siu/pix/spacer.gif" alt="" /><br /> </div> <!-- end div containerContent --> 2. In the older install of Moodle 1.8+, it properly puts the page in a frame. Here is partial HTML code from the page. <frameset rows="130,*"><frame src="view.php?id=4187&type=file&frameset=top" title="Resource"/> <frame src="http://www.DOMAIN_NAME.com/index.php?n=Lesson1.Lesson1" title="Resource"/></frameset></html>
Hide
Nicolas Connault added a comment -

Charles, today is the 13th of April, I have fixed this at least 24 hours ago, and cannot reproduce this issue at all. Please update your whole installation and tell me if you are still getting this problem.

Show
Nicolas Connault added a comment - Charles, today is the 13th of April, I have fixed this at least 24 hours ago, and cannot reproduce this issue at all. Please update your whole installation and tell me if you are still getting this problem.
Hide
Martin Dougiamas added a comment -

Charles, the reason for the change is accessibility and XHTML compliance ... old-style frames are not allowed in XHTML Strict 1.0. It's a bummer I know but blame W3C ...

You either need a new Acrobat plugin to see it embedded, or you should see a link to the file so it can be displayed seperately.

Nicolas, is the missing [[clicktoopen]] string fixed too?

Show
Martin Dougiamas added a comment - Charles, the reason for the change is accessibility and XHTML compliance ... old-style frames are not allowed in XHTML Strict 1.0. It's a bummer I know but blame W3C ... You either need a new Acrobat plugin to see it embedded, or you should see a link to the file so it can be displayed seperately. Nicolas, is the missing [[clicktoopen]] string fixed too?
Hide
Charles Kelly added a comment -

The problem is that the file in question is a PHP (HTML) file, not a PDF file.

I assume that Moodle thinks it's a PDF (class=resourcepdf). Perhaps you have a typo somewhere with "pdf" where "php" should be (or visa-versa).

Here's a real UR that you can test it with:
http://www.manythings.org/tesl/moodle/index.php?n=Hacks.HowToGetMoodleToUseStudentNumbersCorrectly

It's the kind of URL generated by PmWiki (http://pmwiki.org/)

Show
Charles Kelly added a comment - The problem is that the file in question is a PHP (HTML) file, not a PDF file. I assume that Moodle thinks it's a PDF (class=resourcepdf). Perhaps you have a typo somewhere with "pdf" where "php" should be (or visa-versa). Here's a real UR that you can test it with: http://www.manythings.org/tesl/moodle/index.php?n=Hacks.HowToGetMoodleToUseStudentNumbersCorrectly It's the kind of URL generated by PmWiki (http://pmwiki.org/)
Hide
Nicolas Connault added a comment -

Charles, please do a diff of your files against the current CVS, because this issue has been resolved for nearly a week now, as you can see in the latest attached screenshot. Maybe some of your local files have been modified by hand.

Show
Nicolas Connault added a comment - Charles, please do a diff of your files against the current CVS, because this issue has been resolved for nearly a week now, as you can see in the latest attached screenshot. Maybe some of your local files have been modified by hand.
Hide
Anthony Borrow added a comment -

Nicolas - I'm working off of CVS as of 06-13-07 and I'm having an issue with adding a resource - in this case a word document. I have it set to same window and the "Keep page navigation visible on the same page" option is not checked. When I click Save changes it pulls up the file in Microsoft Word; however, it does not navigate off of the page to edit or add the resource. If I continue to hit save changes I get multiple copies of the same resource. If I check the "Keep page navigation visible on the same page" box or set it to new window then I am redirected to: https://moodle2.jesuitcp.org/test/18stablepatches20070612/mod/resource/view.php?id=20320 which is what I would expect. I'm not sure if this is the same issue but it seems somewhat similar. Any thoughts?

Show
Anthony Borrow added a comment - Nicolas - I'm working off of CVS as of 06-13-07 and I'm having an issue with adding a resource - in this case a word document. I have it set to same window and the "Keep page navigation visible on the same page" option is not checked. When I click Save changes it pulls up the file in Microsoft Word; however, it does not navigate off of the page to edit or add the resource. If I continue to hit save changes I get multiple copies of the same resource. If I check the "Keep page navigation visible on the same page" box or set it to new window then I am redirected to: https://moodle2.jesuitcp.org/test/18stablepatches20070612/mod/resource/view.php?id=20320 which is what I would expect. I'm not sure if this is the same issue but it seems somewhat similar. Any thoughts?
Hide
Elena Ivanova added a comment -

Hi, same issue here. We have Moodle 1.8.2+ (2007021520).
If I try to add any kind of downloadable file (ppt, word, etc), and then click Save Changes button, I will stay on the same Adding a Resource page, and Moodle will try to open a document. Regardless of my answer (open or cancel, or save), I remain on the Adding a new Resource page.
Funnny, the resource is actually already added to the homepage, I just do not see it, since I am stuck on the Adding page. I ended up with 10 links to the same resoucre, before I have realized that.
I think this is major bug. Can we reopen?

Show
Elena Ivanova added a comment - Hi, same issue here. We have Moodle 1.8.2+ (2007021520). If I try to add any kind of downloadable file (ppt, word, etc), and then click Save Changes button, I will stay on the same Adding a Resource page, and Moodle will try to open a document. Regardless of my answer (open or cancel, or save), I remain on the Adding a new Resource page. Funnny, the resource is actually already added to the homepage, I just do not see it, since I am stuck on the Adding page. I ended up with 10 links to the same resoucre, before I have realized that. I think this is major bug. Can we reopen?
Hide
louise davies added a comment -

Similar issue here as well. We have Moodle 1.8.1. When I click the Save Changes button a File Download box appears with options to Open, Save or Cancel. If I click 'Open', the document opens in the same window but then when I click the browser back button I am taken to the same Adding a Resource page. Every time I click Save Changes from this point it adds an extra icon to the homepage. (I also think that this is a major bug...)

Also, is there a setting to automatically check the 'Keep page navigation visible on the same page' checkbox? I understand why it's been turned off for XHTML compliance issues but is there a way to turn it back on as the default?

Show
louise davies added a comment - Similar issue here as well. We have Moodle 1.8.1. When I click the Save Changes button a File Download box appears with options to Open, Save or Cancel. If I click 'Open', the document opens in the same window but then when I click the browser back button I am taken to the same Adding a Resource page. Every time I click Save Changes from this point it adds an extra icon to the homepage. (I also think that this is a major bug...) Also, is there a setting to automatically check the 'Keep page navigation visible on the same page' checkbox? I understand why it's been turned off for XHTML compliance issues but is there a way to turn it back on as the default?

People

Dates

  • Created:
    Updated:
    Resolved: