Moodle

Works fine for me in latest 1.8+ in FF, Konqueror, IE and Opera.

It doesn't work for me on Firefox Mac or Win using the most recent versions of each.

Could you please try other PC and other Moodle server, I need to replicate it in order to fix it

I'm getting the same problem, click on the button and absolutely nothing happens, no pop-up blockers are enabled or anything, using MS IE 7.0.5730.11... doesnt seem to work in FF either. Haven't checked other browsers.

Say if you need more info, am watching this case.

Linked MDL-10278, Exactly the same issue.

I need a way to reproduce it on my computer, it works fine here in FF, sorry
Did you check your browser extensions and personal firewall? It might be silently blocking opening of new windows...

It's happening on every computer in our college, I'll see if I can get you some kind of remote access so you can have a look.

The function 'setup_elements' in /mod/resource/type/file/resource.class.php is broken IMHO.

$searchbutton = $mform->addElement('button', 'searchbutton', get_string('searchweb', 'resource').'...');
$buttonattributes = array('title'=>get_string('searchweb', 'resource'),'onclick'=>"return window.open('$CFG->resource_websearch', 'websearch', 'menubar=1,location=1,directories=1,toolbar=1,scrollbars,resizable,width=800,height=600');");
$searchbutton->updateAttributes($buttonattributes);

I don't know enough about Moodle's OOP to track the error.... The third line does not appear to add the Title or Onclick to the searchbutton object.

Ralph

p.s. There is a 'typo' on the second line (1.8.2+) *fixed above. Places the wrong title 'localfilechoose' ... a moot point since the popup script is never attached to the button.

This is a strange problem for two reasons:

1) It occurs on some Moodle servers and not on others. I've got two instance of Moodle running out of the same repository, one of them remotely and the other one locally. The server settings differ slightly, but for some reason, on the local instance I do not get the error but on the remote instance I do.

2) Also strange because the "Choose or upload a file..." button gets generated exactly the same way ( addElement() -> updateAttributes($buttonattributes) ) yet it works just fine while the websearch one does not.

However, neither generate by the method I personally prefer, the one that gets used in course/edit_form.php, where it feeds the attributes directly into the addElement() parameter rather than assigning them after-the-fact. As I knew this method operated as expected, I switched the way the addElement on line 631 worked to the latter method - it now works as intended.

Replace lines 630 - 634:

if (!empty($CFG->resource_websearch)) { $searchbutton = $mform->addElement('button', 'searchbutton', get_string('searchweb', 'resource').'...'); $buttonattributes = array('title'=>get_string('localfilechoose', 'resource'), 'onclick'=>"return window.open('$CFG->resource_websearch', 'websearch', 'menubar=1,location=1,directories=1,toolbar=1,scrollbars,resizable,width=800,height=600');"); $searchbutton->updateAttributes($buttonattributes); }

With these lines:

if (!empty($CFG->resource_websearch)) { $searchbutton = $mform->addElement('button', 'searchbutton', get_string('searchweb', 'resource'), array('title'=>get_string('searchweb', 'resource'), 'onclick'=>"return window.open('$CFG->resource_websearch', 'websearch', 'menubar=1,location=1,directories=1,toolbar=1,scrollbars,resizable,width=800,height=600');")); }

In the long run, it might be worth it to consider if this button really adds any functionality. It seems mostly superfluous, especially as it doesn't provide a means of capturing a URL without having to do copy + paste. Moodle also doesn't present admins with the ability to change the search engine used, counterintuitive to the rest of the way the system seems to operate.

I was able to verify that the attributes that Moodle assigns in /mod/resource/type/file/resource.class.php are being passed to the Pear library correctly. It seems to be a problem with the printing out of the buttons not the input of data. I have yet to figure out where the form gets printed. For me the problem happens on our PHP 4 server, but the code is generated correctly on my local copy running PHP 5.

My guess is that this probably has something then with Pear's object oriented code or Moodle's object oriented code that is different between the two versions of php.

Yes, Jason is right.

I can also verify that, the problem occurs in my local server running with PHP 4.3.10 while it run just fine in my other server with PHP 5.2.0.

Hello,
the resource module was rewritten in 2.0. Please file new issues if necessary.

Petr Škoda