Details
Bug
Description
Judging from inline comments this is a know issue:
// PARAM_URL requires a genuine TLD (I think) This breaks my testing
$temp_wwwroot = clean_param($form->wwwroot, PARAM_URL);
if ($temp_wwwroot !== $form->wwwroot) {
trigger_error("We now parse the wwwroot with PARAM_URL. Your URL will need to have a valid TLD, etc.");
error(get_string("invalidurl", 'mnet'),'peers.php');
exit;
}
unset($temp_wwwroot);
I do not think that we need to clean the url that is submitted by amin, because mnet should be IMHO usable in intranets that are using compaly.local or company.lan domains too.
Issue Links
| This issue will help resolve: | ||||
| MDL-11880 | Running on localhost, when you create a question from the quiz editing screen, you end up on the question bank screen |
|
|
|
| This issue is duplicated by: | ||||
| MDL-9955 | would be nice if PARAM_URL let through urls with localhost in them for those of us developing on a local server. |
|
|
|
Agree that it should be usable on intranets. But if we use PARAM_RAW we would need some extra validation. PARAM_URL internally uses functions from lib/validateurlsyntax.php - perhaps we can add an option to relax domain checks.