Moodle

mnet logout broken by auth refactoring

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.8.3
  • Component/s: MNet
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

see MDL-8973 for description of the problem

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

Proposed patch did not contain condition to run the hook only when mnet enabled.

going to commit:
function prelogout_hook() {
global $MNET, $CFG, $USER;
if (!is_enabled_auth('mnet')) { return; }

please review and close if ok

Show
Petr Škoda (skodak) added a comment - Proposed patch did not contain condition to run the hook only when mnet enabled. going to commit: function prelogout_hook() { global $MNET, $CFG, $USER; if (!is_enabled_auth('mnet')) { return; } please review and close if ok
Hide
Permalink
Martín Langhoff added a comment -

Donal - is this what you were worried about?

Show
Martín Langhoff added a comment - Donal - is this what you were worried about?
Hide
Permalink
Donal McMullan added a comment -

I just tested this on 2 * checkouts of MOODLE_18 _STABLE, and it worked fine. I'm happy to close.

Show
Donal McMullan added a comment - I just tested this on 2 * checkouts of MOODLE_18 _STABLE, and it worked fine. I'm happy to close.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.