Issue Details (XML | Word | Printable)

Key: MDL-9375
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Tim Hunt
Reporter: Olli Salo
Votes: 8
Watchers: 8
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Each attempt builds on last with multi-page quizzes gives the wrong score on the second and later attempts

Created: 16/Apr/07 02:30 PM   Updated: 16/Nov/07 01:52 AM
Return to search
Component/s: Quiz
Affects Version/s: 1.6.5, 1.7.3, 1.8.3
Fix Version/s: 1.6.6, 1.7.4, 1.8.4

Environment: Postgres 8.2.0, PHP 4.3.9, Mdl 1.6.5+ (dated April 13th) CVS.
Issue Links:
Duplicate
 

Database: PostgreSQL
Participants: Olli Salo, Paulo Matos, Peter Ruthven-Stuart, Peter Sereinigg, Tim Hunt and Wen Hao Chuang
Security Level: None
Resolved date: 31/Oct/07
Affected Branches: MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE
Fixed Branches: MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE


 Description  « Hide
It seems that there is still something wrong with the "builds up on the last" feature when the questions are distributed on several quiz pages. The problem is that when a quiz with several pages is taken, the answers are recorded correctly for the first page.

Steps to reproduce:

1) Use Mdl 1.6.5+ code and create a quiz with e.g. 30 random questions on 6 pages (5 questions per page)

2) Take the exam and answer the questions on the 1st page: everything OK here, grade is OK and the answers are saved and shown correctly after the quiz. You might have e.g. 130 points at this moment.

3) Take the exam again and answer a question (or more) on the second or latter question pages.

4) Submit the quiz. Now your grade should be 160 point or more. What happens, however, is that your score goes down from 130 to 30, that is: your answers from the 1st question page are not calculated at all, even though you can see your answers for the 1st page (at the review quiz -situation). The answers are correct, but the resulting grade is not.

This bug must be closely linked to the bug I submitted some weeks earlier: http://tracker.moodle.org/browse/MDL-8958

At that time, the bug got fixed OK with one single question page, but apparently having questions distributed on several pages was a thing which none of us remembered to check.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
tjhunt committed 1 file to 'Moodle CVS' on branch 'MOODLE_17_STABLE' - 31/Oct/07 03:22 AM
MDL-9375 (and dups) - Each attempt builds on last with multi-page quizzes gives the wrong score on the second attempt. It turns out that this was already fixed in Moodle 1.9 (part of commit 1.115 -> 1.116) so I have just backported the relevant changes. I have tested that this fixes the reported problem. I have not had time to test that it does not break one of the other billion possible combinations of settings possible with the quiz. Code review and testing welcome.
MODIFY mod/quiz/attempt.php   Rev. 1.98.2.4    (+31 -35 lines)
tjhunt committed 1 file to 'Moodle CVS' on branch 'MOODLE_16_STABLE' - 31/Oct/07 03:22 AM
MDL-9375 (and dups) - Each attempt builds on last with multi-page quizzes gives the wrong score on the second attempt. It turns out that this was already fixed in Moodle 1.9 (part of commit 1.115 -> 1.116) so I have just backported the relevant changes. I have tested that this fixes the reported problem. I have not had time to test that it does not break one of the other billion possible combinations of settings possible with the quiz. Code review and testing welcome.
MODIFY mod/quiz/attempt.php   Rev. 1.87.6.3    (+31 -36 lines)
tjhunt committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 31/Oct/07 03:22 AM
MDL-9375 (and dups) - Each attempt builds on last with multi-page quizzes gives the wrong score on the second attempt. It turns out that this was already fixed in Moodle 1.9 (part of commit 1.115 -> 1.116) so I have just backported the relevant changes. I have tested that this fixes the reported problem. I have not had time to test that it does not break one of the other billion possible combinations of settings possible with the quiz. Code review and testing welcome.
MODIFY mod/quiz/attempt.php   Rev. 1.103.2.10    (+31 -36 lines)