|
[
Permalink
| « Hide
]
Martin Dougiamas added a comment - 16/Apr/08 04:00 PM
Why is this assigned to you, Dan? Did you want it?
it was posted in the forums and I asked them to post a diff in the tracker - I was working on some scorm related stuff before my new job @ catalyst, and was planning to help tidy it up.....but now I don't seem to have the time sorry!
 - someone else is welcome to it! Dongsheng can you experiment with this patch and some scorm modules? if there's no regressions for you please put it in HEAD only, we can get some more feedback before backporting to 1.9 later
It worked, I didn't find any problem by far. Thanks Jesús
re-opening - this needs to be backported to 1.9stable and 1.8stable
Dan Are the fixed files available anywhere for 1.9.x? I don't think I've seen them appear in the CVS for 1.9.x yet. If they are already included in the latest 2.0 build (and are the same), I could download it and borrow them from there.
Hi Larry,
afaik, the patches above should work in 1.9 without too much adjustment, we hope to fix this in 1.9 and 1.8 in the next few weeks. thanks,
Dan Hi -
I've uploaded two patch files to backport the changes to HEAD. Could someone please review and apply to 1.8 and 1.9. I have also tentatively created the equivalent patch for1.7, but am a little concerned here as the code base starts deviating a lot at this point - I will pursue this if others feel it worth while. Cheers, Hi Piers,
sounds good. - I'll try to have a look at them over the weekend or early next week. the TOC changes - if there isn't an existing bug you can add the patches to, create a new issue in the tracker and assign in to yourself and add the patches there! good work!
Dan Same as for 1.9 and 1.8, I've created a backport patch for 1.7 to complete changes allready applied to HEAD - please use patch -p0 in ./mod/scorm . In order to process the patch. the attached rd.js file must also be placed in the mod/scorm directory.
This patch may not be wanted, but has been completed as I was working in the same area anyway. As with the attached 1.8, and 1..9 patches, please review, and let me know if they are to be applied to the STABLE branches. Thanks, Hi Piers,
Will hopefully get a chance to review these early this week!
Dan Hi Piers,
looks good! - can you please now apply this to 1.8Stable and 1.9Stable? thanks!
Dan After applying the changes posted in CVS today, the scorm box is still smal and right justified on our build
larry As per my previous comment
larry Hi Larry,
thanks for having a look - can you please provide the scorm object (maybe via e-mail) so we can test/debug the issue?
thanks,
Dan in fact.... they only went into Developer CVS 30min ago..... did you get it from public CVS (not updated yet) or developer cvs?
public CVS will take a couple of hours to be updated normally. thanks,
Dan Public CVS Dan
I received nootification from [Moodle CVS] moodle/mod/scorm/rd.js;moodle/mod/scorm/styles.php;moodle/mod/scorm/player.php: and then updated my production box using cvs -q update -dP -r MOODLE_19_STABLE If it was too soon, I' try again in about 7 hours. (10:40 pm here now) I' send the scorm object and give you access to the server if you wish. What email address should I use? larry thanks Larry! public cvs might not be updated quite yet - shouldn't be longer than 2 hours though!
the more scorm objects we have, the better we are able to test! -since piers is working on this one, could you e-mail him the object at piers@catalyst.net.nz thanks!
Dan Hi Piers,
Larry' issue is related to our use of CSS classes in the new patch: we use class="right" and class="left" in the new patch as the following items are created in styles.php: .mod-scorm .left {
text-align: left;
} IMO using the class names "right", "left" and "center" are too general in terms of naming - I'm sure there are some guidelines on CSS we should be following and there's a bug open for improving the css in MDL-7787 - I'm sure Urs could give some guidence on how to improve the CSS in SCORM Hi Dan - you are right. The CSS naming conventions could be improved, or more specific CSS selectors used.
However - I would recommend that this be done when mod/scorm is overhauled to attain compliance, as there is a considerable amount of refactoring that should be done at the same time. Cheers, fair enough - although as the CSS selectors are ones that we have introduced as part of this patch, we should improve it by using specific selectors before closing this particular bug - we can address the CSS as a whole later as part of MDL-7787, but by using general CSS selectors in this patch, we are introducing bugs to the SCORM module that weren't there before (even though it improves the display for 80% of users)
I suggest we change the right, left, and center classes to something like "scormright" "scormleft" "scormcenter" etc.
Dan OK - will do. Will start with patching head ...
Cheers. OK - patched HEAD, 1.9, and 1.8. CSS class names are now scorm-left, scorm-center, and scorm-right.
Cheers. great! - good work Piers!
lets announce this in the Scorm forum after the next weekly build has been created! thanks,
Dan Thanks Piers and Dan
Works for me!! larry thanks for the help with testing Larry!
Dan This is the same problem... and it looks to be unsolved
 I would like to spend some money for solve it. Anybody would like to do the job? It continues with the double scroll bars (vertical scroll for SCORM content and vertical scroll for Moodle window)... Any action to solve it? Thanks!
Hi David:
If the page showing the SCORM is footer must show both bars, but SCORM window would be very small. Can you attach a screenshot? Regards Hi there - this bug was related to a patch that was provided and applied - any other issues related to SCORM should use a different issue - I see you've commented on other CSS related issues in the tracker - flagging this as fixed again, and reverting the fix versions.
heh - Hi Jesús looks like we're both responding at the same time! - please continue discussion on one of the open CSS/Theme related bugs, David has also commented on MDL-19954
thanks! Changes seems to doesn't be in Moodle Stable release yet... What's the problem?
Hi David,
this patch went into 1.9 stable quite a while back - the search on git.moodle.org shows this: also if you select the "version control" tab on this Tracker issue it will show all the CVS commits related to this issue there are some existing issues with the CSS in the SCORM mod which are currently in other open bugs hope that makes sense! thanks, It has no sense.... As Jesús Rincon and me told, MultiSCO SCORM packages aren't well viewed from years ago. Solution is offered by Jesús Rincón a long time ago... and improve a lot the actual SCORM player view. Please, when could I see changes in stable releases. Many clients from non academic market needs a better SCORM player view.
As you know, one month ago Jesús upload the files with solutons. You only need to change it on stable release. CSS "problems" aren't minimal in front the horrible scorm viewer.... Don't you believe me? Hi David,
Jesús provided a patch on this bug in 2008 which was reviewed and committed into 1.9 stable 1.8 stable and HEAD by Piers back in July 2008 - If you are referring to the new patch that Jesús has provided on MDL-19954 - that bug is still open and further discussion should be made there. There isn't currently any funding for SCORM maintenance or support - We do this in our own free time. I don't just apply patches without reviewing them and any changes to CSS or structure of the CSS inside a SCORM package need to be tested well as they could cause regressions for people using customised themes. I have been planning to spend some time over the next couple of weeks on SCORM, but unless someone else has some free time to review and commit - you will need to wait. thanks, |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
New Feature
Resolved
Critical
New visualization for SCORM
 |
|
