Moodle

Run *.xhtml file through the text filters.

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.7.2
  • Fix Version/s: DEV backlog
  • Component/s: Filters
  • Labels:
    None
  • Environment:
    All
  • Affected Branches:
    MOODLE_17_STABLE

Description

Following on from adding "application/xhtml+xml" mime type for *.xhtml resource files (http://tracker.moodle.org/browse/MDL-9403), it would be helpful to run them through the text filters.

The attached file works for me, but Petr ?koda says that other stuff needs to be changed as well - I don't know what though.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Balch added a comment -

Updated patch to allow filtering on .xhtml files.

Show
David Balch added a comment - Updated patch to allow filtering on .xhtml files.
Hide
Permalink
David Balch added a comment -

Hi, this should be a better patch for filtering .xhtml files - my patch from 9/Apr/07 can be deleted.

Show
David Balch added a comment - Hi, this should be a better patch for filtering .xhtml files - my patch from 9/Apr/07 can be deleted.
Hide
Permalink
David Balch added a comment -

Reworked patch to add XHTML support to Moodle text filters. Ammends send_file() and send_stored_file().

Show
David Balch added a comment - Reworked patch to add XHTML support to Moodle text filters. Ammends send_file() and send_stored_file().
Hide
Permalink
David Balch added a comment -

Oh, I should have mentioned that the patch I uploaded today is against cvshead, although hopefully it could also be backported to (1.9 and even 1.8).

Show
David Balch added a comment - Oh, I should have mentioned that the patch I uploaded today is against cvshead, although hopefully it could also be backported to (1.9 and even 1.8).
Hide
Permalink
David Balch added a comment -

Patch to enable text filtering of .xhtml files, written and tested on M19 (git commit a4e6bba980cafd6ad7d05f6df76bfc205406eed1 )

Show
David Balch added a comment - Patch to enable text filtering of .xhtml files, written and tested on M19 (git commit a4e6bba980cafd6ad7d05f6df76bfc205406eed1 )
Hide
Permalink
Petr Škoda (skodak) added a comment -

The problem with 1.9.x is that adding new feature like this might create problems for people that rely on xhtml not being filtered.
In 2.0 the uploaded file filtering will be completely rewritten, see the resource rewrite proposal http://moodle.org/mod/forum/discuss.php?d=125824

In any case thanks for the patch.

Show
Petr Škoda (skodak) added a comment - The problem with 1.9.x is that adding new feature like this might create problems for people that rely on xhtml not being filtered. In 2.0 the uploaded file filtering will be completely rewritten, see the resource rewrite proposal http://moodle.org/mod/forum/discuss.php?d=125824 In any case thanks for the patch.
Hide
Permalink
David Balch added a comment -

Ah, ok. I'll just have to keep it in my M19 clone, and lobby for XHTML filtering in 2.0.

Show
David Balch added a comment - Ah, ok. I'll just have to keep it in my M19 clone, and lobby for XHTML filtering in 2.0.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.